All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: XFS Mailing List <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: fix bad hash ordering
Date: Tue, 1 Apr 2014 08:40:16 +1100	[thread overview]
Message-ID: <20140331214016.GD17603@dastard> (raw)
In-Reply-To: <53399B06.5010400@sgi.com>

On Mon, Mar 31, 2014 at 11:42:46AM -0500, Mark Tinguely wrote:
> On 03/30/14 19:10, Dave Chinner wrote:
> >On Fri, Mar 28, 2014 at 12:33:34PM -0500, Mark Tinguely wrote:
> >>Fix the fix directory "bad hash ordering" bug introduced in
> >>commit f5ea1100.
> >
> 
> ...
> 
> >
> >>---
> >>A C program that generates this problem can be found at:
> >>  http://oss.sgi.com/archives/xfs/2014-03/msg00373.html
> >>
> >>A xfstest for this bug is coming from Hannes Frederic Sowa.
> >
> >Can you convert this program to an xfstest yourself so that I can
> >commit the regression test at the same time I commit an updated
> >fix?
> 
> We narrowed the iterations down to make it a quick test.
> I have every confidence that Hannes can generate the test in a timely
> manner and I will help in any way possible.

Well, it's been over a week now and you're asking me to trust that
someone I don't know and who has never submitted an xfstests before
to do something in a timely manner so we can test a critical bug fix
during a merge window. I'm willing to be pleasently surprised, but
history tells me that people that report bugs rarely follow up with
xfstest cases and it's usually the developer that fixes the bug that
generates the xfstests patch.

So if the xfstests patch doesn't arrive in the next few hours, can
you please do that for us so I can get this sorted out for the merge
window?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-03-31 21:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28 17:33 [PATCH] xfs: fix bad hash ordering Mark Tinguely
2014-03-28 19:07 ` Ben Myers
2014-03-31  0:10 ` Dave Chinner
2014-03-31  0:35   ` Eric Sandeen
2014-03-31 16:42   ` Mark Tinguely
2014-03-31 21:40     ` Dave Chinner [this message]
2014-04-01  2:22       ` Mark Tinguely
2014-04-01 22:03         ` Dave Chinner
2014-04-07 19:00 ` [PATCH] xfsprogs: fix directory hash ordering bug Mark Tinguely
2014-04-08  8:56   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140331214016.GD17603@dastard \
    --to=david@fromorbit.com \
    --cc=tinguely@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.