[PATCH] staging: vme: Fix a small coding style issue in vme_user.c

[PATCH] staging: vme: Fix a small coding style issue in vme_user.c

[Bojan Prtvar]

The checkpatch.pl complains about missing blank line after declaration.
This patch silence the warning.

Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
---
 This patch is for Eudyptula Challenge task 10

 drivers/staging/vme/devices/vme_user.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
index 7927927..481192a 100644
--- a/drivers/staging/vme/devices/vme_user.c
+++ b/drivers/staging/vme/devices/vme_user.c
@@ -791,6 +791,7 @@ static int vme_user_probe(struct vme_dev *vdev)
 	/* Add sysfs Entries */
 	for (i = 0; i < VME_DEVS; i++) {
 		int num;
+
 		switch (type[i]) {
 		case MASTER_MINOR:
 			sprintf(name, "bus/vme/m%%d");
-- 
1.9.1.286.g5172cb3

Re: [PATCH] staging: vme: Fix a small coding style issue in vme_user.c

[walter harms]

Am 03.04.2014 00:24, schrieb Bojan Prtvar:
> The checkpatch.pl complains about missing blank line after declaration.
> This patch silence the warning.
> 
> Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
> ---
>  This patch is for Eudyptula Challenge task 10
> 
>  drivers/staging/vme/devices/vme_user.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index 7927927..481192a 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -791,6 +791,7 @@ static int vme_user_probe(struct vme_dev *vdev)
>  	/* Add sysfs Entries */
>  	for (i = 0; i < VME_DEVS; i++) {
>  		int num;
> +
>  		switch (type[i]) {
>  		case MASTER_MINOR:
>  			sprintf(name, "bus/vme/m%%d");

beside style:
that sprint looks like as it could be replaced with a
 name="bus/vme/m%%d"

any takers ?

re,
 wh

Re: [PATCH] staging: vme: Fix a small coding style issue in vme_user.c

[bojan prtvar]

On Thu, Apr 3, 2014 at 5:14 PM, walter harms <wharms@bfs.de> wrote:

> beside style:
> that sprint looks like as it could be replaced with a
>  name="bus/vme/m%%d"
>
> any takers ?
>
> re,
>  wh
>

Hi Walter,

I guess you mean something like this? Please review carefully if I got
right "%%d" intent.
Now a basic question. How to submit this properly? As a v2 patch with
both changes taken or as a two-patch serie?



diff --git a/drivers/staging/vme/devices/vme_user.c
b/drivers/staging/vme/devices/vme_user.c
index 481192a..5fa7f83 100644
--- a/drivers/staging/vme/devices/vme_user.c
+++ b/drivers/staging/vme/devices/vme_user.c
@@ -684,7 +684,7 @@ static int vme_user_match(struct vme_dev *vdev)
 static int vme_user_probe(struct vme_dev *vdev)
 {
        int i, err;
-       char name[12];
+       char *name;

        /* Save pointer to the bridge device */
        if (vme_user_bridge != NULL) {
@@ -794,13 +794,13 @@ static int vme_user_probe(struct vme_dev *vdev)

                switch (type[i]) {
                case MASTER_MINOR:
-                       sprintf(name, "bus/vme/m%%d");
+                       name = "bus/vme/m%d";
                        break;
                case CONTROL_MINOR:
-                       sprintf(name, "bus/vme/ctl");
+                       name = "bus/vme/ctl";
                        break;
                case SLAVE_MINOR:
-                       sprintf(name, "bus/vme/s%%d");
+                       name = "bus/vme/s%d";
                        break;
                default:
                        err = -EINVAL;



Regards,
Bojan

Re: [PATCH] staging: vme: Fix a small coding style issue in vme_user.c

[Greg KH]

On Thu, Apr 03, 2014 at 05:40:25PM +0200, bojan prtvar wrote:
> On Thu, Apr 3, 2014 at 5:14 PM, walter harms <wharms@bfs.de> wrote:
> 
> > beside style:
> > that sprint looks like as it could be replaced with a
> >  name="bus/vme/m%%d"
> >
> > any takers ?
> >
> > re,
> >  wh
> >
> 
> Hi Walter,
> 
> I guess you mean something like this? Please review carefully if I got
> right "%%d" intent.
> Now a basic question. How to submit this properly? As a v2 patch with
> both changes taken or as a two-patch serie?

2 patch series, or just a new patch that is on top of your previous one
and mention that in the line below the --- in the patch

thanks,

greg k-h