* [PATCH 1/1] staging: comedi: Fix checkpatch warning
@ 2014-04-04 19:15 Camille Begue
2014-04-04 19:56 ` Joe Perches
2014-04-04 21:24 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Camille Begue @ 2014-04-04 19:15 UTC (permalink / raw)
To: devel
Cc: Camille Begue, Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman,
open list
This patch is part of eudyptula challenge
Signed-off-by: Camille Begue <camille.begue44@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index ea6dc36..0f05e87 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1435,13 +1435,16 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
s = &dev->subdevices[cmd->subdev];
if (s->type == COMEDI_SUBD_UNUSED) {
- dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
+ dev_dbg(dev->class_dev,
+ "%d not valid subdevice\n",
+ cmd->subdev);
return -EIO;
}
if (!s->do_cmd || !s->do_cmdtest || !s->async) {
dev_dbg(dev->class_dev,
- "subdevice %d does not support commands\n", cmd->subdev);
+ "subdevice %d does not support commands\n",
+ cmd->subdev);
return -EIO;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] staging: comedi: Fix checkpatch warning
2014-04-04 19:15 [PATCH 1/1] staging: comedi: Fix checkpatch warning Camille Begue
@ 2014-04-04 19:56 ` Joe Perches
2014-04-04 21:24 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2014-04-04 19:56 UTC (permalink / raw)
To: Camille Begue
Cc: devel, Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman, open list
On Fri, 2014-04-04 at 21:15 +0200, Camille Begue wrote:
> This patch is part of eudyptula challenge
Hello Camille.
Please do not write commit log messages like this.
Say what's wrong with the code, not why you did it.
Write something like:
Wrap lines > 80 columns.
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
[]
> @@ -1435,13 +1435,16 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
> s = &dev->subdevices[cmd->subdev];
>
> if (s->type == COMEDI_SUBD_UNUSED) {
> - dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
> + dev_dbg(dev->class_dev,
> + "%d not valid subdevice\n",
> + cmd->subdev);
If you really want to fix > 80 column lines, it'd be
better to keep the dev_dbg and format on the same line
1 2 3 4 5 6 7 8
12345678901234567890123456789012345678901234567890123456789012345678901234567890
dev_dbg(dev->class_dev, "%d not valid subdevice\n",
cmd->subdev);
> return -EIO;
> }
>
> if (!s->do_cmd || !s->do_cmdtest || !s->async) {
> dev_dbg(dev->class_dev,
> - "subdevice %d does not support commands\n", cmd->subdev);
> + "subdevice %d does not support commands\n",
> + cmd->subdev);
> return -EIO;
> }
>
here too
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] staging: comedi: Fix checkpatch warning
2014-04-04 19:15 [PATCH 1/1] staging: comedi: Fix checkpatch warning Camille Begue
2014-04-04 19:56 ` Joe Perches
@ 2014-04-04 21:24 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-04-04 21:24 UTC (permalink / raw)
To: Camille Begue; +Cc: devel, Ian Abbott, open list, Greg Kroah-Hartman
On Fri, Apr 04, 2014 at 09:15:39PM +0200, Camille Begue wrote:
> This patch is part of eudyptula challenge
>
The changelog should mention something about lines over 80 characte
long.
> Signed-off-by: Camille Begue <camille.begue44@gmail.com>
> ---
> drivers/staging/comedi/comedi_fops.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index ea6dc36..0f05e87 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1435,13 +1435,16 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
> s = &dev->subdevices[cmd->subdev];
>
> if (s->type == COMEDI_SUBD_UNUSED) {
> - dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
> + dev_dbg(dev->class_dev,
> + "%d not valid subdevice\n",
> + cmd->subdev);
Do this instead:
dev_dbg(dev->class_dev, "%d not valid subdevice\n",
cmd->subdev);
> return -EIO;
> }
>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-04 21:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-04 19:15 [PATCH 1/1] staging: comedi: Fix checkpatch warning Camille Begue
2014-04-04 19:56 ` Joe Perches
2014-04-04 21:24 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.