* [PATCH v2] staging: comedi: drivers: pcl812.c: add curly braces for checkpatch
@ 2014-04-04 15:44 ` Kumar Amit Mehta
0 siblings, 0 replies; 4+ messages in thread
From: Kumar Amit Mehta @ 2014-04-04 15:44 UTC (permalink / raw)
To: abbotti
Cc: hsweeten, dan.carpenter, wharms, joe, gregkh, devel,
kernel-janitors, linux-kernel
Kernel style is that if one side of the if else statement gets has curly
braces then both side should have them.
Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
---
drivers/staging/comedi/drivers/pcl812.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index 160eac8..5cc01fe 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -811,8 +811,9 @@ static int pcl812_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
devpriv->ai_dma = 0;
break;
}
- } else
+ } else {
devpriv->ai_dma = 0;
+ }
devpriv->ai_act_scan = 0;
devpriv->ai_poll_ptr = 0;
--
1.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] staging: comedi: drivers: pcl812.c: add curly braces for checkpatch
@ 2014-04-04 15:44 ` Kumar Amit Mehta
0 siblings, 0 replies; 4+ messages in thread
From: Kumar Amit Mehta @ 2014-04-04 15:44 UTC (permalink / raw)
To: abbotti
Cc: hsweeten, dan.carpenter, wharms, joe, gregkh, devel,
kernel-janitors, linux-kernel
Kernel style is that if one side of the if else statement gets has curly
braces then both side should have them.
Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
---
drivers/staging/comedi/drivers/pcl812.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index 160eac8..5cc01fe 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -811,8 +811,9 @@ static int pcl812_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
devpriv->ai_dma = 0;
break;
}
- } else
+ } else {
devpriv->ai_dma = 0;
+ }
devpriv->ai_act_scan = 0;
devpriv->ai_poll_ptr = 0;
--
1.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: comedi: drivers: pcl812.c: add curly braces for checkpatch
2014-04-04 15:44 ` Kumar Amit Mehta
@ 2014-04-04 21:29 ` Dan Carpenter
-1 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-04-04 21:29 UTC (permalink / raw)
To: Kumar Amit Mehta
Cc: abbotti, devel, gregkh, kernel-janitors, linux-kernel, joe, wharms
On Fri, Apr 04, 2014 at 06:44:44PM +0300, Kumar Amit Mehta wrote:
> Kernel style is that if one side of the if else statement gets has curly
> braces then both side should have them.
>
> Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
Looks good, thanks.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: comedi: drivers: pcl812.c: add curly braces for checkpatch
@ 2014-04-04 21:29 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-04-04 21:29 UTC (permalink / raw)
To: Kumar Amit Mehta
Cc: abbotti, devel, gregkh, kernel-janitors, linux-kernel, joe, wharms
On Fri, Apr 04, 2014 at 06:44:44PM +0300, Kumar Amit Mehta wrote:
> Kernel style is that if one side of the if else statement gets has curly
> braces then both side should have them.
>
> Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
Looks good, thanks.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-04 21:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-04 15:44 [PATCH v2] staging: comedi: drivers: pcl812.c: add curly braces for checkpatch Kumar Amit Mehta
2014-04-04 15:44 ` Kumar Amit Mehta
2014-04-04 21:29 ` Dan Carpenter
2014-04-04 21:29 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.