From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: Intel I350 mini-PCIe card (igb) on Mirabox (mvebu / Armada 370)
Date: Tue, 8 Apr 2014 17:13:09 +0200 [thread overview]
Message-ID: <20140408171309.09bbf968@skate> (raw)
In-Reply-To: <alpine.DEB.2.10.1404061631130.4683@vroombuntu>
Hello all,
On Sun, 6 Apr 2014 16:34:08 +0100 (BST), Neil Greatorex wrote:
> From e5698a4ae6b21c7e78538e16d293123903abbb40 Mon Sep 17 00:00:00 2001
> From: Neil Greatorex <neil@fatboyfat.co.uk>
> Date: Sun, 6 Apr 2014 16:10:43 +0100
> Subject: [PATCH] irqchip: armada-370-xp: Fix releasing of MSIs
>
> Store the value of d->hwirq in a local variable as the real value is wiped out
> by calling irq_dispose_mapping. Without this patch, the armada_370_xp_free_msi
> function would always free MSI#0, no matter what was passed to it.
>
> Signed-off-by: Neil Greatorex <neil@fatboyfat.co.uk>
> ---
> drivers/irqchip/irq-armada-370-xp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
> index 5409564..916fae2 100644
> --- a/drivers/irqchip/irq-armada-370-xp.c
> +++ b/drivers/irqchip/irq-armada-370-xp.c
> @@ -157,8 +157,10 @@ static void armada_370_xp_teardown_msi_irq(struct msi_chip *chip,
> unsigned int irq)
> {
> struct irq_data *d = irq_get_irq_data(irq);
> + unsigned long hwirq = d->hwirq;
> +
> irq_dispose_mapping(irq);
> - armada_370_xp_free_msi(d->hwirq);
> + armada_370_xp_free_msi(hwirq);
> }
>
> static struct irq_chip armada_370_xp_msi_irq_chip = {
Unfortunately here your patch is not sufficient to solve the problem
apparently. I've fixed another problem where the return value of
armada_370_xp_alloc_msi() (which is signed) is casted into an unsigned
irq_hw_number_t in armada_370_xp_setup_msi_irq(), but I'm still seeing
many MSIs allocated, then some freed, and finally a kernel panic.
* Log: https://gist.github.com/tpetazzoni/10140012
* Diff against v3.14: https://gist.github.com/tpetazzoni/10140121
Ideas? If some of you are interested in discussing this live, I'm on
#mvlinux on Freenode.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-08 15:13 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 20:07 Intel I350 mini-PCIe card (igb) on Mirabox (mvebu / Armada 370) Neil Greatorex
2014-03-25 20:20 ` Thomas Petazzoni
2014-03-25 21:03 ` Willy Tarreau
2014-03-25 20:22 ` Jason Gunthorpe
2014-03-25 20:36 ` Thomas Petazzoni
2014-03-25 21:12 ` Jason Gunthorpe
2014-03-25 21:23 ` Thomas Petazzoni
2014-03-25 22:03 ` Neil Greatorex
2014-03-25 22:24 ` Jason Gunthorpe
2014-03-25 22:35 ` Jason Gunthorpe
2014-03-26 19:31 ` Neil Greatorex
2014-03-26 20:12 ` Jason Gunthorpe
2014-03-26 20:34 ` Neil Greatorex
2014-03-26 21:42 ` Jason Gunthorpe
2014-03-26 21:52 ` Thomas Petazzoni
2014-03-27 0:29 ` Neil Greatorex
2014-03-27 4:40 ` Jason Gunthorpe
2014-03-28 1:03 ` Neil Greatorex
2014-03-28 2:04 ` Jason Gunthorpe
2014-04-04 13:19 ` Neil Greatorex
2014-04-05 17:32 ` Willy Tarreau
2014-04-05 17:34 ` Thomas Petazzoni
2014-04-05 18:04 ` Willy Tarreau
2014-04-05 18:55 ` Neil Greatorex
2014-04-05 19:03 ` Willy Tarreau
2014-04-05 19:00 ` Neil Greatorex
2014-04-06 15:34 ` Neil Greatorex
2014-04-06 17:43 ` Willy Tarreau
2014-04-08 15:13 ` Thomas Petazzoni [this message]
2014-04-08 15:40 ` Thomas Petazzoni
2014-04-08 15:55 ` Thomas Petazzoni
2014-04-08 16:02 ` Matthew Minter
2014-04-08 17:14 ` Jason Gunthorpe
2014-04-08 17:53 ` Willy Tarreau
2014-04-08 18:08 ` Jason Gunthorpe
2014-04-08 18:15 ` Thomas Petazzoni
2014-04-08 18:40 ` Jason Gunthorpe
2014-04-08 19:15 ` Willy Tarreau
2014-04-08 19:21 ` Jason Gunthorpe
2014-04-08 20:17 ` Matthew Minter
2014-04-08 21:50 ` Thomas Petazzoni
2014-04-08 20:19 ` Neil Greatorex
2014-04-08 20:43 ` Willy Tarreau
2014-04-08 18:01 ` Thomas Petazzoni
2014-04-08 18:22 ` Jason Gunthorpe
2014-04-08 18:32 ` Thomas Petazzoni
2014-04-08 15:53 ` Willy Tarreau
2014-04-08 16:00 ` Thomas Petazzoni
2014-04-08 16:05 ` Willy Tarreau
2014-04-06 18:58 ` Willy Tarreau
2014-04-06 19:11 ` Thomas Petazzoni
2014-04-06 21:57 ` Neil Greatorex
2014-04-06 22:04 ` Willy Tarreau
2014-04-06 22:16 ` Thomas Petazzoni
2014-04-07 0:50 ` Neil Greatorex
2014-04-07 17:41 ` Jason Gunthorpe
2014-04-07 19:41 ` Neil Greatorex
2014-04-07 20:48 ` Jason Gunthorpe
2014-04-07 21:58 ` Neil Greatorex
2014-04-08 6:28 ` Willy Tarreau
2014-04-08 6:40 ` Willy Tarreau
2014-04-08 10:53 ` Matthew Minter
2014-04-08 12:31 ` Matthew Minter
2014-04-08 12:36 ` Willy Tarreau
2014-04-08 14:43 ` Thomas Petazzoni
2014-04-08 14:52 ` Matthew Minter
2014-04-08 14:53 ` Willy Tarreau
2014-04-08 15:25 ` Thomas Petazzoni
2014-04-08 17:56 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408171309.09bbf968@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.