All of lore.kernel.org
 help / color / mirror / Atom feed
* KVM: x86: remove WARN_ON from get_kernel_ns()
@ 2014-04-10 21:19 Marcelo Tosatti
  2014-04-12  0:06 ` Paolo Bonzini
  0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Tosatti @ 2014-04-10 21:19 UTC (permalink / raw)
  To: kvm-devel


Function and callers can be preempted.

https://bugzilla.kernel.org/show_bug.cgi?id=73721

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 2b85784..ee0c3b5 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1109,7 +1109,6 @@ static inline u64 get_kernel_ns(void)
 {
 	struct timespec ts;
 
-	WARN_ON(preemptible());
 	ktime_get_ts(&ts);
 	monotonic_to_bootbased(&ts);
 	return timespec_to_ns(&ts);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: KVM: x86: remove WARN_ON from get_kernel_ns()
  2014-04-10 21:19 KVM: x86: remove WARN_ON from get_kernel_ns() Marcelo Tosatti
@ 2014-04-12  0:06 ` Paolo Bonzini
  0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2014-04-12  0:06 UTC (permalink / raw)
  To: Marcelo Tosatti, kvm-devel

Il 10/04/2014 17:19, Marcelo Tosatti ha scritto:
>
> Function and callers can be preempted.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=73721
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 2b85784..ee0c3b5 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1109,7 +1109,6 @@ static inline u64 get_kernel_ns(void)
>  {
>  	struct timespec ts;
>
> -	WARN_ON(preemptible());
>  	ktime_get_ts(&ts);
>  	monotonic_to_bootbased(&ts);
>  	return timespec_to_ns(&ts);
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-12  0:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-10 21:19 KVM: x86: remove WARN_ON from get_kernel_ns() Marcelo Tosatti
2014-04-12  0:06 ` Paolo Bonzini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.