* [PATCH] tests/kms_flip_tiling: Fixes
@ 2014-04-11 14:17 Daniel Vetter
2014-04-11 14:28 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Vetter @ 2014-04-11 14:17 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter, Ander Conselvan de Oliveira
- Wrap up testcase correctly into the magic code block.
- Put local variables out of the longjmp danger zone.
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
tests/kms_flip_tiling.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
index e70609d52e78..ca20ad96bc35 100644
--- a/tests/kms_flip_tiling.c
+++ b/tests/kms_flip_tiling.c
@@ -119,11 +119,10 @@ test_flip_changes_tiling(data_t *data, igt_output_t *output)
}
static data_t data;
+igt_output_t *output;
igt_main
{
- igt_output_t *output;
-
igt_skip_on_simulation();
igt_fixture {
@@ -135,10 +134,10 @@ igt_main
igt_display_init(&data.display, data.drm_fd);
}
- igt_subtest_f("flip-changes-tiling");
-
- for_each_connected_output(&data.display, output)
- test_flip_changes_tiling(&data, output);
+ igt_subtest_f("flip-changes-tiling") {
+ for_each_connected_output(&data.display, output)
+ test_flip_changes_tiling(&data, output);
+ }
igt_fixture {
igt_display_fini(&data.display);
--
1.8.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests/kms_flip_tiling: Fixes
2014-04-11 14:17 [PATCH] tests/kms_flip_tiling: Fixes Daniel Vetter
@ 2014-04-11 14:28 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2014-04-11 14:28 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter, Ander Conselvan de Oliveira
On Fri, Apr 11, 2014 at 04:17:48PM +0200, Daniel Vetter wrote:
> - Wrap up testcase correctly into the magic code block.
> - Put local variables out of the longjmp danger zone.
>
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Ander, quick one for process: Please submit igt patches to the mailing
list so that they don't get lost in bugzilla.
And thanks a lot for the testcase.
-Daniel
> ---
> tests/kms_flip_tiling.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
> index e70609d52e78..ca20ad96bc35 100644
> --- a/tests/kms_flip_tiling.c
> +++ b/tests/kms_flip_tiling.c
> @@ -119,11 +119,10 @@ test_flip_changes_tiling(data_t *data, igt_output_t *output)
> }
>
> static data_t data;
> +igt_output_t *output;
>
> igt_main
> {
> - igt_output_t *output;
> -
> igt_skip_on_simulation();
>
> igt_fixture {
> @@ -135,10 +134,10 @@ igt_main
> igt_display_init(&data.display, data.drm_fd);
> }
>
> - igt_subtest_f("flip-changes-tiling");
> -
> - for_each_connected_output(&data.display, output)
> - test_flip_changes_tiling(&data, output);
> + igt_subtest_f("flip-changes-tiling") {
> + for_each_connected_output(&data.display, output)
> + test_flip_changes_tiling(&data, output);
> + }
>
> igt_fixture {
> igt_display_fini(&data.display);
> --
> 1.8.5.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-11 14:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-11 14:17 [PATCH] tests/kms_flip_tiling: Fixes Daniel Vetter
2014-04-11 14:28 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.