* Re: ftrace: reading set_graph_notrace returns "#### all functions enabled ####"
[not found] <1397240657-bbzt0eax@n-horiguchi@ah.jp.nec.com>
@ 2014-04-11 18:55 ` Steven Rostedt
0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2014-04-11 18:55 UTC (permalink / raw)
To: Naoya Horiguchi; +Cc: namhyung.kim, linux-kernel
On Fri, 11 Apr 2014 14:24:17 -0400
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
> Hi,
>
> I report a minor issue of set_graph_notrace.
> The default value of set_graph_notrace is void (so no function is excluded,)
> but when we read the file, we get "#### all functions enabled ####" like below:
>
> [root@test tracing]# echo "" > set_graph_notrace
> [root@test tracing]# cat set_graph_notrace
> #### all functions enabled ####
>
> This does not happen for set_ftrace_notrace:
>
> [root@test tracing]# echo "" > set_ftrace_notrace
> [root@test tracing]# cat set_ftrace_notrace
> [root@test tracing]#
>
> This is not critical but confusing, so it would be nice if fixed.
Ah, I would say they both are wrong. The set_graph_notrace is rather
new, and probably copied and pasted incorrectly.
But having nothing printed may not be the best thing to show. I think
both should be switched to
#### no functions disabled ####
But this can be done in my 3.16 queue.
Thanks for the report,
-- Steve
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-04-11 18:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1397240657-bbzt0eax@n-horiguchi@ah.jp.nec.com>
2014-04-11 18:55 ` ftrace: reading set_graph_notrace returns "#### all functions enabled ####" Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.