* [PATCH] xen/pci: Remove unused dev_err() string
@ 2014-04-14 22:25 Bjorn Helgaas
0 siblings, 0 replies; 8+ messages in thread
From: Bjorn Helgaas @ 2014-04-14 22:25 UTC (permalink / raw)
To: Boris Ostrovsky, David Vrabel, Konrad Rzeszutek Wilk
Cc: xen-devel, linux-kernel
We previously verified that "action" is either BUS_NOTIFY_ADD_DEVICE or
BUS_NOTIFY_DEL_DEVICE, so there's no need for the default "?" case.
Found by Coverity (CID 146520).
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/xen/pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
index dd9c249ea311..59a25f937bd7 100644
--- a/drivers/xen/pci.c
+++ b/drivers/xen/pci.c
@@ -177,8 +177,7 @@ static int xen_pci_notifier(struct notifier_block *nb,
}
if (r)
dev_err(dev, "Failed to %s - passthrough or MSI/MSI-X might fail!\n",
- action == BUS_NOTIFY_ADD_DEVICE ? "add" :
- (action == BUS_NOTIFY_DEL_DEVICE ? "delete" : "?"));
+ action == BUS_NOTIFY_ADD_DEVICE ? "add" : "del");
return NOTIFY_OK;
}
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] xen/pci: Remove unused dev_err() string
@ 2014-04-14 22:25 Bjorn Helgaas
2014-04-15 13:03 ` Konrad Rzeszutek Wilk
2014-04-15 13:03 ` Konrad Rzeszutek Wilk
0 siblings, 2 replies; 8+ messages in thread
From: Bjorn Helgaas @ 2014-04-14 22:25 UTC (permalink / raw)
To: Boris Ostrovsky, David Vrabel, Konrad Rzeszutek Wilk
Cc: xen-devel, linux-kernel
We previously verified that "action" is either BUS_NOTIFY_ADD_DEVICE or
BUS_NOTIFY_DEL_DEVICE, so there's no need for the default "?" case.
Found by Coverity (CID 146520).
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/xen/pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
index dd9c249ea311..59a25f937bd7 100644
--- a/drivers/xen/pci.c
+++ b/drivers/xen/pci.c
@@ -177,8 +177,7 @@ static int xen_pci_notifier(struct notifier_block *nb,
}
if (r)
dev_err(dev, "Failed to %s - passthrough or MSI/MSI-X might fail!\n",
- action == BUS_NOTIFY_ADD_DEVICE ? "add" :
- (action == BUS_NOTIFY_DEL_DEVICE ? "delete" : "?"));
+ action == BUS_NOTIFY_ADD_DEVICE ? "add" : "del");
return NOTIFY_OK;
}
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/pci: Remove unused dev_err() string
2014-04-14 22:25 Bjorn Helgaas
@ 2014-04-15 13:03 ` Konrad Rzeszutek Wilk
2014-04-15 13:29 ` David Vrabel
2014-04-15 13:29 ` David Vrabel
2014-04-15 13:03 ` Konrad Rzeszutek Wilk
1 sibling, 2 replies; 8+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-04-15 13:03 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Boris Ostrovsky, David Vrabel, xen-devel, linux-kernel
On Mon, Apr 14, 2014 at 04:25:23PM -0600, Bjorn Helgaas wrote:
> We previously verified that "action" is either BUS_NOTIFY_ADD_DEVICE or
> BUS_NOTIFY_DEL_DEVICE, so there's no need for the default "?" case.
>
> Found by Coverity (CID 146520).
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
David, are you OK pushing this in 'devel/for-linus-3.14'?
Thanks!
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/xen/pci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
> index dd9c249ea311..59a25f937bd7 100644
> --- a/drivers/xen/pci.c
> +++ b/drivers/xen/pci.c
> @@ -177,8 +177,7 @@ static int xen_pci_notifier(struct notifier_block *nb,
> }
> if (r)
> dev_err(dev, "Failed to %s - passthrough or MSI/MSI-X might fail!\n",
> - action == BUS_NOTIFY_ADD_DEVICE ? "add" :
> - (action == BUS_NOTIFY_DEL_DEVICE ? "delete" : "?"));
> + action == BUS_NOTIFY_ADD_DEVICE ? "add" : "del");
> return NOTIFY_OK;
> }
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/pci: Remove unused dev_err() string
2014-04-15 13:03 ` Konrad Rzeszutek Wilk
@ 2014-04-15 13:29 ` David Vrabel
2014-04-15 13:29 ` David Vrabel
1 sibling, 0 replies; 8+ messages in thread
From: David Vrabel @ 2014-04-15 13:29 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Bjorn Helgaas, xen-devel, Boris Ostrovsky, linux-kernel
On 15/04/14 14:03, Konrad Rzeszutek Wilk wrote:
> On Mon, Apr 14, 2014 at 04:25:23PM -0600, Bjorn Helgaas wrote:
>> We previously verified that "action" is either BUS_NOTIFY_ADD_DEVICE or
>> BUS_NOTIFY_DEL_DEVICE, so there's no need for the default "?" case.
>>
>> Found by Coverity (CID 146520).
>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> David, are you OK pushing this in 'devel/for-linus-3.14'?
If you mean devel/for-linus-3.16, then yes.
David
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/pci: Remove unused dev_err() string
2014-04-15 13:03 ` Konrad Rzeszutek Wilk
2014-04-15 13:29 ` David Vrabel
@ 2014-04-15 13:29 ` David Vrabel
2014-04-15 15:20 ` Konrad Rzeszutek Wilk
2014-04-15 15:20 ` Konrad Rzeszutek Wilk
1 sibling, 2 replies; 8+ messages in thread
From: David Vrabel @ 2014-04-15 13:29 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Bjorn Helgaas, Boris Ostrovsky, xen-devel, linux-kernel
On 15/04/14 14:03, Konrad Rzeszutek Wilk wrote:
> On Mon, Apr 14, 2014 at 04:25:23PM -0600, Bjorn Helgaas wrote:
>> We previously verified that "action" is either BUS_NOTIFY_ADD_DEVICE or
>> BUS_NOTIFY_DEL_DEVICE, so there's no need for the default "?" case.
>>
>> Found by Coverity (CID 146520).
>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> David, are you OK pushing this in 'devel/for-linus-3.14'?
If you mean devel/for-linus-3.16, then yes.
David
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/pci: Remove unused dev_err() string
2014-04-15 13:29 ` David Vrabel
@ 2014-04-15 15:20 ` Konrad Rzeszutek Wilk
2014-04-15 15:20 ` Konrad Rzeszutek Wilk
1 sibling, 0 replies; 8+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-04-15 15:20 UTC (permalink / raw)
To: David Vrabel; +Cc: Bjorn Helgaas, xen-devel, Boris Ostrovsky, linux-kernel
On Tue, Apr 15, 2014 at 02:29:16PM +0100, David Vrabel wrote:
> On 15/04/14 14:03, Konrad Rzeszutek Wilk wrote:
> > On Mon, Apr 14, 2014 at 04:25:23PM -0600, Bjorn Helgaas wrote:
> >> We previously verified that "action" is either BUS_NOTIFY_ADD_DEVICE or
> >> BUS_NOTIFY_DEL_DEVICE, so there's no need for the default "?" case.
> >>
> >> Found by Coverity (CID 146520).
> >
> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >
> > David, are you OK pushing this in 'devel/for-linus-3.14'?
>
> If you mean devel/for-linus-3.16, then yes.
Yes I meant that. Thanks!
>
> David
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/pci: Remove unused dev_err() string
2014-04-15 13:29 ` David Vrabel
2014-04-15 15:20 ` Konrad Rzeszutek Wilk
@ 2014-04-15 15:20 ` Konrad Rzeszutek Wilk
1 sibling, 0 replies; 8+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-04-15 15:20 UTC (permalink / raw)
To: David Vrabel; +Cc: Bjorn Helgaas, Boris Ostrovsky, xen-devel, linux-kernel
On Tue, Apr 15, 2014 at 02:29:16PM +0100, David Vrabel wrote:
> On 15/04/14 14:03, Konrad Rzeszutek Wilk wrote:
> > On Mon, Apr 14, 2014 at 04:25:23PM -0600, Bjorn Helgaas wrote:
> >> We previously verified that "action" is either BUS_NOTIFY_ADD_DEVICE or
> >> BUS_NOTIFY_DEL_DEVICE, so there's no need for the default "?" case.
> >>
> >> Found by Coverity (CID 146520).
> >
> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >
> > David, are you OK pushing this in 'devel/for-linus-3.14'?
>
> If you mean devel/for-linus-3.16, then yes.
Yes I meant that. Thanks!
>
> David
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/pci: Remove unused dev_err() string
2014-04-14 22:25 Bjorn Helgaas
2014-04-15 13:03 ` Konrad Rzeszutek Wilk
@ 2014-04-15 13:03 ` Konrad Rzeszutek Wilk
1 sibling, 0 replies; 8+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-04-15 13:03 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: xen-devel, Boris Ostrovsky, David Vrabel, linux-kernel
On Mon, Apr 14, 2014 at 04:25:23PM -0600, Bjorn Helgaas wrote:
> We previously verified that "action" is either BUS_NOTIFY_ADD_DEVICE or
> BUS_NOTIFY_DEL_DEVICE, so there's no need for the default "?" case.
>
> Found by Coverity (CID 146520).
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
David, are you OK pushing this in 'devel/for-linus-3.14'?
Thanks!
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/xen/pci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
> index dd9c249ea311..59a25f937bd7 100644
> --- a/drivers/xen/pci.c
> +++ b/drivers/xen/pci.c
> @@ -177,8 +177,7 @@ static int xen_pci_notifier(struct notifier_block *nb,
> }
> if (r)
> dev_err(dev, "Failed to %s - passthrough or MSI/MSI-X might fail!\n",
> - action == BUS_NOTIFY_ADD_DEVICE ? "add" :
> - (action == BUS_NOTIFY_DEL_DEVICE ? "delete" : "?"));
> + action == BUS_NOTIFY_ADD_DEVICE ? "add" : "del");
> return NOTIFY_OK;
> }
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-04-15 15:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-14 22:25 [PATCH] xen/pci: Remove unused dev_err() string Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2014-04-14 22:25 Bjorn Helgaas
2014-04-15 13:03 ` Konrad Rzeszutek Wilk
2014-04-15 13:29 ` David Vrabel
2014-04-15 13:29 ` David Vrabel
2014-04-15 15:20 ` Konrad Rzeszutek Wilk
2014-04-15 15:20 ` Konrad Rzeszutek Wilk
2014-04-15 13:03 ` Konrad Rzeszutek Wilk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.