From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Alexander Stein <alexanders83@web.de>
Cc: Takashi Iwai <tiwai@suse.de>, Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Randy Dunlap <rdunlap@infradead.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Jaroslav Kysela <perex@perex.cz>,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Andrew Victor <linux@maxim.org.za>,
linux-arm-kernel@lists.infradead.org
Subject: Re: Re: Device tree support for Atmel AC97 controller on AT91SAM9263
Date: Tue, 15 Apr 2014 00:47:11 +0200 [thread overview]
Message-ID: <20140414224710.GX2967@piout.net> (raw)
In-Reply-To: <2216396.r6UFNn5RuG@kongar>
On 14/04/2014 at 20:43:02 +0200, Alexander Stein wrote :
> Hello Takashi,
>
> On Monday 14 April 2014, 10:42:06 wrote Takashi Iwai:
> > At Sat, 12 Apr 2014 11:08:23 +0200,
> > Alexander Stein wrote:
> > >
> > > This set of patches add device tree support for the AC97 controller found
> > > on AT91SAM9263.
> > > The first two patches are minor cleanup, while the last ones add the
> actual
> > > support.
> >
> > Do you really need work on this driver? The sound/atmel/* stuff is an
> > old one before ASoC was introduced, mostly obsoleted nowadays.
>
> Ah, ok. I wasn't aware of that. But is there a replacement for the ac97c
> driver? All I found in sound/soc/atmel is using the SSC peripheral. Not
> something I can use.
I guess what Takashi wanted to say was: shouldn't we rewrite the driver
completely to take advantage of the ASoC infrastructure ?
I'm actually quite interesting in getting it to work as this is the la
peripheral that doesn't have DT support on the SAM9RL.
I'll make some comments on your patches but I'm not sure whether we
should keep that driver or move to ASoC. Maybe that could be an
intermediate step. I'll try to have a look this week.
Thank you for your work !
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: Device tree support for Atmel AC97 controller on AT91SAM9263
Date: Tue, 15 Apr 2014 00:47:11 +0200 [thread overview]
Message-ID: <20140414224710.GX2967@piout.net> (raw)
In-Reply-To: <2216396.r6UFNn5RuG@kongar>
On 14/04/2014 at 20:43:02 +0200, Alexander Stein wrote :
> Hello Takashi,
>
> On Monday 14 April 2014, 10:42:06 wrote Takashi Iwai:
> > At Sat, 12 Apr 2014 11:08:23 +0200,
> > Alexander Stein wrote:
> > >
> > > This set of patches add device tree support for the AC97 controller found
> > > on AT91SAM9263.
> > > The first two patches are minor cleanup, while the last ones add the
> actual
> > > support.
> >
> > Do you really need work on this driver? The sound/atmel/* stuff is an
> > old one before ASoC was introduced, mostly obsoleted nowadays.
>
> Ah, ok. I wasn't aware of that. But is there a replacement for the ac97c
> driver? All I found in sound/soc/atmel is using the SSC peripheral. Not
> something I can use.
I guess what Takashi wanted to say was: shouldn't we rewrite the driver
completely to take advantage of the ASoC infrastructure ?
I'm actually quite interesting in getting it to work as this is the la
peripheral that doesn't have DT support on the SAM9RL.
I'll make some comments on your patches but I'm not sure whether we
should keep that driver or move to ASoC. Maybe that could be an
intermediate step. I'll try to have a look this week.
Thank you for your work !
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-14 22:47 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 9:08 Device tree support for Atmel AC97 controller on AT91SAM9263 Alexander Stein
2014-04-12 9:08 ` Alexander Stein
2014-04-12 9:08 ` [PATCH 1/4] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver Alexander Stein
2014-04-12 9:08 ` Alexander Stein
2014-04-14 22:48 ` Alexandre Belloni
2014-04-14 22:48 ` Alexandre Belloni
2014-04-12 9:08 ` [PATCH 2/4] ALSA: sound/atmel-ac97c.h: Remove unused flags from platform data Alexander Stein
2014-04-12 9:08 ` Alexander Stein
2014-04-14 22:51 ` Alexandre Belloni
2014-04-14 22:51 ` Alexandre Belloni
2014-04-12 9:08 ` [PATCH 3/4] ALSA: sound/atmel/ac97c.c: Add device tree support Alexander Stein
2014-04-12 9:08 ` Alexander Stein
[not found] ` <1397293707-26890-4-git-send-email-alexanders83-S0/GAf8tV78@public.gmane.org>
2014-04-12 10:31 ` Alexander Shiyan
2014-04-12 10:31 ` Alexander Shiyan
2014-04-12 10:31 ` Alexander Shiyan
2014-04-12 10:42 ` Alexander Stein
2014-04-12 10:42 ` Alexander Stein
2014-04-12 10:48 ` Alexander Shiyan
2014-04-12 10:48 ` Alexander Shiyan
2014-04-13 8:32 ` Alexander Stein
2014-04-13 8:32 ` Alexander Stein
2014-04-14 23:21 ` Alexandre Belloni
2014-04-14 23:21 ` Alexandre Belloni
2014-04-15 19:17 ` Re: " Alexander Stein
2014-04-15 19:17 ` Alexander Stein
2014-04-12 10:31 ` Alexander Shiyan
2014-04-14 23:07 ` Alexandre Belloni
2014-04-14 23:07 ` Alexandre Belloni
2014-04-12 9:08 ` [PATCH 4/4] ARM: at91/dt: sam9263: Add ac97 device node Alexander Stein
2014-04-12 9:08 ` Alexander Stein
2014-04-14 8:39 ` Device tree support for Atmel AC97 controller on AT91SAM9263 Bo Shen
2014-04-14 8:39 ` Bo Shen
2014-04-14 18:34 ` Alexander Stein
2014-04-14 18:34 ` Alexander Stein
2014-04-14 8:42 ` Takashi Iwai
2014-04-14 8:42 ` Takashi Iwai
2014-04-14 18:43 ` Alexander Stein
2014-04-14 18:43 ` Alexander Stein
2014-04-14 22:47 ` Alexandre Belloni [this message]
2014-04-14 22:47 ` Alexandre Belloni
2014-04-15 5:59 ` Takashi Iwai
2014-04-15 5:59 ` Takashi Iwai
2014-04-15 17:38 ` [PATCH v2 1/2] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver Alexander Stein
2014-04-15 17:38 ` [PATCH v2 2/2] ALSA: sound/atmel-ac97c.h: Remove unused flags from platform data Alexander Stein
2014-04-16 7:39 ` Nicolas Ferre
2014-04-16 7:39 ` [PATCH v2 1/2] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver Nicolas Ferre
2014-04-16 8:23 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414224710.GX2967@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=alexanders83@web.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=plagnioj@jcrosoft.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.