All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ahci: imx: use macros to define registers and bits
Date: Tue, 15 Apr 2014 12:03:17 -0400	[thread overview]
Message-ID: <20140415160317.GM1863@htj.dyndns.org> (raw)
In-Reply-To: <1397529703-21165-1-git-send-email-shawn.guo@freescale.com>

On Tue, Apr 15, 2014 at 10:41:42AM +0800, Shawn Guo wrote:
> Comparing to enums, macros are more conventional to be used for
> registers and bits definition.  Let's switch to macros.
> 
> While at it, the names of the registers and bit-fields are updated to
> have proper namespace prefix and match the hardware reference manual.
> 
> No functional change is involved.
> 
> Signed-off-by: Shawn Guo <shawn.guo@freescale.com>

Please don't switch to defines.  A lot of libata constants use enums
and they tend to have more advantages anyway.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: tj@kernel.org (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ahci: imx: use macros to define registers and bits
Date: Tue, 15 Apr 2014 12:03:17 -0400	[thread overview]
Message-ID: <20140415160317.GM1863@htj.dyndns.org> (raw)
In-Reply-To: <1397529703-21165-1-git-send-email-shawn.guo@freescale.com>

On Tue, Apr 15, 2014 at 10:41:42AM +0800, Shawn Guo wrote:
> Comparing to enums, macros are more conventional to be used for
> registers and bits definition.  Let's switch to macros.
> 
> While at it, the names of the registers and bit-fields are updated to
> have proper namespace prefix and match the hardware reference manual.
> 
> No functional change is involved.
> 
> Signed-off-by: Shawn Guo <shawn.guo@freescale.com>

Please don't switch to defines.  A lot of libata constants use enums
and they tend to have more advantages anyway.

Thanks.

-- 
tejun

  parent reply	other threads:[~2014-04-15 16:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15  2:41 [PATCH 1/2] ahci: imx: use macros to define registers and bits Shawn Guo
2014-04-15  2:41 ` Shawn Guo
2014-04-15  2:41 ` [PATCH 2/2] ahci: imx: software workaround for phy reset issue in resume Shawn Guo
2014-04-15  2:41   ` Shawn Guo
2014-04-15  3:19   ` Fabio Estevam
2014-04-15  3:19     ` Fabio Estevam
2014-04-15 16:10   ` Tejun Heo
2014-04-15 16:10     ` Tejun Heo
2014-04-16  7:38     ` Shawn Guo
2014-04-16  7:38       ` Shawn Guo
2014-04-16 14:01       ` Tejun Heo
2014-04-16 14:01         ` Tejun Heo
2014-04-17  2:05         ` Shawn Guo
2014-04-17  2:05           ` Shawn Guo
2014-04-15 16:03 ` Tejun Heo [this message]
2014-04-15 16:03   ` [PATCH 1/2] ahci: imx: use macros to define registers and bits Tejun Heo
2014-04-16  6:35   ` Shawn Guo
2014-04-16  6:35     ` Shawn Guo
2014-04-16 13:57     ` Tejun Heo
2014-04-16 13:57       ` Tejun Heo
2014-04-16  7:59 ` Uwe Kleine-König
2014-04-16  7:59   ` Uwe Kleine-König
2014-04-16  8:08   ` Shawn Guo
2014-04-16  8:08     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140415160317.GM1863@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=shawn.guo@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.