* [PATCH] drm/i915/SDVO: For sysfs link put directory and target in correct order
@ 2014-04-11 17:07 Egbert Eich
2014-04-11 17:26 ` Imre Deak
0 siblings, 1 reply; 4+ messages in thread
From: Egbert Eich @ 2014-04-11 17:07 UTC (permalink / raw)
To: intel-gfx; +Cc: Egbert Eich
When linking the i2c sysfs file into the connector's directory
pass directory and link target in the right order.
This code was introduced with:
commit 931c1c26983b4f84e33b78579fc8d57e4a14c6b4
Author: Imre Deak <imre.deak@intel.com>
Date: Tue Feb 11 17:12:51 2014 +0200
drm/i915: sdvo: add i2c sysfs symlink to the connector's directory
This is the same what we do for DP connectors, so make things more
consistent.
Signed-off-by: Egbert Eich <eich@suse.de>
---
drivers/gpu/drm/i915/intel_sdvo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
index 5043f16..2d4d461 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -2428,8 +2428,8 @@ intel_sdvo_connector_init(struct intel_sdvo_connector *connector,
if (ret < 0)
goto err1;
- ret = sysfs_create_link(&encoder->ddc.dev.kobj,
- &drm_connector->kdev->kobj,
+ ret = sysfs_create_link(&drm_connector->kdev->kobj,
+ &encoder->ddc.dev.kobj,
encoder->ddc.dev.kobj.name);
if (ret < 0)
goto err2;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/SDVO: For sysfs link put directory and target in correct order
2014-04-11 17:07 [PATCH] drm/i915/SDVO: For sysfs link put directory and target in correct order Egbert Eich
@ 2014-04-11 17:26 ` Imre Deak
2014-04-15 19:03 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Imre Deak @ 2014-04-11 17:26 UTC (permalink / raw)
To: Egbert Eich; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 1370 bytes --]
On Fri, 2014-04-11 at 19:07 +0200, Egbert Eich wrote:
> When linking the i2c sysfs file into the connector's directory
> pass directory and link target in the right order.
> This code was introduced with:
>
> commit 931c1c26983b4f84e33b78579fc8d57e4a14c6b4
> Author: Imre Deak <imre.deak@intel.com>
> Date: Tue Feb 11 17:12:51 2014 +0200
>
> drm/i915: sdvo: add i2c sysfs symlink to the connector's directory
>
> This is the same what we do for DP connectors, so make things more
> consistent.
>
> Signed-off-by: Egbert Eich <eich@suse.de>
Oops, good catch. The fix looks ok, fwiw:
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_sdvo.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
> index 5043f16..2d4d461 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -2428,8 +2428,8 @@ intel_sdvo_connector_init(struct intel_sdvo_connector *connector,
> if (ret < 0)
> goto err1;
>
> - ret = sysfs_create_link(&encoder->ddc.dev.kobj,
> - &drm_connector->kdev->kobj,
> + ret = sysfs_create_link(&drm_connector->kdev->kobj,
> + &encoder->ddc.dev.kobj,
> encoder->ddc.dev.kobj.name);
> if (ret < 0)
> goto err2;
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/SDVO: For sysfs link put directory and target in correct order
2014-04-11 17:26 ` Imre Deak
@ 2014-04-15 19:03 ` Daniel Vetter
2014-05-07 6:57 ` Jani Nikula
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2014-04-15 19:03 UTC (permalink / raw)
To: Imre Deak; +Cc: Egbert Eich, intel-gfx
On Fri, Apr 11, 2014 at 08:26:25PM +0300, Imre Deak wrote:
> On Fri, 2014-04-11 at 19:07 +0200, Egbert Eich wrote:
> > When linking the i2c sysfs file into the connector's directory
> > pass directory and link target in the right order.
> > This code was introduced with:
> >
> > commit 931c1c26983b4f84e33b78579fc8d57e4a14c6b4
> > Author: Imre Deak <imre.deak@intel.com>
> > Date: Tue Feb 11 17:12:51 2014 +0200
> >
> > drm/i915: sdvo: add i2c sysfs symlink to the connector's directory
> >
> > This is the same what we do for DP connectors, so make things more
> > consistent.
> >
> > Signed-off-by: Egbert Eich <eich@suse.de>
>
> Oops, good catch. The fix looks ok, fwiw:
> Reviewed-by: Imre Deak <imre.deak@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/SDVO: For sysfs link put directory and target in correct order
2014-04-15 19:03 ` Daniel Vetter
@ 2014-05-07 6:57 ` Jani Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2014-05-07 6:57 UTC (permalink / raw)
To: Daniel Vetter, Imre Deak; +Cc: Egbert Eich, intel-gfx
On Tue, 15 Apr 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Apr 11, 2014 at 08:26:25PM +0300, Imre Deak wrote:
>> On Fri, 2014-04-11 at 19:07 +0200, Egbert Eich wrote:
>> > When linking the i2c sysfs file into the connector's directory
>> > pass directory and link target in the right order.
>> > This code was introduced with:
>> >
>> > commit 931c1c26983b4f84e33b78579fc8d57e4a14c6b4
>> > Author: Imre Deak <imre.deak@intel.com>
>> > Date: Tue Feb 11 17:12:51 2014 +0200
>> >
>> > drm/i915: sdvo: add i2c sysfs symlink to the connector's directory
>> >
>> > This is the same what we do for DP connectors, so make things more
>> > consistent.
>> >
>> > Signed-off-by: Egbert Eich <eich@suse.de>
>>
>> Oops, good catch. The fix looks ok, fwiw:
>> Reviewed-by: Imre Deak <imre.deak@intel.com>
>
> Queued for -next, thanks for the patch.
And picked up for -fixes and queuing for 3.15.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-07 6:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-11 17:07 [PATCH] drm/i915/SDVO: For sysfs link put directory and target in correct order Egbert Eich
2014-04-11 17:26 ` Imre Deak
2014-04-15 19:03 ` Daniel Vetter
2014-05-07 6:57 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.