[PATCH] tools/hciattach: Fix missing includes

[PATCH] tools/hciattach: Fix missing includes

[Szymon Janc]

According to writev manual one should include <sys/uio.h> to use it.

This fix following warnings with bionic:
external/bluetooth/bluez/tools/hciattach_tialt.c: In function
    'texas_load_firmware':
external/bluetooth/bluez/tools/hciattach_tialt.c:142:4: warning:
    implicit declaration of function 'writev'
    [-Wimplicit-function-declaration]
target thumb C: hciattach <= external/bluetooth/bluez/tools/
    hciattach_ath3k.c
target thumb C: hciattach <= external/bluetooth/bluez/tools/
    hciattach_qualcomm.c
external/bluetooth/bluez/tools/hciattach_qualcomm.c: In function
    'qualcomm_load_firmware':
external/bluetooth/bluez/tools/hciattach_qualcomm.c:147:4: warning:
    implicit declaration of function 'writev'
    [-Wimplicit-function-declaration]
---
 tools/hciattach_qualcomm.c | 1 +
 tools/hciattach_tialt.c    | 1 +
 2 files changed, 2 insertions(+)

diff --git a/tools/hciattach_qualcomm.c b/tools/hciattach_qualcomm.c
index 0e02e1e..eb72a0f 100644
--- a/tools/hciattach_qualcomm.c
+++ b/tools/hciattach_qualcomm.c
@@ -40,6 +40,7 @@
 #include <sys/poll.h>
 #include <sys/param.h>
 #include <sys/ioctl.h>
+#include <sys/uio.h>
 
 #include <bluetooth/bluetooth.h>
 #include <bluetooth/hci.h>
diff --git a/tools/hciattach_tialt.c b/tools/hciattach_tialt.c
index c3caa49..5c7f3a5 100644
--- a/tools/hciattach_tialt.c
+++ b/tools/hciattach_tialt.c
@@ -39,6 +39,7 @@
 #include <sys/poll.h>
 #include <sys/param.h>
 #include <sys/ioctl.h>
+#include <sys/uio.h>
 
 #include <bluetooth/bluetooth.h>
 #include <bluetooth/hci.h>
-- 
1.9.1

Re: [PATCH] tools/hciattach: Fix missing includes

[Johan Hedberg]

Hi Szymon,

On Tue, Apr 15, 2014, Szymon Janc wrote:
> According to writev manual one should include <sys/uio.h> to use it.
> 
> This fix following warnings with bionic:
> external/bluetooth/bluez/tools/hciattach_tialt.c: In function
>     'texas_load_firmware':
> external/bluetooth/bluez/tools/hciattach_tialt.c:142:4: warning:
>     implicit declaration of function 'writev'
>     [-Wimplicit-function-declaration]
> target thumb C: hciattach <= external/bluetooth/bluez/tools/
>     hciattach_ath3k.c
> target thumb C: hciattach <= external/bluetooth/bluez/tools/
>     hciattach_qualcomm.c
> external/bluetooth/bluez/tools/hciattach_qualcomm.c: In function
>     'qualcomm_load_firmware':
> external/bluetooth/bluez/tools/hciattach_qualcomm.c:147:4: warning:
>     implicit declaration of function 'writev'
>     [-Wimplicit-function-declaration]
> ---
>  tools/hciattach_qualcomm.c | 1 +
>  tools/hciattach_tialt.c    | 1 +
>  2 files changed, 2 insertions(+)

Applied. Thanks.

Johan