From: Brian Norris <computersforpeace@gmail.com>
To: "Gupta, Pekon" <pekon@ti.com>
Cc: Jingoo Han <jg1.han@samsung.com>,
"'Christian Engelmayer'" <cengelma@gmx.at>,
"'David Woodhouse'" <dwmw2@infradead.org>,
"'Artem Bityutskiy'" <artem.bityutskiy@linux.intel.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: nand: omap: fix compile warning on ‘erased_sector_bitflips’
Date: Tue, 15 Apr 2014 23:21:08 -0700 [thread overview]
Message-ID: <20140416062108.GM3131@norris-Latitude-E6410> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EAC301C@DBDE04.ent.ti.com>
On Tue, Apr 15, 2014 at 03:58:56AM +0000, Pekon Gupta wrote:
> >From: Jingoo Han [mailto:jg1.han@samsung.com]
> >>On Tuesday, April 15, 2014 7:32 AM, Christian Engelmayer wrote:
> >>
> >> Commit 2c9f2365 (mtd: nand: omap: ecc.calculate: merge omap3_calculate_ecc_bch4
> >> in omap_calculate_ecc_bch) introduced minor compile warning
> >> "‘erased_sector_bitflips’ defined but not used [-Wunused-function]" when
> >> compiling without CONFIG_MTD_NAND_OMAP_BCH. Move function
> >> erased_sector_bitflips() into the same ifdef section as the only caller.
> >>
> >> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> >
> >Reviewed-by: Jingoo Han <jg1.han@samsung.com>
> >
> Thanks for the patch..
> Acked-by: Pekon Gupta <pekon@ti.com>
Pushed to l2-mtd.git. Thanks!
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: "Gupta, Pekon" <pekon@ti.com>
Cc: 'Christian Engelmayer' <cengelma@gmx.at>,
'Artem Bityutskiy' <artem.bityutskiy@linux.intel.com>,
Jingoo Han <jg1.han@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
'David Woodhouse' <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: nand: omap: fix compile warning on ‘erased_sector_bitflips’
Date: Tue, 15 Apr 2014 23:21:08 -0700 [thread overview]
Message-ID: <20140416062108.GM3131@norris-Latitude-E6410> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EAC301C@DBDE04.ent.ti.com>
On Tue, Apr 15, 2014 at 03:58:56AM +0000, Pekon Gupta wrote:
> >From: Jingoo Han [mailto:jg1.han@samsung.com]
> >>On Tuesday, April 15, 2014 7:32 AM, Christian Engelmayer wrote:
> >>
> >> Commit 2c9f2365 (mtd: nand: omap: ecc.calculate: merge omap3_calculate_ecc_bch4
> >> in omap_calculate_ecc_bch) introduced minor compile warning
> >> "‘erased_sector_bitflips’ defined but not used [-Wunused-function]" when
> >> compiling without CONFIG_MTD_NAND_OMAP_BCH. Move function
> >> erased_sector_bitflips() into the same ifdef section as the only caller.
> >>
> >> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> >
> >Reviewed-by: Jingoo Han <jg1.han@samsung.com>
> >
> Thanks for the patch..
> Acked-by: Pekon Gupta <pekon@ti.com>
Pushed to l2-mtd.git. Thanks!
Brian
next prev parent reply other threads:[~2014-04-16 6:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 22:32 [PATCH] mtd: nand: omap: fix compile warning on ‘erased_sector_bitflips’ Christian Engelmayer
2014-04-14 22:32 ` Christian Engelmayer
2014-04-15 0:33 ` Jingoo Han
2014-04-15 0:33 ` Jingoo Han
2014-04-15 3:58 ` Gupta, Pekon
2014-04-15 3:58 ` Gupta, Pekon
2014-04-16 6:21 ` Brian Norris [this message]
2014-04-16 6:21 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416062108.GM3131@norris-Latitude-E6410 \
--to=computersforpeace@gmail.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=cengelma@gmx.at \
--cc=dwmw2@infradead.org \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.