All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Paul Walmsley <paul@pwsan.com>
Cc: NeilBrown <neilb@suse.de>,
	linux-omap@vger.kernel.org,
	Benoit Cousson <bcousson@baylibre.com>,
	Tony Lindgren <tony@atomide.com>,
	Wolfram Sang <wsa@sang-engineering.com>
Subject: Re: [PATCH] ARM: OMAP2+: don't try to register the main clock twice.
Date: Thu, 17 Apr 2014 10:55:40 +0200	[thread overview]
Message-ID: <20140417085539.GA7804@katana> (raw)
In-Reply-To: <alpine.DEB.2.02.1404111829520.14347@utopia.booyaka.com>

[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]

Hi Paul,

thanks for the reply!

> > If omap_device_alloc is given 2 or more "struct omap_hwmod" it will try
> > to register the 'main_clk' of each of them with the same alias - "fck" -
> > against the same device.  This fails. So to avoid a warning, don't even
> > try.
> > 
> > Signed-off-by: NeilBrown <neilb@suse.de>
> > [wsa: ported to top-of-tree]
> > Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>
> 
> What devices and hwmods cause this warning on AM335x?   Ideally, there 
> should only be one hwmod per device.  Usually when multiple hwmods are 
> stacked up for a device, it means that something isn't right - either the 
> hwmod data, or the device driver itself. 

I applied the patch because of the edma driver DT entry for the am335x.
Check am33xx.dtsi, it has multiple hwmods. I also get this message
printed for the d_can driver with am335x; they have two entries in
drivers/clk/ti/clk-33xx.c. Probably as a workaround to match the desired
clock name for the d_can driver? Didn't really investigate yet.

> In the specific context of this patch, the problem would be: what if the 
> two hwmods have different main_clk entries?  Which one should be 
> associated with the "fck" alias?

Sadly, I am in a board bringup phase and can't really contribute to the
discussions. Lots of other issues to tackle at the moment.

All the best,

   Wolfram


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-04-17  8:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28 11:50 Wolfram Sang
2014-04-11 18:33 ` Paul Walmsley
2014-04-17  8:55   ` Wolfram Sang [this message]
2014-05-07 23:20     ` Paul Walmsley
2014-05-08  7:02       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140417085539.GA7804@katana \
    --to=wsa@the-dreams.de \
    --cc=bcousson@baylibre.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    --cc=wsa@sang-engineering.com \
    --subject='Re: [PATCH] ARM: OMAP2+: don'\''t try to register the main clock twice.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.