* [PATCH] perf, x86: Don't mark DataLA addresses as store
@ 2014-04-17 23:39 Andi Kleen
2014-04-18 10:25 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2014-04-17 23:39 UTC (permalink / raw)
To: peterz; +Cc: linux-kernel, Andi Kleen
From: Andi Kleen <ak@linux.intel.com>
Haswell supports reporting the data address for a range
of events, including UOPS_RETIRED.ALL and some load
events. Currently these addresses were always marked
as stores, which is wrong, as they could be loads too.
Change it to NA instead.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
arch/x86/kernel/cpu/perf_event_intel_ds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_ds.c b/arch/x86/kernel/cpu/perf_event_intel_ds.c
index ae96cfa..7e9546a 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_ds.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_ds.c
@@ -113,7 +113,7 @@ static u64 precise_store_data_hsw(u64 status)
union perf_mem_data_src dse;
dse.val = 0;
- dse.mem_op = PERF_MEM_OP_STORE;
+ dse.mem_op = PERF_MEM_OP_NA;
dse.mem_lvl = PERF_MEM_LVL_NA;
if (status & 1)
dse.mem_lvl = PERF_MEM_LVL_L1;
--
1.8.5.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf, x86: Don't mark DataLA addresses as store
2014-04-17 23:39 [PATCH] perf, x86: Don't mark DataLA addresses as store Andi Kleen
@ 2014-04-18 10:25 ` Ingo Molnar
2014-04-18 16:30 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2014-04-18 10:25 UTC (permalink / raw)
To: Andi Kleen; +Cc: peterz, linux-kernel, Andi Kleen
* Andi Kleen <andi@firstfloor.org> wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Haswell supports reporting the data address for a range
> of events, including UOPS_RETIRED.ALL and some load
> events. Currently these addresses were always marked
> as stores, which is wrong, as they could be loads too.
> Change it to NA instead.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> arch/x86/kernel/cpu/perf_event_intel_ds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_ds.c b/arch/x86/kernel/cpu/perf_event_intel_ds.c
> index ae96cfa..7e9546a 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel_ds.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_ds.c
> @@ -113,7 +113,7 @@ static u64 precise_store_data_hsw(u64 status)
> union perf_mem_data_src dse;
>
> dse.val = 0;
> - dse.mem_op = PERF_MEM_OP_STORE;
> + dse.mem_op = PERF_MEM_OP_NA;
> dse.mem_lvl = PERF_MEM_LVL_NA;
> if (status & 1)
> dse.mem_lvl = PERF_MEM_LVL_L1;
NAK, this changelog is still deficient for the same reason it was
deficient a month ago.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf, x86: Don't mark DataLA addresses as store
2014-04-18 10:25 ` Ingo Molnar
@ 2014-04-18 16:30 ` Andi Kleen
0 siblings, 0 replies; 3+ messages in thread
From: Andi Kleen @ 2014-04-18 16:30 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Andi Kleen, peterz, linux-kernel, Andi Kleen
> NAK, this changelog is still deficient for the same reason it was
> deficient a month ago.
The post last time didn't get any comments on this patch at all.
I don't see anything wrong with the changelog. It explains
the problem completely and succiently. If you want improvements
please be more specific.
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-18 16:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-17 23:39 [PATCH] perf, x86: Don't mark DataLA addresses as store Andi Kleen
2014-04-18 10:25 ` Ingo Molnar
2014-04-18 16:30 ` Andi Kleen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.