[PATCH] ARM: fix v7-M setup stack location

[PATCH] ARM: fix v7-M setup stack location

[Rabin Vincent]

__v7m_setup_stack currently sits in the .proc.info.init section, and
thus creates a bogus proc info entry (which by the way matches any
unknown CPU IDs, due to the entry's mask being 0).  Move it out of
there.

Signed-off-by: Rabin Vincent <rabin@rab.in>
---
 arch/arm/mm/proc-v7m.S | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mm/proc-v7m.S b/arch/arm/mm/proc-v7m.S
index 0c93588..1ca37c7 100644
--- a/arch/arm/mm/proc-v7m.S
+++ b/arch/arm/mm/proc-v7m.S
@@ -123,6 +123,11 @@ __v7m_setup:
 	mov	pc, lr
 ENDPROC(__v7m_setup)
 
+	.align 2
+__v7m_setup_stack:
+	.space	4 * 8				@ 8 registers
+__v7m_setup_stack_top:
+
 	define_processor_functions v7m, dabort=nommu_early_abort, pabort=legacy_pabort, nommu=1
 
 	.section ".rodata"
@@ -152,6 +157,3 @@ __v7m_proc_info:
 	.long	nop_cache_fns		@ proc_info_list.cache
 	.size	__v7m_proc_info, . - __v7m_proc_info
 
-__v7m_setup_stack:
-	.space	4 * 8				@ 8 registers
-__v7m_setup_stack_top:
-- 
1.9.1

[PATCH] ARM: fix v7-M setup stack location

[Uwe Kleine-König]

Hello,

On Mon, Apr 21, 2014 at 08:07:17PM +0200, Rabin Vincent wrote:
> __v7m_setup_stack currently sits in the .proc.info.init section, and
> thus creates a bogus proc info entry (which by the way matches any
> unknown CPU IDs, due to the entry's mask being 0).  Move it out of
> there.
> 
> Signed-off-by: Rabin Vincent <rabin@rab.in>
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

It seems the unpatched code didn't do any harm as long as you boot the
resulting kernel on a v7-M machine. So I'd say it's not a very urgent
fix and getting it in during the next merge window is just fine.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |