All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Pargmann <mpa@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	alsa-devel@alsa-project.org, Alexander Shiyan <shc_work@mail.ru>,
	Timur Tabi <timur@tabi.org>,
	"Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>,
	kernel@pengutronix.de, Nicolin Chen <Guangyu.Chen@freescale.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 00/18] ASoC: fsl-ssi: Driver cleanup
Date: Mon, 28 Apr 2014 10:54:53 +0200	[thread overview]
Message-ID: <20140428085453.GC15179@pengutronix.de> (raw)
In-Reply-To: <20140424114403.GN12304@sirena.org.uk>


[-- Attachment #1.1: Type: text/plain, Size: 1306 bytes --]

Hi,

On Thu, Apr 24, 2014 at 12:44:03PM +0100, Mark Brown wrote:
> On Mon, Apr 14, 2014 at 03:35:30PM +0200, Markus Pargmann wrote:
> 
> > This series is a cleanup of the fsl-ssi driver.
> 
> There's been some review comments on this series but only negative ones
> and I've not seen any testing reports either.  Are the other patches OK
> for people?
> 
> > There is no DT binding for regmap yet, as this should be solved in the regmap
> > framework first. The current configuration should at least work on the same
> > SoCs it was previously used. As soon as we have a common DT binding to set the
> > endianess we replace it in this driver.
> 
> I'm really not convinced that this is a good idea to be frank - I would
> expect devices to still need to be involved to set defaults.

What do you think of some framework function like
of_regmap_parse_endianess()? This would offer a common devicetree
binding and the driver would still be involved.

Regards,

Markus


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



WARNING: multiple messages have this Message-ID (diff)
From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 00/18] ASoC: fsl-ssi: Driver cleanup
Date: Mon, 28 Apr 2014 10:54:53 +0200	[thread overview]
Message-ID: <20140428085453.GC15179@pengutronix.de> (raw)
In-Reply-To: <20140424114403.GN12304@sirena.org.uk>

Hi,

On Thu, Apr 24, 2014 at 12:44:03PM +0100, Mark Brown wrote:
> On Mon, Apr 14, 2014 at 03:35:30PM +0200, Markus Pargmann wrote:
> 
> > This series is a cleanup of the fsl-ssi driver.
> 
> There's been some review comments on this series but only negative ones
> and I've not seen any testing reports either.  Are the other patches OK
> for people?
> 
> > There is no DT binding for regmap yet, as this should be solved in the regmap
> > framework first. The current configuration should at least work on the same
> > SoCs it was previously used. As soon as we have a common DT binding to set the
> > endianess we replace it in this driver.
> 
> I'm really not convinced that this is a good idea to be frank - I would
> expect devices to still need to be involved to set defaults.

What do you think of some framework function like
of_regmap_parse_endianess()? This would offer a common devicetree
binding and the driver would still be involved.

Regards,

Markus


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140428/552d42ae/attachment.sig>

  reply	other threads:[~2014-04-28  8:55 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14 13:35 [PATCH v3 00/18] ASoC: fsl-ssi: Driver cleanup Markus Pargmann
2014-04-14 13:35 ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 01/18] ASoC: fsl-ssi: Fix register values when disabling Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 02/18] ASoC: fsl-ssi: Move debugging to seperate file Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 03/18] ASoC: fsl-ssi: Use dev_name for DAI driver struct Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 04/18] ASoC: fsl-ssi: Move imx-specific probe to seperate function Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 05/18] ASoC: fsl-ssi: Remove useless DMA code Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 06/18] ASoC: fsl-ssi: Cleanup probe function Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 07/18] ASoC: fsl-ssi: Remove unnecessary variables from ssi_private Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 08/18] ASoC: fsl-ssi: introduce SoC specific data Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 09/18] ASoC: fsl-ssi: Only enable baudclk when used Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 15:28   ` Nicolin Chen
2014-04-14 15:28     ` Nicolin Chen
2014-04-16  7:27     ` Markus Pargmann
2014-04-16  7:27       ` Markus Pargmann
2014-04-16  8:08       ` Nicolin Chen
2014-04-16  8:08         ` Nicolin Chen
2014-04-16  8:43         ` Markus Pargmann
2014-04-16  8:43           ` Markus Pargmann
2014-04-16  8:40           ` Nicolin Chen
2014-04-16  8:40             ` Nicolin Chen
2014-04-16 17:42         ` Mark Brown
2014-04-16 17:42           ` Mark Brown
2014-04-17 13:46       ` Timur Tabi
2014-04-17 13:46         ` Timur Tabi
2014-04-14 13:35 ` [PATCH v3 10/18] ASoC: fsl-ssi: make fsl,mode property optional Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 11/18] ASoC: fsl-ssi: Transmit enable synchronization Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 12/18] ASoC: fsl-ssi: Move fsl_ssi_set_dai_sysclk above fsl_ssi_hw_params Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 13/18] ASoC: fsl-ssi: set bitclock in master mode from hw_params Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 14/18] ASoC: fsl-ssi: remove unnecessary spinlock Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 15/18] ASoC: fsl-ssi: Allow first stream to set the bitclock Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 16/18] ASoC: fsl-ssi: Set framerate divider correctly for i2s master mode Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 17/18] ASoC: fsl-ssi: reorder and document fsl_ssi_private Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-14 13:35 ` [PATCH v3 18/18] ASoC: fsl-ssi: Use regmap Markus Pargmann
2014-04-14 13:35   ` Markus Pargmann
2014-04-24 11:44 ` [PATCH v3 00/18] ASoC: fsl-ssi: Driver cleanup Mark Brown
2014-04-24 11:44   ` Mark Brown
2014-04-28  8:54   ` Markus Pargmann [this message]
2014-04-28  8:54     ` Markus Pargmann
2014-04-29 16:22     ` Mark Brown
2014-04-29 16:22       ` Mark Brown
2014-04-30  2:01       ` Li.Xiubo
2014-04-30  2:01         ` Li.Xiubo at freescale.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140428085453.GC15179@pengutronix.de \
    --to=mpa@pengutronix.de \
    --cc=Guangyu.Chen@freescale.com \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=fabio.estevam@freescale.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=shc_work@mail.ru \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.