From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
linux-spi <linux-spi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: Fix hung task timeout when initialization fails
Date: Thu, 1 May 2014 09:03:38 -0700 [thread overview]
Message-ID: <20140501160338.GA3245@sirena.org.uk> (raw)
In-Reply-To: <CAMuHMdUeFJDq8TMQn=D+y_nWVy-puZDYekV3cPhHTnDF+ebKJA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On Thu, May 01, 2014 at 04:33:58PM +0200, Geert Uytterhoeven wrote:
> On Thu, May 1, 2014 at 4:11 PM, Mark Brown <broonie@kernel.org> wrote:
> master->kworker_task is set like this:
> master->kworker_task = kthread_run(...)
> so it just contains the status of the creation of the kthread, not if it was
> killed, right? Hence we don't check if it was killed.
> So Ricardo's patch prevents the stopping and destruction of the thread
> if it failed to be _created_.
OK, so that means that the description is very confusing then since it's
talking about the issue being due to kthread_run being killed.
> What if it is killed? I suppose the kthread API handles that internally, as it
> could happen to any thread (e.g. OOM)?
I'm not 100% clear on this to be honest. Since I'm at ELC I've not
investigated fully yet and I'm mostly going on the patch descriptions
here.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: Ricardo Ribalda Delgado
<ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] spi: Fix hung task timeout when initialization fails
Date: Thu, 1 May 2014 09:03:38 -0700 [thread overview]
Message-ID: <20140501160338.GA3245@sirena.org.uk> (raw)
In-Reply-To: <CAMuHMdUeFJDq8TMQn=D+y_nWVy-puZDYekV3cPhHTnDF+ebKJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Thu, May 01, 2014 at 04:33:58PM +0200, Geert Uytterhoeven wrote:
> On Thu, May 1, 2014 at 4:11 PM, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> master->kworker_task is set like this:
> master->kworker_task = kthread_run(...)
> so it just contains the status of the creation of the kthread, not if it was
> killed, right? Hence we don't check if it was killed.
> So Ricardo's patch prevents the stopping and destruction of the thread
> if it failed to be _created_.
OK, so that means that the description is very confusing then since it's
talking about the issue being due to kthread_run being killed.
> What if it is killed? I suppose the kthread API handles that internally, as it
> could happen to any thread (e.g. OOM)?
I'm not 100% clear on this to be honest. Since I'm at ELC I've not
investigated fully yet and I'm mostly going on the patch descriptions
here.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-01 16:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 10:36 [PATCH] spi: Fix hung task timeout when initialization fails Ricardo Ribalda Delgado
2014-05-01 1:34 ` Mark Brown
2014-05-01 1:34 ` Mark Brown
2014-05-01 5:53 ` Ricardo Ribalda Delgado
2014-05-01 5:53 ` Ricardo Ribalda Delgado
2014-05-01 14:11 ` Mark Brown
2014-05-01 14:11 ` Mark Brown
2014-05-01 14:33 ` Geert Uytterhoeven
2014-05-01 14:33 ` Geert Uytterhoeven
2014-05-01 16:03 ` Mark Brown [this message]
2014-05-01 16:03 ` Mark Brown
2014-05-01 8:15 Ricardo Ribalda Delgado
2014-05-01 8:15 ` Ricardo Ribalda Delgado
2014-05-01 16:09 ` Mark Brown
2014-05-01 16:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140501160338.GA3245@sirena.org.uk \
--to=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.