* [PATCH] RTL8192CU: Increase max APFM_ONMAC polling count
@ 2014-05-02 6:48 Andy Spencer
2014-05-06 14:18 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Andy Spencer @ 2014-05-02 6:48 UTC (permalink / raw)
To: linux-wireless
With certain hardware combinations the poll interval is exceeded before
initialization completes.
Tested on a MacBookPro10,1 using a Sabrent USB-A11N USB adapter.
Signed-off-by: Andy Spencer <andy753421@ucla.edu>
---
I was unable to reproduce this issue using other hardware combinations.
I thought it might be a USB3 issue but another laptop with USB3 worked
without the patch.
With my hardware the polling count reaches around 230 before
initialization completes.
drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
@@ -511,7 +511,7 @@ static int _rtl92cu_init_power_on(struct ieee80211_hw *hw)
pr_info("MAC auto ON okay!\n");
break;
}
- if (pollingCount++ > 100) {
+ if (pollingCount++ > 1000) {
RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG,
"Failed to polling REG_APS_FSMCO[APFM_ONMAC] done!\n");
return -ENODEV;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] RTL8192CU: Increase max APFM_ONMAC polling count
2014-05-02 6:48 [PATCH] RTL8192CU: Increase max APFM_ONMAC polling count Andy Spencer
@ 2014-05-06 14:18 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2014-05-06 14:18 UTC (permalink / raw)
To: Andy Spencer, linux-wireless
On 05/02/2014 01:48 AM, Andy Spencer wrote:
> With certain hardware combinations the poll interval is exceeded before
> initialization completes.
>
> Tested on a MacBookPro10,1 using a Sabrent USB-A11N USB adapter.
>
> Signed-off-by: Andy Spencer <andy753421@ucla.edu>
> ---
> I was unable to reproduce this issue using other hardware combinations.
> I thought it might be a USB3 issue but another laptop with USB3 worked
> without the patch.
>
> With my hardware the polling count reaches around 230 before
> initialization completes.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
If the adapter initializes quickly, this change causes no problem. I have not
seen this kind of problem, but some hardware is obviously different.
Larry
>
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> @@ -511,7 +511,7 @@ static int _rtl92cu_init_power_on(struct ieee80211_hw *hw)
> pr_info("MAC auto ON okay!\n");
> break;
> }
> - if (pollingCount++ > 100) {
> + if (pollingCount++ > 1000) {
> RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG,
> "Failed to polling REG_APS_FSMCO[APFM_ONMAC] done!\n");
> return -ENODEV;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-06 14:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-02 6:48 [PATCH] RTL8192CU: Increase max APFM_ONMAC polling count Andy Spencer
2014-05-06 14:18 ` Larry Finger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.