* [PATCH v2] staging: rtl8188eu: fix potential leak in rtw_set_key()
@ 2014-05-01 10:30 Christian Engelmayer
2014-05-01 10:50 ` Dan Carpenter
2014-05-04 0:24 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Christian Engelmayer @ 2014-05-01 10:30 UTC (permalink / raw)
To: devel
Cc: dan.carpenter, mcgrof, gregkh, oat.elena, Larry.Finger, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2370 bytes --]
Fix a potential leak in the error path of rtw_set_key(). In case the requested
algorithm is not supported by the driver, the function returns without
enqueuing or freeing the already allocated command and parameter structs. Use
a centralized exit path and make sure that all memory is freed correctly.
Detected by Coverity - CID 1077716, 1077717.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
v2: Added changes requested by Dan Carpenter:
* Just return directly where no cleanup is needed.
* Prefer naming labels by the labeled action rather than the goto location.
Compile tested and applies against branch staging-next of tree
git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c
index 769d4dd..155282e 100644
--- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
+++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c
@@ -1727,15 +1727,13 @@ int rtw_set_key(struct adapter *adapter, struct security_priv *psecuritypriv, in
int res = _SUCCESS;
pcmd = (struct cmd_obj *)rtw_zmalloc(sizeof(struct cmd_obj));
- if (pcmd == NULL) {
- res = _FAIL; /* try again */
- goto exit;
- }
+ if (pcmd == NULL)
+ return _FAIL; /* try again */
+
psetkeyparm = (struct setkey_parm *)rtw_zmalloc(sizeof(struct setkey_parm));
if (psetkeyparm == NULL) {
- kfree(pcmd);
res = _FAIL;
- goto exit;
+ goto err_free_cmd;
}
_rtw_memset(psetkeyparm, 0, sizeof(struct setkey_parm));
@@ -1784,7 +1782,7 @@ int rtw_set_key(struct adapter *adapter, struct security_priv *psecuritypriv, in
("\n rtw_set_key:psecuritypriv->dot11PrivacyAlgrthm=%x (must be 1 or 2 or 4 or 5)\n",
psecuritypriv->dot11PrivacyAlgrthm));
res = _FAIL;
- goto exit;
+ goto err_free_parm;
}
pcmd->cmdcode = _SetKey_CMD_;
pcmd->parmbuf = (u8 *)psetkeyparm;
@@ -1793,7 +1791,12 @@ int rtw_set_key(struct adapter *adapter, struct security_priv *psecuritypriv, in
pcmd->rspsz = 0;
_rtw_init_listhead(&pcmd->list);
res = rtw_enqueue_cmd(pcmdpriv, pcmd);
-exit:
+ return res;
+
+err_free_parm:
+ kfree(psetkeyparm);
+err_free_cmd:
+ kfree(pcmd);
return res;
}
--
1.9.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: rtl8188eu: fix potential leak in rtw_set_key()
2014-05-01 10:30 [PATCH v2] staging: rtl8188eu: fix potential leak in rtw_set_key() Christian Engelmayer
@ 2014-05-01 10:50 ` Dan Carpenter
2014-05-04 0:24 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-05-01 10:50 UTC (permalink / raw)
To: Christian Engelmayer
Cc: devel, mcgrof, gregkh, oat.elena, Larry.Finger, linux-kernel
On Thu, May 01, 2014 at 12:30:57PM +0200, Christian Engelmayer wrote:
> Fix a potential leak in the error path of rtw_set_key(). In case the requested
> algorithm is not supported by the driver, the function returns without
> enqueuing or freeing the already allocated command and parameter structs. Use
> a centralized exit path and make sure that all memory is freed correctly.
> Detected by Coverity - CID 1077716, 1077717.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
> v2: Added changes requested by Dan Carpenter:
>
> * Just return directly where no cleanup is needed.
> * Prefer naming labels by the labeled action rather than the goto location.
>
> Compile tested and applies against branch staging-next of tree
> git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
Looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: rtl8188eu: fix potential leak in rtw_set_key()
2014-05-01 10:30 [PATCH v2] staging: rtl8188eu: fix potential leak in rtw_set_key() Christian Engelmayer
2014-05-01 10:50 ` Dan Carpenter
@ 2014-05-04 0:24 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2014-05-04 0:24 UTC (permalink / raw)
To: Christian Engelmayer
Cc: devel, mcgrof, linux-kernel, oat.elena, dan.carpenter, Larry.Finger
On Thu, May 01, 2014 at 12:30:57PM +0200, Christian Engelmayer wrote:
> Fix a potential leak in the error path of rtw_set_key(). In case the requested
> algorithm is not supported by the driver, the function returns without
> enqueuing or freeing the already allocated command and parameter structs. Use
> a centralized exit path and make sure that all memory is freed correctly.
> Detected by Coverity - CID 1077716, 1077717.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Added changes requested by Dan Carpenter:
>
> * Just return directly where no cleanup is needed.
> * Prefer naming labels by the labeled action rather than the goto location.
>
> Compile tested and applies against branch staging-next of tree
> git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
This patch doesn't apply to my tree, can you refresh and resend it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-04 1:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-01 10:30 [PATCH v2] staging: rtl8188eu: fix potential leak in rtw_set_key() Christian Engelmayer
2014-05-01 10:50 ` Dan Carpenter
2014-05-04 0:24 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.