All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: Make soc_find_matching_codec() static
@ 2014-05-04 17:18 Lars-Peter Clausen
  2014-05-05  0:31 ` Sebastian Reichel
  2014-05-05 19:29 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2014-05-04 17:18 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood
  Cc: alsa-devel, Lars-Peter Clausen, Sebastian Reichel

The function is only used locally, make it static.

Fixes the following warning from sparse:
	sound/soc/soc-core.c:1644:22: warning: symbol 'soc_find_matching_codec' was not declared. Should it be static?

Fixes: 3ca041ed ("ASoC: dt: Allow Aux Codecs to be specified using DT")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 sound/soc/soc-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index ff2b32f..e14bc6c 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1641,7 +1641,8 @@ static void soc_unregister_ac97_dai_link(struct snd_soc_pcm_runtime *rtd)
 }
 #endif
 
-struct snd_soc_codec *soc_find_matching_codec(struct snd_soc_card *card, int num)
+static struct snd_soc_codec *soc_find_matching_codec(struct snd_soc_card *card,
+	int num)
 {
 	struct snd_soc_aux_dev *aux_dev = &card->aux_dev[num];
 	struct snd_soc_codec *codec;
-- 
1.8.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: Make soc_find_matching_codec() static
  2014-05-04 17:18 [PATCH] ASoC: Make soc_find_matching_codec() static Lars-Peter Clausen
@ 2014-05-05  0:31 ` Sebastian Reichel
  2014-05-05 19:29 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2014-05-05  0:31 UTC (permalink / raw)
  To: Lars-Peter Clausen; +Cc: alsa-devel, Mark Brown, Liam Girdwood


[-- Attachment #1.1: Type: text/plain, Size: 491 bytes --]

Hi,

On Sun, May 04, 2014 at 07:18:30PM +0200, Lars-Peter Clausen wrote:
> The function is only used locally, make it static.
> 
> Fixes the following warning from sparse:
> 	sound/soc/soc-core.c:1644:22: warning: symbol 'soc_find_matching_codec' was not declared. Should it be static?
> 
> Fixes: 3ca041ed ("ASoC: dt: Allow Aux Codecs to be specified using DT")
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Acked-By: Sebastian Reichel <sre@kernel.org>

-- Sebastian

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: Make soc_find_matching_codec() static
  2014-05-04 17:18 [PATCH] ASoC: Make soc_find_matching_codec() static Lars-Peter Clausen
  2014-05-05  0:31 ` Sebastian Reichel
@ 2014-05-05 19:29 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-05-05 19:29 UTC (permalink / raw)
  To: Lars-Peter Clausen; +Cc: alsa-devel, Liam Girdwood, Sebastian Reichel


[-- Attachment #1.1: Type: text/plain, Size: 139 bytes --]

On Sun, May 04, 2014 at 07:18:30PM +0200, Lars-Peter Clausen wrote:
> The function is only used locally, make it static.

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-06  0:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-04 17:18 [PATCH] ASoC: Make soc_find_matching_codec() static Lars-Peter Clausen
2014-05-05  0:31 ` Sebastian Reichel
2014-05-05 19:29 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.