Re: [Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

Re: [Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

On (05/05/14 23:42), Auke Kok wrote:
> ---
>  configure.ac | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index baa5faa..5a90fe3 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -46,7 +46,8 @@ AC_FUNC_REALLOC
>  AC_FUNC_STRTOD
>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir munmap pow realpath regcomp select setlocale socket sqrt strcasecmp strchr strdup strerror strncasecmp strstr strtoul strtoull])
>  
> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), [])
> +PKG_CHECK_MODULES([NCURSES], [ncurses], [LIBS="$LIBS $ncurses_LIBS"],
				^^^^^^^^^
				[ncursesw ncurses]?

	-ss

> +	AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), []))
>  
>  has_libpci=0
>  PKG_CHECK_MODULES([PCIUTILS], [libpci],[has_libpci=1],[
> -- 
> 1.7.11.2
> 
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
> 

Re: [Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

[Joe Konno]

[-- Attachment #1: Type: text/plain, Size: 102 bytes --]

+1

Tested-by: Joe Konno <joe.konno(a)intel.com>
Reviewed-by: Joe Konno <joe.konno(a)intel.com>

[Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

[Auke Kok]

[-- Attachment #1: Type: text/plain, Size: 880 bytes --]

v3 - also link against ncursesw.
---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index baa5faa..5ca370d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -46,7 +46,8 @@ AC_FUNC_REALLOC
 AC_FUNC_STRTOD
 AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir munmap pow realpath regcomp select setlocale socket sqrt strcasecmp strchr strdup strerror strncasecmp strstr strtoul strtoull])
 
-AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), [])
+PKG_CHECK_MODULES([NCURSES], [ncursesw ncurses], [LIBS="$LIBS $ncurses_LIBS"],
+	AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), []))
 
 has_libpci=0
 PKG_CHECK_MODULES([PCIUTILS], [libpci],[has_libpci=1],[
-- 
1.7.11.2

Re: [Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

[Kok, Auke-jan H]

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

Ignore this one, somehow I messed up the --amend :(

Auke


On Fri, May 9, 2014 at 2:59 PM, Auke Kok <auke-jan.h.kok(a)intel.com> wrote:
> v2 - also link against ncursesw.
> ---
>  configure.ac | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index baa5faa..5a90fe3 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -46,7 +46,8 @@ AC_FUNC_REALLOC
>  AC_FUNC_STRTOD
>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir munmap pow realpath regcomp select setlocale socket sqrt strcasecmp strchr strdup strerror strncasecmp strstr strtoul strtoull])
>
> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), [])
> +PKG_CHECK_MODULES([NCURSES], [ncurses], [LIBS="$LIBS $ncurses_LIBS"],
> +       AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), []))
>
>  has_libpci=0
>  PKG_CHECK_MODULES([PCIUTILS], [libpci],[has_libpci=1],[
> --
> 1.7.11.2
>

Re: [Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

[Kok, Auke-jan H]

[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]

On Fri, May 9, 2014 at 12:30 AM, Sergey Senozhatsky
<sergey.senozhatsky(a)gmail.com> wrote:
> On (05/08/14 10:06), Joe Konno wrote:
>> On Tue, May 06, 2014 at 05:38:24PM -0700, Kok, Auke-jan H wrote:
>> > On Tue, May 6, 2014 at 12:53 AM, Sergey Senozhatsky
>> > <sergey.senozhatsky(a)gmail.com> wrote:
>> > > On (05/05/14 23:42), Auke Kok wrote:
>> > >> ---
>> > >>  configure.ac | 3 ++-
>> > >>  1 file changed, 2 insertions(+), 1 deletion(-)
>> > >>
>> > >> diff --git a/configure.ac b/configure.ac
>> > >> index baa5faa..5a90fe3 100644
>> > >> --- a/configure.ac
>> > >> +++ b/configure.ac
>> > >> @@ -46,7 +46,8 @@ AC_FUNC_REALLOC
>> > >>  AC_FUNC_STRTOD
>> > >>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir munmap pow realpath regcomp select setlocale socket sqrt strcasecmp strchr strdup strerror strncasecmp strstr strtoul strtoull])
>> > >>
>> > >> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), [])
>> > >> +PKG_CHECK_MODULES([NCURSES], [ncurses], [LIBS="$LIBS $ncurses_LIBS"],
>> > >                                 ^^^^^^^^^
>> > >                                 [ncursesw ncurses]?
>>
>> On my gentoo system (x86_64) with ncurses 5.9, after applying this patch,
>> -lncurses is linked, but not -lncursesw.
>>
>> >
>> > Good question, I actually do not know, and I don't have an ncurses
>> > pkgconfig around to see if that works.
>> >
>> > Alexandra, can you see if this works with:
>> >
>> > +PKG_CHECK_MODULES([NCURSES], [ncursesw ncurses], [LIBS="$LIBS $ncurses_LIBS"],
>>
>> After hacking in this change, both -lncursesw and -lncurses are linked.
>>
>> If I checkout the v2.5 tag, only -lncursesw is linked.
>>
>> So, three different linking scenarios. Which one is "correct" for powertop?
>>
>
> ncursesw is preferred.

yup. I just sent a new version, which should be OK to merge for Alex.

Cheers,

Auke

[Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

[Auke Kok]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

v2 - also link against ncursesw.
---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index baa5faa..5a90fe3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -46,7 +46,8 @@ AC_FUNC_REALLOC
 AC_FUNC_STRTOD
 AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir munmap pow realpath regcomp select setlocale socket sqrt strcasecmp strchr strdup strerror strncasecmp strstr strtoul strtoull])
 
-AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), [])
+PKG_CHECK_MODULES([NCURSES], [ncurses], [LIBS="$LIBS $ncurses_LIBS"],
+	AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), []))
 
 has_libpci=0
 PKG_CHECK_MODULES([PCIUTILS], [libpci],[has_libpci=1],[
-- 
1.7.11.2

Re: [Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 1746 bytes --]

On (05/08/14 10:06), Joe Konno wrote:
> On Tue, May 06, 2014 at 05:38:24PM -0700, Kok, Auke-jan H wrote:
> > On Tue, May 6, 2014 at 12:53 AM, Sergey Senozhatsky
> > <sergey.senozhatsky(a)gmail.com> wrote:
> > > On (05/05/14 23:42), Auke Kok wrote:
> > >> ---
> > >>  configure.ac | 3 ++-
> > >>  1 file changed, 2 insertions(+), 1 deletion(-)
> > >>
> > >> diff --git a/configure.ac b/configure.ac
> > >> index baa5faa..5a90fe3 100644
> > >> --- a/configure.ac
> > >> +++ b/configure.ac
> > >> @@ -46,7 +46,8 @@ AC_FUNC_REALLOC
> > >>  AC_FUNC_STRTOD
> > >>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir munmap pow realpath regcomp select setlocale socket sqrt strcasecmp strchr strdup strerror strncasecmp strstr strtoul strtoull])
> > >>
> > >> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), [])
> > >> +PKG_CHECK_MODULES([NCURSES], [ncurses], [LIBS="$LIBS $ncurses_LIBS"],
> > >                                 ^^^^^^^^^
> > >                                 [ncursesw ncurses]?
> 
> On my gentoo system (x86_64) with ncurses 5.9, after applying this patch,
> -lncurses is linked, but not -lncursesw.
> 
> > 
> > Good question, I actually do not know, and I don't have an ncurses
> > pkgconfig around to see if that works.
> > 
> > Alexandra, can you see if this works with:
> > 
> > +PKG_CHECK_MODULES([NCURSES], [ncursesw ncurses], [LIBS="$LIBS $ncurses_LIBS"],
> 
> After hacking in this change, both -lncursesw and -lncurses are linked.
> 
> If I checkout the v2.5 tag, only -lncursesw is linked.
> 
> So, three different linking scenarios. Which one is "correct" for powertop?
> 

ncursesw is preferred.

	-ss

Re: [Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

[Joe Konno]

[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]

On Tue, May 06, 2014 at 05:38:24PM -0700, Kok, Auke-jan H wrote:
> On Tue, May 6, 2014 at 12:53 AM, Sergey Senozhatsky
> <sergey.senozhatsky(a)gmail.com> wrote:
> > On (05/05/14 23:42), Auke Kok wrote:
> >> ---
> >>  configure.ac | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/configure.ac b/configure.ac
> >> index baa5faa..5a90fe3 100644
> >> --- a/configure.ac
> >> +++ b/configure.ac
> >> @@ -46,7 +46,8 @@ AC_FUNC_REALLOC
> >>  AC_FUNC_STRTOD
> >>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir munmap pow realpath regcomp select setlocale socket sqrt strcasecmp strchr strdup strerror strncasecmp strstr strtoul strtoull])
> >>
> >> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), [])
> >> +PKG_CHECK_MODULES([NCURSES], [ncurses], [LIBS="$LIBS $ncurses_LIBS"],
> >                                 ^^^^^^^^^
> >                                 [ncursesw ncurses]?

On my gentoo system (x86_64) with ncurses 5.9, after applying this patch,
-lncurses is linked, but not -lncursesw.

> 
> Good question, I actually do not know, and I don't have an ncurses
> pkgconfig around to see if that works.
> 
> Alexandra, can you see if this works with:
> 
> +PKG_CHECK_MODULES([NCURSES], [ncursesw ncurses], [LIBS="$LIBS $ncurses_LIBS"],

After hacking in this change, both -lncursesw and -lncurses are linked.

If I checkout the v2.5 tag, only -lncursesw is linked.

So, three different linking scenarios. Which one is "correct" for powertop?

Re: [Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

[Alexandra Yates]

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]


>> On Tue, May 6, 2014 at 12:53 AM, Sergey Senozhatsky
>> <sergey.senozhatsky(a)gmail.com> wrote:
>>> On (05/05/14 23:42), Auke Kok wrote:
>>>> ---
>>>>  configure.ac | 3 ++-
>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/configure.ac b/configure.ac
>>>> index baa5faa..5a90fe3 100644
>>>> --- a/configure.ac
>>>> +++ b/configure.ac
>>>> @@ -46,7 +46,8 @@ AC_FUNC_REALLOC
>>>>  AC_FUNC_STRTOD
>>>>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset
>>>> mkdir munmap pow realpath regcomp select setlocale socket sqrt
>>>> strcasecmp strchr strdup strerror strncasecmp strstr strtoul
>>>> strtoull])
>>>>
>>>> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [],
>>>> AC_MSG_ERROR([ncurses
>>>> is required but was not found]), [])
>>>> +PKG_CHECK_MODULES([NCURSES], [ncurses], [LIBS="$LIBS $ncurses_LIBS"],
>>>                                 ^^^^^^^^^
>>>                                 [ncursesw ncurses]?
>>
>> Good question, I actually do not know, and I don't have an ncurses
>> pkgconfig around to see if that works.
>>
>> Alexandra, can you see if this works with:
>>
>> +PKG_CHECK_MODULES([NCURSES], [ncursesw ncurses], [LIBS="$LIBS
>> $ncurses_LIBS"],
>>
>> That needs to be tested by someone with a new ncurses.
>>
>> Auke
>>
>
> I'm on training this week.  I will be able to test at the end of the day
> after my class today.
>
> Thank you,
> Alexandra.
>
I tested in ubuntu I'm running libncurses5 powertop configured and
installed with out issues.

Looking for someone to test on chrome.

Thank you,
Alexandra.

Re: [Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

[Alexandra Yates]

[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]

> On Tue, May 6, 2014 at 12:53 AM, Sergey Senozhatsky
> <sergey.senozhatsky(a)gmail.com> wrote:
>> On (05/05/14 23:42), Auke Kok wrote:
>>> ---
>>>  configure.ac | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index baa5faa..5a90fe3 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -46,7 +46,8 @@ AC_FUNC_REALLOC
>>>  AC_FUNC_STRTOD
>>>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset
>>> mkdir munmap pow realpath regcomp select setlocale socket sqrt
>>> strcasecmp strchr strdup strerror strncasecmp strstr strtoul
>>> strtoull])
>>>
>>> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses
>>> is required but was not found]), [])
>>> +PKG_CHECK_MODULES([NCURSES], [ncurses], [LIBS="$LIBS $ncurses_LIBS"],
>>                                 ^^^^^^^^^
>>                                 [ncursesw ncurses]?
>
> Good question, I actually do not know, and I don't have an ncurses
> pkgconfig around to see if that works.
>
> Alexandra, can you see if this works with:
>
> +PKG_CHECK_MODULES([NCURSES], [ncursesw ncurses], [LIBS="$LIBS
> $ncurses_LIBS"],
>
> That needs to be tested by someone with a new ncurses.
>
> Auke
>

I'm on training this week.  I will be able to test at the end of the day
after my class today.

Thank you,
Alexandra.

Re: [Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

[Kok, Auke-jan H]

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

On Tue, May 6, 2014 at 12:53 AM, Sergey Senozhatsky
<sergey.senozhatsky(a)gmail.com> wrote:
> On (05/05/14 23:42), Auke Kok wrote:
>> ---
>>  configure.ac | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index baa5faa..5a90fe3 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -46,7 +46,8 @@ AC_FUNC_REALLOC
>>  AC_FUNC_STRTOD
>>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir munmap pow realpath regcomp select setlocale socket sqrt strcasecmp strchr strdup strerror strncasecmp strstr strtoul strtoull])
>>
>> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), [])
>> +PKG_CHECK_MODULES([NCURSES], [ncurses], [LIBS="$LIBS $ncurses_LIBS"],
>                                 ^^^^^^^^^
>                                 [ncursesw ncurses]?

Good question, I actually do not know, and I don't have an ncurses
pkgconfig around to see if that works.

Alexandra, can you see if this works with:

+PKG_CHECK_MODULES([NCURSES], [ncursesw ncurses], [LIBS="$LIBS $ncurses_LIBS"],

That needs to be tested by someone with a new ncurses.

Auke

[Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

[Auke Kok]

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index baa5faa..5a90fe3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -46,7 +46,8 @@ AC_FUNC_REALLOC
 AC_FUNC_STRTOD
 AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir munmap pow realpath regcomp select setlocale socket sqrt strcasecmp strchr strdup strerror strncasecmp strstr strtoul strtoull])
 
-AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), [])
+PKG_CHECK_MODULES([NCURSES], [ncurses], [LIBS="$LIBS $ncurses_LIBS"],
+	AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), []))
 
 has_libpci=0
 PKG_CHECK_MODULES([PCIUTILS], [libpci],[has_libpci=1],[
-- 
1.7.11.2