All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [Bug 6992] New: Incorrect installation rights on external kernel module makes it unloadable
@ 2014-03-27  9:01 bugzilla at busybox.net
  2014-04-29 18:57 ` [Buildroot] [Bug 6992] " bugzilla at busybox.net
  2014-05-07 13:09 ` bugzilla at busybox.net
  0 siblings, 2 replies; 3+ messages in thread
From: bugzilla at busybox.net @ 2014-03-27  9:01 UTC (permalink / raw)
  To: buildroot

https://bugs.busybox.net/show_bug.cgi?id=6992

           Summary: Incorrect installation rights on external kernel
                    module makes it unloadable
           Product: buildroot
           Version: 2014.02
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Other
        AssignedTo: unassigned at buildroot.uclibc.org
        ReportedBy: jpcartal at free.fr
                CC: buildroot at uclibc.org
   Estimated Hours: 0.0


Hello,

I'm currently working on a project that needs using external kernel modules.
I added a dedicated package for those to be built and installed.
However I made a mistake in the INSTALL_TARGET_CMDS rule since I asked for
those modules to be installed with 0755 access rights in the
$(TARGET_DIR)/lib/modules/$(KERNEL_RELEASE)/kernel/drivers/net/wireless/
directory.

Using the access rights above have the unexpected consequence that those
modules are stripped using the following command: 
$(STRIP_FIND_CMD) | xargs $(STRIPCMD) 2>/dev/null || true i.e. 
find buildroot/output/target -type f \( -perm /111 -o -name '*.so*' \) -not \(
-name 'libpthread*.so*' \) -print | xargs
buildroot/output/host/usr/bin/mipsel-buildroot-linux-uclibc-strip
--remove-section=.comment --remove-section=.note 2>/dev/null || true
Thus leading to stripped kernel modules that can not be loaded.

Changing the install access rights to 0664 make the correct strip command to be
used :
find $(TARGET_DIR)/lib/modules -type f -name '*.ko' | \
        xargs -r $(KSTRIPCMD);fi

And the modules can then be loaded normally.

While I understand this is a mistake on my side and I found it quite hard to
track the root of the issue, it might be usefull to either :
* Change the $(STRIP_FIND_CMD) to not take into account kernel modules
* Yield an error or a warning during the make process
* Document this behaviour

Regards.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [Bug 6992] Incorrect installation rights on external kernel module makes it unloadable
  2014-03-27  9:01 [Buildroot] [Bug 6992] New: Incorrect installation rights on external kernel module makes it unloadable bugzilla at busybox.net
@ 2014-04-29 18:57 ` bugzilla at busybox.net
  2014-05-07 13:09 ` bugzilla at busybox.net
  1 sibling, 0 replies; 3+ messages in thread
From: bugzilla at busybox.net @ 2014-04-29 18:57 UTC (permalink / raw)
  To: buildroot

https://bugs.busybox.net/show_bug.cgi?id=6992

--- Comment #1 from Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> 2014-04-29 18:57:09 UTC ---
A patch implementing the first suggestion was sent to the list:
http://patchwork.ozlabs.org/patch/343972/

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [Bug 6992] Incorrect installation rights on external kernel module makes it unloadable
  2014-03-27  9:01 [Buildroot] [Bug 6992] New: Incorrect installation rights on external kernel module makes it unloadable bugzilla at busybox.net
  2014-04-29 18:57 ` [Buildroot] [Bug 6992] " bugzilla at busybox.net
@ 2014-05-07 13:09 ` bugzilla at busybox.net
  1 sibling, 0 replies; 3+ messages in thread
From: bugzilla at busybox.net @ 2014-05-07 13:09 UTC (permalink / raw)
  To: buildroot

https://bugs.busybox.net/show_bug.cgi?id=6992

Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> 2014-05-07 13:09:05 UTC ---
Fixed with commit
http://git.buildroot.org/buildroot/commit/?id=066359166fa9407382fd9ce40e002249dbdda9c7

Thanks for reporting!

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-07 13:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-27  9:01 [Buildroot] [Bug 6992] New: Incorrect installation rights on external kernel module makes it unloadable bugzilla at busybox.net
2014-04-29 18:57 ` [Buildroot] [Bug 6992] " bugzilla at busybox.net
2014-05-07 13:09 ` bugzilla at busybox.net

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.