[PATCH] libata: clean up ZPODD when a port is detached

[PATCH] libata: clean up ZPODD when a port is detached

[Levente Kurusa]

When a ZPODD device is unbound via sysfs, the ACPI notify handler
is not removed. This causes panics as observed in Bug #74601. The
panic only happens when the wake happens from outside the kernel
(i.e. inserting a media or pressing a button). Add a loop to
ata_port_detach which loops through the port's devices and checks
if zpodd is enabled, if so call zpodd_exit.

Cc: stable@vger.kernel.org
Reviewed-by: Aaron Lu <aaron.lu@intel.com>
Signed-off-by: Levente Kurusa <levex@linux.com>
---
 drivers/ata/libata-core.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 943cc8b..ea83828 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -6314,6 +6314,8 @@ int ata_host_activate(struct ata_host *host, int irq,
 static void ata_port_detach(struct ata_port *ap)
 {
 	unsigned long flags;
+	struct ata_link *link;
+	struct ata_device *dev;
 
 	if (!ap->ops->error_handler)
 		goto skip_eh;
@@ -6333,6 +6335,13 @@ static void ata_port_detach(struct ata_port *ap)
 	cancel_delayed_work_sync(&ap->hotplug_task);
 
  skip_eh:
+	/* clean up zpodd on port removal */
+	ata_for_each_link(link, ap, HOST_FIRST) {
+		ata_for_each_dev(dev, link, ALL) {
+			if (zpodd_dev_enabled(dev))
+				zpodd_exit(dev);
+		}
+	}
 	if (ap->pmp_link) {
 		int i;
 		for (i = 0; i < SATA_PMP_MAX_PORTS; i++)
-- 
1.8.3.1

Re: [PATCH] libata: clean up ZPODD when a port is detached

[Tejun Heo]

On Tue, May 06, 2014 at 03:57:48PM +0200, Levente Kurusa wrote:
> When a ZPODD device is unbound via sysfs, the ACPI notify handler
> is not removed. This causes panics as observed in Bug #74601. The
> panic only happens when the wake happens from outside the kernel
> (i.e. inserting a media or pressing a button). Add a loop to
> ata_port_detach which loops through the port's devices and checks
> if zpodd is enabled, if so call zpodd_exit.
> 
> Cc: stable@vger.kernel.org
> Reviewed-by: Aaron Lu <aaron.lu@intel.com>
> Signed-off-by: Levente Kurusa <levex@linux.com>

Applied to libata/for-3.15-fixes.

Thanks.

-- 
tejun