* [PATCH v2 0/4] Support additional regulators on BCM590xx
@ 2014-04-23 23:21 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-23 23:21 UTC (permalink / raw)
To: Devicetree List, Lee Jones, Samuel Ortiz, Liam Girdwood, Mark Brown
Cc: Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
Changes since v1:
- Fix a several commit log typos and capitalization
- Drop use of addmap[0|1] in favor of i2c_[pri|sec]
- Replace regmap[0|1] with regmap_[pri|sec]
This series enables support for 7 additional regulators on the BCM59056
PMU. These regulators are accessed via a secondary I2C slave address.
The MFD driver exposes an additional regmap descriptor for the additional
address space and the regulator implements support for GPLDO1-6 and VBUS
regulators.
Matt Porter (4):
mfd: bcm590xx: update binding with additional BCM59056 regulators
mfd: bcm590xx: add support for secondary I2C slave address
regulator: bcm590xx: add support for regulators on secondary I2C slave
ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
Documentation/devicetree/bindings/mfd/bcm590xx.txt | 4 +-
arch/arm/boot/dts/bcm59056.dtsi | 21 +++++
drivers/mfd/bcm590xx.c | 60 ++++++++++----
drivers/regulator/bcm590xx-regulator.c | 92 +++++++++++++++++++---
include/linux/mfd/bcm590xx.h | 9 ++-
5 files changed, 158 insertions(+), 28 deletions(-)
--
1.8.4
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 0/4] Support additional regulators on BCM590xx
@ 2014-04-23 23:21 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-23 23:21 UTC (permalink / raw)
To: Devicetree List, Lee Jones, Samuel Ortiz, Liam Girdwood, Mark Brown
Cc: Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
Changes since v1:
- Fix a several commit log typos and capitalization
- Drop use of addmap[0|1] in favor of i2c_[pri|sec]
- Replace regmap[0|1] with regmap_[pri|sec]
This series enables support for 7 additional regulators on the BCM59056
PMU. These regulators are accessed via a secondary I2C slave address.
The MFD driver exposes an additional regmap descriptor for the additional
address space and the regulator implements support for GPLDO1-6 and VBUS
regulators.
Matt Porter (4):
mfd: bcm590xx: update binding with additional BCM59056 regulators
mfd: bcm590xx: add support for secondary I2C slave address
regulator: bcm590xx: add support for regulators on secondary I2C slave
ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
Documentation/devicetree/bindings/mfd/bcm590xx.txt | 4 +-
arch/arm/boot/dts/bcm59056.dtsi | 21 +++++
drivers/mfd/bcm590xx.c | 60 ++++++++++----
drivers/regulator/bcm590xx-regulator.c | 92 +++++++++++++++++++---
include/linux/mfd/bcm590xx.h | 9 ++-
5 files changed, 158 insertions(+), 28 deletions(-)
--
1.8.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 0/4] Support additional regulators on BCM590xx
@ 2014-04-23 23:21 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-23 23:21 UTC (permalink / raw)
To: linux-arm-kernel
Changes since v1:
- Fix a several commit log typos and capitalization
- Drop use of addmap[0|1] in favor of i2c_[pri|sec]
- Replace regmap[0|1] with regmap_[pri|sec]
This series enables support for 7 additional regulators on the BCM59056
PMU. These regulators are accessed via a secondary I2C slave address.
The MFD driver exposes an additional regmap descriptor for the additional
address space and the regulator implements support for GPLDO1-6 and VBUS
regulators.
Matt Porter (4):
mfd: bcm590xx: update binding with additional BCM59056 regulators
mfd: bcm590xx: add support for secondary I2C slave address
regulator: bcm590xx: add support for regulators on secondary I2C slave
ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
Documentation/devicetree/bindings/mfd/bcm590xx.txt | 4 +-
arch/arm/boot/dts/bcm59056.dtsi | 21 +++++
drivers/mfd/bcm590xx.c | 60 ++++++++++----
drivers/regulator/bcm590xx-regulator.c | 92 +++++++++++++++++++---
include/linux/mfd/bcm590xx.h | 9 ++-
5 files changed, 158 insertions(+), 28 deletions(-)
--
1.8.4
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 1/4] mfd: bcm590xx: update binding with additional BCM59056 regulators
2014-04-23 23:21 ` Matt Porter
@ 2014-04-23 23:21 ` Matt Porter
-1 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-23 23:21 UTC (permalink / raw)
To: Devicetree List, Lee Jones, Samuel Ortiz, Liam Girdwood, Mark Brown
Cc: Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
The BCM59056 supports GPLDO1-6 and VBUS regulators in a secondary
I2C slave address space. Add these regulators to the list of valid
regulator node names for BCM59056.
Signed-off-by: Matt Porter <mporter@linaro.org>
---
Documentation/devicetree/bindings/mfd/bcm590xx.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/bcm590xx.txt b/Documentation/devicetree/bindings/mfd/bcm590xx.txt
index 1fe30e2..be51a15 100644
--- a/Documentation/devicetree/bindings/mfd/bcm590xx.txt
+++ b/Documentation/devicetree/bindings/mfd/bcm590xx.txt
@@ -19,7 +19,9 @@ Optional child nodes:
The valid regulator node names for BCM59056 are:
rfldo, camldo1, camldo2, simldo1, simldo2, sdldo, sdxldo,
mmcldo1, mmcldo2, audldo, micldo, usbldo, vibldo,
- csr, iosr1, iosr2, msr, sdsr1, sdsr2, vsr
+ csr, iosr1, iosr2, msr, sdsr1, sdsr2, vsr,
+ gpldo1, gpldo2, gpldo3, gpldo4, gpldo5, gpldo6,
+ vbus
Example:
pmu: bcm59056@8 {
--
1.8.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [PATCH v2 1/4] mfd: bcm590xx: update binding with additional BCM59056 regulators
@ 2014-04-23 23:21 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-23 23:21 UTC (permalink / raw)
To: linux-arm-kernel
The BCM59056 supports GPLDO1-6 and VBUS regulators in a secondary
I2C slave address space. Add these regulators to the list of valid
regulator node names for BCM59056.
Signed-off-by: Matt Porter <mporter@linaro.org>
---
Documentation/devicetree/bindings/mfd/bcm590xx.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/bcm590xx.txt b/Documentation/devicetree/bindings/mfd/bcm590xx.txt
index 1fe30e2..be51a15 100644
--- a/Documentation/devicetree/bindings/mfd/bcm590xx.txt
+++ b/Documentation/devicetree/bindings/mfd/bcm590xx.txt
@@ -19,7 +19,9 @@ Optional child nodes:
The valid regulator node names for BCM59056 are:
rfldo, camldo1, camldo2, simldo1, simldo2, sdldo, sdxldo,
mmcldo1, mmcldo2, audldo, micldo, usbldo, vibldo,
- csr, iosr1, iosr2, msr, sdsr1, sdsr2, vsr
+ csr, iosr1, iosr2, msr, sdsr1, sdsr2, vsr,
+ gpldo1, gpldo2, gpldo3, gpldo4, gpldo5, gpldo6,
+ vbus
Example:
pmu: bcm59056 at 8 {
--
1.8.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
2014-04-23 23:21 ` Matt Porter
@ 2014-04-23 23:21 ` Matt Porter
-1 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-23 23:21 UTC (permalink / raw)
To: Devicetree List, Lee Jones, Samuel Ortiz, Liam Girdwood, Mark Brown
Cc: Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
BCM590xx utilizes a secondary I2C slave address to access additional
register space. Add support for the secondary address space by
instantiating a dummy I2C device with the appropriate secondary
I2C slave address. Also expose a secondary regmap register space so
that MFD drivers can access this secondary i2c slave address space.
Signed-off-by: Matt Porter <mporter@linaro.org>
---
drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
include/linux/mfd/bcm590xx.h | 9 ++++---
2 files changed, 52 insertions(+), 17 deletions(-)
diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index e9a33c7..43cba1a 100644
--- a/drivers/mfd/bcm590xx.c
+++ b/drivers/mfd/bcm590xx.c
@@ -28,39 +28,71 @@ static const struct mfd_cell bcm590xx_devs[] = {
},
};
-static const struct regmap_config bcm590xx_regmap_config = {
+static const struct regmap_config bcm590xx_regmap_config_pri = {
.reg_bits = 8,
.val_bits = 8,
- .max_register = BCM590XX_MAX_REGISTER,
+ .max_register = BCM590XX_MAX_REGISTER_PRI,
.cache_type = REGCACHE_RBTREE,
};
-static int bcm590xx_i2c_probe(struct i2c_client *i2c,
+static const struct regmap_config bcm590xx_regmap_config_sec = {
+ .reg_bits = 8,
+ .val_bits = 8,
+ .max_register = BCM590XX_MAX_REGISTER_SEC,
+ .cache_type = REGCACHE_RBTREE,
+};
+
+static int bcm590xx_i2c_probe(struct i2c_client *i2c_pri,
const struct i2c_device_id *id)
{
struct bcm590xx *bcm590xx;
int ret;
- bcm590xx = devm_kzalloc(&i2c->dev, sizeof(*bcm590xx), GFP_KERNEL);
+ bcm590xx = devm_kzalloc(&i2c_pri->dev, sizeof(*bcm590xx), GFP_KERNEL);
if (!bcm590xx)
return -ENOMEM;
- i2c_set_clientdata(i2c, bcm590xx);
- bcm590xx->dev = &i2c->dev;
- bcm590xx->i2c_client = i2c;
+ i2c_set_clientdata(i2c_pri, bcm590xx);
+ bcm590xx->dev = &i2c_pri->dev;
+ bcm590xx->i2c_pri = i2c_pri;
- bcm590xx->regmap = devm_regmap_init_i2c(i2c, &bcm590xx_regmap_config);
- if (IS_ERR(bcm590xx->regmap)) {
- ret = PTR_ERR(bcm590xx->regmap);
- dev_err(&i2c->dev, "regmap initialization failed: %d\n", ret);
+ bcm590xx->regmap_pri = devm_regmap_init_i2c(i2c_pri,
+ &bcm590xx_regmap_config_pri);
+ if (IS_ERR(bcm590xx->regmap_pri)) {
+ ret = PTR_ERR(bcm590xx->regmap_pri);
+ dev_err(&i2c_pri->dev, "primary regmap init failed: %d\n", ret);
return ret;
}
- ret = mfd_add_devices(&i2c->dev, -1, bcm590xx_devs,
+ /* Secondary I2C slave address is the base address with A(2) asserted */
+ bcm590xx->i2c_sec = i2c_new_dummy(i2c_pri->adapter,
+ i2c_pri->addr | BIT(2));
+ if (IS_ERR_OR_NULL(bcm590xx->i2c_sec)) {
+ dev_err(&i2c_pri->dev, "failed to add secondary I2C device\n");
+ return -ENODEV;
+ }
+ i2c_set_clientdata(bcm590xx->i2c_sec, bcm590xx);
+
+ bcm590xx->regmap_sec = devm_regmap_init_i2c(bcm590xx->i2c_sec,
+ &bcm590xx_regmap_config_sec);
+ if (IS_ERR(bcm590xx->regmap_sec)) {
+ ret = PTR_ERR(bcm590xx->regmap_sec);
+ dev_err(&bcm590xx->i2c_sec->dev,
+ "secondary regmap init failed: %d\n", ret);
+ goto err;
+ }
+
+ ret = mfd_add_devices(&i2c_pri->dev, -1, bcm590xx_devs,
ARRAY_SIZE(bcm590xx_devs), NULL, 0, NULL);
- if (ret < 0)
- dev_err(&i2c->dev, "failed to add sub-devices: %d\n", ret);
+ if (ret < 0) {
+ dev_err(&i2c_pri->dev, "failed to add sub-devices: %d\n", ret);
+ goto err;
+ }
+
+ return 0;
+err:
+ i2c_unregister_device(bcm590xx->i2c_sec);
return ret;
}
diff --git a/include/linux/mfd/bcm590xx.h b/include/linux/mfd/bcm590xx.h
index 434df2d..267aede 100644
--- a/include/linux/mfd/bcm590xx.h
+++ b/include/linux/mfd/bcm590xx.h
@@ -19,12 +19,15 @@
#include <linux/regmap.h>
/* max register address */
-#define BCM590XX_MAX_REGISTER 0xe7
+#define BCM590XX_MAX_REGISTER_PRI 0xe7
+#define BCM590XX_MAX_REGISTER_SEC 0xf0
struct bcm590xx {
struct device *dev;
- struct i2c_client *i2c_client;
- struct regmap *regmap;
+ struct i2c_client *i2c_pri;
+ struct i2c_client *i2c_sec;
+ struct regmap *regmap_pri;
+ struct regmap *regmap_sec;
unsigned int id;
};
--
1.8.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-04-23 23:21 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-23 23:21 UTC (permalink / raw)
To: linux-arm-kernel
BCM590xx utilizes a secondary I2C slave address to access additional
register space. Add support for the secondary address space by
instantiating a dummy I2C device with the appropriate secondary
I2C slave address. Also expose a secondary regmap register space so
that MFD drivers can access this secondary i2c slave address space.
Signed-off-by: Matt Porter <mporter@linaro.org>
---
drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
include/linux/mfd/bcm590xx.h | 9 ++++---
2 files changed, 52 insertions(+), 17 deletions(-)
diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index e9a33c7..43cba1a 100644
--- a/drivers/mfd/bcm590xx.c
+++ b/drivers/mfd/bcm590xx.c
@@ -28,39 +28,71 @@ static const struct mfd_cell bcm590xx_devs[] = {
},
};
-static const struct regmap_config bcm590xx_regmap_config = {
+static const struct regmap_config bcm590xx_regmap_config_pri = {
.reg_bits = 8,
.val_bits = 8,
- .max_register = BCM590XX_MAX_REGISTER,
+ .max_register = BCM590XX_MAX_REGISTER_PRI,
.cache_type = REGCACHE_RBTREE,
};
-static int bcm590xx_i2c_probe(struct i2c_client *i2c,
+static const struct regmap_config bcm590xx_regmap_config_sec = {
+ .reg_bits = 8,
+ .val_bits = 8,
+ .max_register = BCM590XX_MAX_REGISTER_SEC,
+ .cache_type = REGCACHE_RBTREE,
+};
+
+static int bcm590xx_i2c_probe(struct i2c_client *i2c_pri,
const struct i2c_device_id *id)
{
struct bcm590xx *bcm590xx;
int ret;
- bcm590xx = devm_kzalloc(&i2c->dev, sizeof(*bcm590xx), GFP_KERNEL);
+ bcm590xx = devm_kzalloc(&i2c_pri->dev, sizeof(*bcm590xx), GFP_KERNEL);
if (!bcm590xx)
return -ENOMEM;
- i2c_set_clientdata(i2c, bcm590xx);
- bcm590xx->dev = &i2c->dev;
- bcm590xx->i2c_client = i2c;
+ i2c_set_clientdata(i2c_pri, bcm590xx);
+ bcm590xx->dev = &i2c_pri->dev;
+ bcm590xx->i2c_pri = i2c_pri;
- bcm590xx->regmap = devm_regmap_init_i2c(i2c, &bcm590xx_regmap_config);
- if (IS_ERR(bcm590xx->regmap)) {
- ret = PTR_ERR(bcm590xx->regmap);
- dev_err(&i2c->dev, "regmap initialization failed: %d\n", ret);
+ bcm590xx->regmap_pri = devm_regmap_init_i2c(i2c_pri,
+ &bcm590xx_regmap_config_pri);
+ if (IS_ERR(bcm590xx->regmap_pri)) {
+ ret = PTR_ERR(bcm590xx->regmap_pri);
+ dev_err(&i2c_pri->dev, "primary regmap init failed: %d\n", ret);
return ret;
}
- ret = mfd_add_devices(&i2c->dev, -1, bcm590xx_devs,
+ /* Secondary I2C slave address is the base address with A(2) asserted */
+ bcm590xx->i2c_sec = i2c_new_dummy(i2c_pri->adapter,
+ i2c_pri->addr | BIT(2));
+ if (IS_ERR_OR_NULL(bcm590xx->i2c_sec)) {
+ dev_err(&i2c_pri->dev, "failed to add secondary I2C device\n");
+ return -ENODEV;
+ }
+ i2c_set_clientdata(bcm590xx->i2c_sec, bcm590xx);
+
+ bcm590xx->regmap_sec = devm_regmap_init_i2c(bcm590xx->i2c_sec,
+ &bcm590xx_regmap_config_sec);
+ if (IS_ERR(bcm590xx->regmap_sec)) {
+ ret = PTR_ERR(bcm590xx->regmap_sec);
+ dev_err(&bcm590xx->i2c_sec->dev,
+ "secondary regmap init failed: %d\n", ret);
+ goto err;
+ }
+
+ ret = mfd_add_devices(&i2c_pri->dev, -1, bcm590xx_devs,
ARRAY_SIZE(bcm590xx_devs), NULL, 0, NULL);
- if (ret < 0)
- dev_err(&i2c->dev, "failed to add sub-devices: %d\n", ret);
+ if (ret < 0) {
+ dev_err(&i2c_pri->dev, "failed to add sub-devices: %d\n", ret);
+ goto err;
+ }
+
+ return 0;
+err:
+ i2c_unregister_device(bcm590xx->i2c_sec);
return ret;
}
diff --git a/include/linux/mfd/bcm590xx.h b/include/linux/mfd/bcm590xx.h
index 434df2d..267aede 100644
--- a/include/linux/mfd/bcm590xx.h
+++ b/include/linux/mfd/bcm590xx.h
@@ -19,12 +19,15 @@
#include <linux/regmap.h>
/* max register address */
-#define BCM590XX_MAX_REGISTER 0xe7
+#define BCM590XX_MAX_REGISTER_PRI 0xe7
+#define BCM590XX_MAX_REGISTER_SEC 0xf0
struct bcm590xx {
struct device *dev;
- struct i2c_client *i2c_client;
- struct regmap *regmap;
+ struct i2c_client *i2c_pri;
+ struct i2c_client *i2c_sec;
+ struct regmap *regmap_pri;
+ struct regmap *regmap_sec;
unsigned int id;
};
--
1.8.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [PATCH v2 3/4] regulator: bcm590xx: add support for regulators on secondary I2C slave
@ 2014-04-23 23:21 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-23 23:21 UTC (permalink / raw)
To: Devicetree List, Lee Jones, Samuel Ortiz, Liam Girdwood, Mark Brown
Cc: Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
The bcm590xx MFD driver now exposes a secondary regmap descriptor
making the registers for regulators on the secondary I2C slave address
available. Add support for GPLDO1-6 and VBUS regulators found within
this register range.
Signed-off-by: Matt Porter <mporter@linaro.org>
Acked-by: Mark Brown <broonie@linaro.org>
---
drivers/regulator/bcm590xx-regulator.c | 92 ++++++++++++++++++++++++++++++----
1 file changed, 82 insertions(+), 10 deletions(-)
diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c
index c3750c5..57544e2 100644
--- a/drivers/regulator/bcm590xx-regulator.c
+++ b/drivers/regulator/bcm590xx-regulator.c
@@ -22,7 +22,7 @@
#include <linux/regulator/of_regulator.h>
#include <linux/slab.h>
-/* Register defs */
+/* I2C slave 0 registers */
#define BCM590XX_RFLDOPMCTRL1 0x60
#define BCM590XX_IOSR1PMCTRL1 0x7a
#define BCM590XX_IOSR2PMCTRL1 0x7c
@@ -31,13 +31,34 @@
#define BCM590XX_SDSR2PMCTRL1 0x86
#define BCM590XX_MSRPMCTRL1 0x8a
#define BCM590XX_VSRPMCTRL1 0x8e
-#define BCM590XX_REG_ENABLE BIT(7)
-
#define BCM590XX_RFLDOCTRL 0x96
#define BCM590XX_CSRVOUT1 0xc0
+
+/* I2C slave 1 registers */
+#define BCM590XX_GPLDO5PMCTRL1 0x16
+#define BCM590XX_GPLDO6PMCTRL1 0x18
+#define BCM590XX_GPLDO1CTRL 0x1a
+#define BCM590XX_GPLDO2CTRL 0x1b
+#define BCM590XX_GPLDO3CTRL 0x1c
+#define BCM590XX_GPLDO4CTRL 0x1d
+#define BCM590XX_GPLDO5CTRL 0x1e
+#define BCM590XX_GPLDO6CTRL 0x1f
+#define BCM590XX_OTG_CTRL 0x40
+#define BCM590XX_GPLDO1PMCTRL1 0x57
+#define BCM590XX_GPLDO2PMCTRL1 0x59
+#define BCM590XX_GPLDO3PMCTRL1 0x5b
+#define BCM590XX_GPLDO4PMCTRL1 0x5d
+
+#define BCM590XX_REG_ENABLE BIT(7)
+#define BCM590XX_VBUS_ENABLE BIT(2)
#define BCM590XX_LDO_VSEL_MASK GENMASK(5, 3)
#define BCM590XX_SR_VSEL_MASK GENMASK(5, 0)
+/*
+ * RFLDO to VSR regulators are
+ * accessed via I2C slave 0
+ */
+
/* LDO regulator IDs */
#define BCM590XX_REG_RFLDO 0
#define BCM590XX_REG_CAMLDO1 1
@@ -62,9 +83,25 @@
#define BCM590XX_REG_SDSR2 18
#define BCM590XX_REG_VSR 19
-#define BCM590XX_NUM_REGS 20
+/*
+ * GPLDO1 to VBUS regulators are
+ * accessed via I2C slave 1
+ */
+
+#define BCM590XX_REG_GPLDO1 20
+#define BCM590XX_REG_GPLDO2 21
+#define BCM590XX_REG_GPLDO3 22
+#define BCM590XX_REG_GPLDO4 23
+#define BCM590XX_REG_GPLDO5 24
+#define BCM590XX_REG_GPLDO6 25
+#define BCM590XX_REG_VBUS 26
+
+#define BCM590XX_NUM_REGS 27
#define BCM590XX_REG_IS_LDO(n) (n < BCM590XX_REG_CSR)
+#define BCM590XX_REG_IS_GPLDO(n) \
+ ((n > BCM590XX_REG_VSR) && (n < BCM590XX_REG_VBUS))
+#define BCM590XX_REG_IS_VBUS(n) (n == BCM590XX_REG_VBUS)
struct bcm590xx_board {
struct regulator_init_data *bcm590xx_pmu_init_data[BCM590XX_NUM_REGS];
@@ -149,6 +186,12 @@ static struct bcm590xx_info bcm590xx_regs[] = {
BCM590XX_REG_RANGES(sdsr1, dcdc_sdsr1_ranges),
BCM590XX_REG_RANGES(sdsr2, dcdc_iosr1_ranges),
BCM590XX_REG_RANGES(vsr, dcdc_iosr1_ranges),
+ BCM590XX_REG_TABLE(gpldo1, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo2, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo3, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo4, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo5, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo6, ldo_a_table),
};
struct bcm590xx_reg {
@@ -161,6 +204,8 @@ static int bcm590xx_get_vsel_register(int id)
{
if (BCM590XX_REG_IS_LDO(id))
return BCM590XX_RFLDOCTRL + id;
+ else if (BCM590XX_REG_IS_GPLDO(id))
+ return BCM590XX_GPLDO1CTRL + id;
else
return BCM590XX_CSRVOUT1 + (id - BCM590XX_REG_CSR) * 3;
}
@@ -171,6 +216,8 @@ static int bcm590xx_get_enable_register(int id)
if (BCM590XX_REG_IS_LDO(id))
reg = BCM590XX_RFLDOPMCTRL1 + id * 2;
+ else if (BCM590XX_REG_IS_GPLDO(id))
+ reg = BCM590XX_GPLDO1PMCTRL1 + id * 2;
else
switch (id) {
case BCM590XX_REG_CSR:
@@ -191,8 +238,11 @@ static int bcm590xx_get_enable_register(int id)
case BCM590XX_REG_SDSR2:
reg = BCM590XX_SDSR2PMCTRL1;
break;
+ case BCM590XX_REG_VBUS:
+ reg = BCM590XX_OTG_CTRL;
};
+
return reg;
}
@@ -216,6 +266,12 @@ static struct regulator_ops bcm590xx_ops_dcdc = {
.map_voltage = regulator_map_voltage_linear_range,
};
+static struct regulator_ops bcm590xx_ops_vbus = {
+ .is_enabled = regulator_is_enabled_regmap,
+ .enable = regulator_enable_regmap,
+ .disable = regulator_disable_regmap,
+};
+
#define BCM590XX_MATCH(_name, _id) \
{ \
.name = #_name, \
@@ -243,6 +299,13 @@ static struct of_regulator_match bcm590xx_matches[] = {
BCM590XX_MATCH(sdsr1, SDSR1),
BCM590XX_MATCH(sdsr2, SDSR2),
BCM590XX_MATCH(vsr, VSR),
+ BCM590XX_MATCH(gpldo1, GPLDO1),
+ BCM590XX_MATCH(gpldo2, GPLDO2),
+ BCM590XX_MATCH(gpldo3, GPLDO3),
+ BCM590XX_MATCH(gpldo4, GPLDO4),
+ BCM590XX_MATCH(gpldo5, GPLDO5),
+ BCM590XX_MATCH(gpldo6, GPLDO6),
+ BCM590XX_MATCH(vbus, VBUS),
};
static struct bcm590xx_board *bcm590xx_parse_dt_reg_data(
@@ -353,17 +416,23 @@ static int bcm590xx_probe(struct platform_device *pdev)
pmu->desc[i].linear_ranges = info->linear_ranges;
pmu->desc[i].n_linear_ranges = info->n_linear_ranges;
- if (BCM590XX_REG_IS_LDO(i)) {
+ if ((BCM590XX_REG_IS_LDO(i)) || (BCM590XX_REG_IS_GPLDO(i))) {
pmu->desc[i].ops = &bcm590xx_ops_ldo;
pmu->desc[i].vsel_mask = BCM590XX_LDO_VSEL_MASK;
- } else {
+ } else if (BCM590XX_REG_IS_VBUS(i))
+ pmu->desc[i].ops = &bcm590xx_ops_vbus;
+ else {
pmu->desc[i].ops = &bcm590xx_ops_dcdc;
pmu->desc[i].vsel_mask = BCM590XX_SR_VSEL_MASK;
}
- pmu->desc[i].vsel_reg = bcm590xx_get_vsel_register(i);
- pmu->desc[i].enable_is_inverted = true;
- pmu->desc[i].enable_mask = BCM590XX_REG_ENABLE;
+ if (BCM590XX_REG_IS_VBUS(i))
+ pmu->desc[i].enable_mask = BCM590XX_VBUS_ENABLE;
+ else {
+ pmu->desc[i].vsel_reg = bcm590xx_get_vsel_register(i);
+ pmu->desc[i].enable_is_inverted = true;
+ pmu->desc[i].enable_mask = BCM590XX_REG_ENABLE;
+ }
pmu->desc[i].enable_reg = bcm590xx_get_enable_register(i);
pmu->desc[i].type = REGULATOR_VOLTAGE;
pmu->desc[i].owner = THIS_MODULE;
@@ -371,7 +440,10 @@ static int bcm590xx_probe(struct platform_device *pdev)
config.dev = bcm590xx->dev;
config.init_data = reg_data;
config.driver_data = pmu;
- config.regmap = bcm590xx->regmap;
+ if (BCM590XX_REG_IS_GPLDO(i) || BCM590XX_REG_IS_VBUS(i))
+ config.regmap = bcm590xx->regmap_sec;
+ else
+ config.regmap = bcm590xx->regmap_pri;
if (bcm590xx_reg_matches)
config.of_node = bcm590xx_reg_matches[i].of_node;
--
1.8.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [PATCH v2 3/4] regulator: bcm590xx: add support for regulators on secondary I2C slave
@ 2014-04-23 23:21 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-23 23:21 UTC (permalink / raw)
To: Devicetree List, Lee Jones, Samuel Ortiz, Liam Girdwood, Mark Brown
Cc: Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
The bcm590xx MFD driver now exposes a secondary regmap descriptor
making the registers for regulators on the secondary I2C slave address
available. Add support for GPLDO1-6 and VBUS regulators found within
this register range.
Signed-off-by: Matt Porter <mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Acked-by: Mark Brown <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
drivers/regulator/bcm590xx-regulator.c | 92 ++++++++++++++++++++++++++++++----
1 file changed, 82 insertions(+), 10 deletions(-)
diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c
index c3750c5..57544e2 100644
--- a/drivers/regulator/bcm590xx-regulator.c
+++ b/drivers/regulator/bcm590xx-regulator.c
@@ -22,7 +22,7 @@
#include <linux/regulator/of_regulator.h>
#include <linux/slab.h>
-/* Register defs */
+/* I2C slave 0 registers */
#define BCM590XX_RFLDOPMCTRL1 0x60
#define BCM590XX_IOSR1PMCTRL1 0x7a
#define BCM590XX_IOSR2PMCTRL1 0x7c
@@ -31,13 +31,34 @@
#define BCM590XX_SDSR2PMCTRL1 0x86
#define BCM590XX_MSRPMCTRL1 0x8a
#define BCM590XX_VSRPMCTRL1 0x8e
-#define BCM590XX_REG_ENABLE BIT(7)
-
#define BCM590XX_RFLDOCTRL 0x96
#define BCM590XX_CSRVOUT1 0xc0
+
+/* I2C slave 1 registers */
+#define BCM590XX_GPLDO5PMCTRL1 0x16
+#define BCM590XX_GPLDO6PMCTRL1 0x18
+#define BCM590XX_GPLDO1CTRL 0x1a
+#define BCM590XX_GPLDO2CTRL 0x1b
+#define BCM590XX_GPLDO3CTRL 0x1c
+#define BCM590XX_GPLDO4CTRL 0x1d
+#define BCM590XX_GPLDO5CTRL 0x1e
+#define BCM590XX_GPLDO6CTRL 0x1f
+#define BCM590XX_OTG_CTRL 0x40
+#define BCM590XX_GPLDO1PMCTRL1 0x57
+#define BCM590XX_GPLDO2PMCTRL1 0x59
+#define BCM590XX_GPLDO3PMCTRL1 0x5b
+#define BCM590XX_GPLDO4PMCTRL1 0x5d
+
+#define BCM590XX_REG_ENABLE BIT(7)
+#define BCM590XX_VBUS_ENABLE BIT(2)
#define BCM590XX_LDO_VSEL_MASK GENMASK(5, 3)
#define BCM590XX_SR_VSEL_MASK GENMASK(5, 0)
+/*
+ * RFLDO to VSR regulators are
+ * accessed via I2C slave 0
+ */
+
/* LDO regulator IDs */
#define BCM590XX_REG_RFLDO 0
#define BCM590XX_REG_CAMLDO1 1
@@ -62,9 +83,25 @@
#define BCM590XX_REG_SDSR2 18
#define BCM590XX_REG_VSR 19
-#define BCM590XX_NUM_REGS 20
+/*
+ * GPLDO1 to VBUS regulators are
+ * accessed via I2C slave 1
+ */
+
+#define BCM590XX_REG_GPLDO1 20
+#define BCM590XX_REG_GPLDO2 21
+#define BCM590XX_REG_GPLDO3 22
+#define BCM590XX_REG_GPLDO4 23
+#define BCM590XX_REG_GPLDO5 24
+#define BCM590XX_REG_GPLDO6 25
+#define BCM590XX_REG_VBUS 26
+
+#define BCM590XX_NUM_REGS 27
#define BCM590XX_REG_IS_LDO(n) (n < BCM590XX_REG_CSR)
+#define BCM590XX_REG_IS_GPLDO(n) \
+ ((n > BCM590XX_REG_VSR) && (n < BCM590XX_REG_VBUS))
+#define BCM590XX_REG_IS_VBUS(n) (n == BCM590XX_REG_VBUS)
struct bcm590xx_board {
struct regulator_init_data *bcm590xx_pmu_init_data[BCM590XX_NUM_REGS];
@@ -149,6 +186,12 @@ static struct bcm590xx_info bcm590xx_regs[] = {
BCM590XX_REG_RANGES(sdsr1, dcdc_sdsr1_ranges),
BCM590XX_REG_RANGES(sdsr2, dcdc_iosr1_ranges),
BCM590XX_REG_RANGES(vsr, dcdc_iosr1_ranges),
+ BCM590XX_REG_TABLE(gpldo1, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo2, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo3, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo4, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo5, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo6, ldo_a_table),
};
struct bcm590xx_reg {
@@ -161,6 +204,8 @@ static int bcm590xx_get_vsel_register(int id)
{
if (BCM590XX_REG_IS_LDO(id))
return BCM590XX_RFLDOCTRL + id;
+ else if (BCM590XX_REG_IS_GPLDO(id))
+ return BCM590XX_GPLDO1CTRL + id;
else
return BCM590XX_CSRVOUT1 + (id - BCM590XX_REG_CSR) * 3;
}
@@ -171,6 +216,8 @@ static int bcm590xx_get_enable_register(int id)
if (BCM590XX_REG_IS_LDO(id))
reg = BCM590XX_RFLDOPMCTRL1 + id * 2;
+ else if (BCM590XX_REG_IS_GPLDO(id))
+ reg = BCM590XX_GPLDO1PMCTRL1 + id * 2;
else
switch (id) {
case BCM590XX_REG_CSR:
@@ -191,8 +238,11 @@ static int bcm590xx_get_enable_register(int id)
case BCM590XX_REG_SDSR2:
reg = BCM590XX_SDSR2PMCTRL1;
break;
+ case BCM590XX_REG_VBUS:
+ reg = BCM590XX_OTG_CTRL;
};
+
return reg;
}
@@ -216,6 +266,12 @@ static struct regulator_ops bcm590xx_ops_dcdc = {
.map_voltage = regulator_map_voltage_linear_range,
};
+static struct regulator_ops bcm590xx_ops_vbus = {
+ .is_enabled = regulator_is_enabled_regmap,
+ .enable = regulator_enable_regmap,
+ .disable = regulator_disable_regmap,
+};
+
#define BCM590XX_MATCH(_name, _id) \
{ \
.name = #_name, \
@@ -243,6 +299,13 @@ static struct of_regulator_match bcm590xx_matches[] = {
BCM590XX_MATCH(sdsr1, SDSR1),
BCM590XX_MATCH(sdsr2, SDSR2),
BCM590XX_MATCH(vsr, VSR),
+ BCM590XX_MATCH(gpldo1, GPLDO1),
+ BCM590XX_MATCH(gpldo2, GPLDO2),
+ BCM590XX_MATCH(gpldo3, GPLDO3),
+ BCM590XX_MATCH(gpldo4, GPLDO4),
+ BCM590XX_MATCH(gpldo5, GPLDO5),
+ BCM590XX_MATCH(gpldo6, GPLDO6),
+ BCM590XX_MATCH(vbus, VBUS),
};
static struct bcm590xx_board *bcm590xx_parse_dt_reg_data(
@@ -353,17 +416,23 @@ static int bcm590xx_probe(struct platform_device *pdev)
pmu->desc[i].linear_ranges = info->linear_ranges;
pmu->desc[i].n_linear_ranges = info->n_linear_ranges;
- if (BCM590XX_REG_IS_LDO(i)) {
+ if ((BCM590XX_REG_IS_LDO(i)) || (BCM590XX_REG_IS_GPLDO(i))) {
pmu->desc[i].ops = &bcm590xx_ops_ldo;
pmu->desc[i].vsel_mask = BCM590XX_LDO_VSEL_MASK;
- } else {
+ } else if (BCM590XX_REG_IS_VBUS(i))
+ pmu->desc[i].ops = &bcm590xx_ops_vbus;
+ else {
pmu->desc[i].ops = &bcm590xx_ops_dcdc;
pmu->desc[i].vsel_mask = BCM590XX_SR_VSEL_MASK;
}
- pmu->desc[i].vsel_reg = bcm590xx_get_vsel_register(i);
- pmu->desc[i].enable_is_inverted = true;
- pmu->desc[i].enable_mask = BCM590XX_REG_ENABLE;
+ if (BCM590XX_REG_IS_VBUS(i))
+ pmu->desc[i].enable_mask = BCM590XX_VBUS_ENABLE;
+ else {
+ pmu->desc[i].vsel_reg = bcm590xx_get_vsel_register(i);
+ pmu->desc[i].enable_is_inverted = true;
+ pmu->desc[i].enable_mask = BCM590XX_REG_ENABLE;
+ }
pmu->desc[i].enable_reg = bcm590xx_get_enable_register(i);
pmu->desc[i].type = REGULATOR_VOLTAGE;
pmu->desc[i].owner = THIS_MODULE;
@@ -371,7 +440,10 @@ static int bcm590xx_probe(struct platform_device *pdev)
config.dev = bcm590xx->dev;
config.init_data = reg_data;
config.driver_data = pmu;
- config.regmap = bcm590xx->regmap;
+ if (BCM590XX_REG_IS_GPLDO(i) || BCM590XX_REG_IS_VBUS(i))
+ config.regmap = bcm590xx->regmap_sec;
+ else
+ config.regmap = bcm590xx->regmap_pri;
if (bcm590xx_reg_matches)
config.of_node = bcm590xx_reg_matches[i].of_node;
--
1.8.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [PATCH v2 3/4] regulator: bcm590xx: add support for regulators on secondary I2C slave
@ 2014-04-23 23:21 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-23 23:21 UTC (permalink / raw)
To: linux-arm-kernel
The bcm590xx MFD driver now exposes a secondary regmap descriptor
making the registers for regulators on the secondary I2C slave address
available. Add support for GPLDO1-6 and VBUS regulators found within
this register range.
Signed-off-by: Matt Porter <mporter@linaro.org>
Acked-by: Mark Brown <broonie@linaro.org>
---
drivers/regulator/bcm590xx-regulator.c | 92 ++++++++++++++++++++++++++++++----
1 file changed, 82 insertions(+), 10 deletions(-)
diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c
index c3750c5..57544e2 100644
--- a/drivers/regulator/bcm590xx-regulator.c
+++ b/drivers/regulator/bcm590xx-regulator.c
@@ -22,7 +22,7 @@
#include <linux/regulator/of_regulator.h>
#include <linux/slab.h>
-/* Register defs */
+/* I2C slave 0 registers */
#define BCM590XX_RFLDOPMCTRL1 0x60
#define BCM590XX_IOSR1PMCTRL1 0x7a
#define BCM590XX_IOSR2PMCTRL1 0x7c
@@ -31,13 +31,34 @@
#define BCM590XX_SDSR2PMCTRL1 0x86
#define BCM590XX_MSRPMCTRL1 0x8a
#define BCM590XX_VSRPMCTRL1 0x8e
-#define BCM590XX_REG_ENABLE BIT(7)
-
#define BCM590XX_RFLDOCTRL 0x96
#define BCM590XX_CSRVOUT1 0xc0
+
+/* I2C slave 1 registers */
+#define BCM590XX_GPLDO5PMCTRL1 0x16
+#define BCM590XX_GPLDO6PMCTRL1 0x18
+#define BCM590XX_GPLDO1CTRL 0x1a
+#define BCM590XX_GPLDO2CTRL 0x1b
+#define BCM590XX_GPLDO3CTRL 0x1c
+#define BCM590XX_GPLDO4CTRL 0x1d
+#define BCM590XX_GPLDO5CTRL 0x1e
+#define BCM590XX_GPLDO6CTRL 0x1f
+#define BCM590XX_OTG_CTRL 0x40
+#define BCM590XX_GPLDO1PMCTRL1 0x57
+#define BCM590XX_GPLDO2PMCTRL1 0x59
+#define BCM590XX_GPLDO3PMCTRL1 0x5b
+#define BCM590XX_GPLDO4PMCTRL1 0x5d
+
+#define BCM590XX_REG_ENABLE BIT(7)
+#define BCM590XX_VBUS_ENABLE BIT(2)
#define BCM590XX_LDO_VSEL_MASK GENMASK(5, 3)
#define BCM590XX_SR_VSEL_MASK GENMASK(5, 0)
+/*
+ * RFLDO to VSR regulators are
+ * accessed via I2C slave 0
+ */
+
/* LDO regulator IDs */
#define BCM590XX_REG_RFLDO 0
#define BCM590XX_REG_CAMLDO1 1
@@ -62,9 +83,25 @@
#define BCM590XX_REG_SDSR2 18
#define BCM590XX_REG_VSR 19
-#define BCM590XX_NUM_REGS 20
+/*
+ * GPLDO1 to VBUS regulators are
+ * accessed via I2C slave 1
+ */
+
+#define BCM590XX_REG_GPLDO1 20
+#define BCM590XX_REG_GPLDO2 21
+#define BCM590XX_REG_GPLDO3 22
+#define BCM590XX_REG_GPLDO4 23
+#define BCM590XX_REG_GPLDO5 24
+#define BCM590XX_REG_GPLDO6 25
+#define BCM590XX_REG_VBUS 26
+
+#define BCM590XX_NUM_REGS 27
#define BCM590XX_REG_IS_LDO(n) (n < BCM590XX_REG_CSR)
+#define BCM590XX_REG_IS_GPLDO(n) \
+ ((n > BCM590XX_REG_VSR) && (n < BCM590XX_REG_VBUS))
+#define BCM590XX_REG_IS_VBUS(n) (n == BCM590XX_REG_VBUS)
struct bcm590xx_board {
struct regulator_init_data *bcm590xx_pmu_init_data[BCM590XX_NUM_REGS];
@@ -149,6 +186,12 @@ static struct bcm590xx_info bcm590xx_regs[] = {
BCM590XX_REG_RANGES(sdsr1, dcdc_sdsr1_ranges),
BCM590XX_REG_RANGES(sdsr2, dcdc_iosr1_ranges),
BCM590XX_REG_RANGES(vsr, dcdc_iosr1_ranges),
+ BCM590XX_REG_TABLE(gpldo1, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo2, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo3, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo4, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo5, ldo_a_table),
+ BCM590XX_REG_TABLE(gpldo6, ldo_a_table),
};
struct bcm590xx_reg {
@@ -161,6 +204,8 @@ static int bcm590xx_get_vsel_register(int id)
{
if (BCM590XX_REG_IS_LDO(id))
return BCM590XX_RFLDOCTRL + id;
+ else if (BCM590XX_REG_IS_GPLDO(id))
+ return BCM590XX_GPLDO1CTRL + id;
else
return BCM590XX_CSRVOUT1 + (id - BCM590XX_REG_CSR) * 3;
}
@@ -171,6 +216,8 @@ static int bcm590xx_get_enable_register(int id)
if (BCM590XX_REG_IS_LDO(id))
reg = BCM590XX_RFLDOPMCTRL1 + id * 2;
+ else if (BCM590XX_REG_IS_GPLDO(id))
+ reg = BCM590XX_GPLDO1PMCTRL1 + id * 2;
else
switch (id) {
case BCM590XX_REG_CSR:
@@ -191,8 +238,11 @@ static int bcm590xx_get_enable_register(int id)
case BCM590XX_REG_SDSR2:
reg = BCM590XX_SDSR2PMCTRL1;
break;
+ case BCM590XX_REG_VBUS:
+ reg = BCM590XX_OTG_CTRL;
};
+
return reg;
}
@@ -216,6 +266,12 @@ static struct regulator_ops bcm590xx_ops_dcdc = {
.map_voltage = regulator_map_voltage_linear_range,
};
+static struct regulator_ops bcm590xx_ops_vbus = {
+ .is_enabled = regulator_is_enabled_regmap,
+ .enable = regulator_enable_regmap,
+ .disable = regulator_disable_regmap,
+};
+
#define BCM590XX_MATCH(_name, _id) \
{ \
.name = #_name, \
@@ -243,6 +299,13 @@ static struct of_regulator_match bcm590xx_matches[] = {
BCM590XX_MATCH(sdsr1, SDSR1),
BCM590XX_MATCH(sdsr2, SDSR2),
BCM590XX_MATCH(vsr, VSR),
+ BCM590XX_MATCH(gpldo1, GPLDO1),
+ BCM590XX_MATCH(gpldo2, GPLDO2),
+ BCM590XX_MATCH(gpldo3, GPLDO3),
+ BCM590XX_MATCH(gpldo4, GPLDO4),
+ BCM590XX_MATCH(gpldo5, GPLDO5),
+ BCM590XX_MATCH(gpldo6, GPLDO6),
+ BCM590XX_MATCH(vbus, VBUS),
};
static struct bcm590xx_board *bcm590xx_parse_dt_reg_data(
@@ -353,17 +416,23 @@ static int bcm590xx_probe(struct platform_device *pdev)
pmu->desc[i].linear_ranges = info->linear_ranges;
pmu->desc[i].n_linear_ranges = info->n_linear_ranges;
- if (BCM590XX_REG_IS_LDO(i)) {
+ if ((BCM590XX_REG_IS_LDO(i)) || (BCM590XX_REG_IS_GPLDO(i))) {
pmu->desc[i].ops = &bcm590xx_ops_ldo;
pmu->desc[i].vsel_mask = BCM590XX_LDO_VSEL_MASK;
- } else {
+ } else if (BCM590XX_REG_IS_VBUS(i))
+ pmu->desc[i].ops = &bcm590xx_ops_vbus;
+ else {
pmu->desc[i].ops = &bcm590xx_ops_dcdc;
pmu->desc[i].vsel_mask = BCM590XX_SR_VSEL_MASK;
}
- pmu->desc[i].vsel_reg = bcm590xx_get_vsel_register(i);
- pmu->desc[i].enable_is_inverted = true;
- pmu->desc[i].enable_mask = BCM590XX_REG_ENABLE;
+ if (BCM590XX_REG_IS_VBUS(i))
+ pmu->desc[i].enable_mask = BCM590XX_VBUS_ENABLE;
+ else {
+ pmu->desc[i].vsel_reg = bcm590xx_get_vsel_register(i);
+ pmu->desc[i].enable_is_inverted = true;
+ pmu->desc[i].enable_mask = BCM590XX_REG_ENABLE;
+ }
pmu->desc[i].enable_reg = bcm590xx_get_enable_register(i);
pmu->desc[i].type = REGULATOR_VOLTAGE;
pmu->desc[i].owner = THIS_MODULE;
@@ -371,7 +440,10 @@ static int bcm590xx_probe(struct platform_device *pdev)
config.dev = bcm590xx->dev;
config.init_data = reg_data;
config.driver_data = pmu;
- config.regmap = bcm590xx->regmap;
+ if (BCM590XX_REG_IS_GPLDO(i) || BCM590XX_REG_IS_VBUS(i))
+ config.regmap = bcm590xx->regmap_sec;
+ else
+ config.regmap = bcm590xx->regmap_pri;
if (bcm590xx_reg_matches)
config.of_node = bcm590xx_reg_matches[i].of_node;
--
1.8.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
2014-04-23 23:21 ` Matt Porter
@ 2014-04-23 23:21 ` Matt Porter
-1 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-23 23:21 UTC (permalink / raw)
To: Devicetree List, Lee Jones, Samuel Ortiz, Liam Girdwood, Mark Brown
Cc: Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
Adds additional nodes to support GPLDO1-6 and VBUS regulators which
are now supported in the bcm590xx regulator driver.
Signed-off-by: Matt Porter <mporter@linaro.org>
---
arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
index dfadaaa..066adfb 100644
--- a/arch/arm/boot/dts/bcm59056.dtsi
+++ b/arch/arm/boot/dts/bcm59056.dtsi
@@ -70,5 +70,26 @@
vsr_reg: vsr {
};
+
+ gpldo1_reg: gpldo1 {
+ };
+
+ gpldo2_reg: gpldo2 {
+ };
+
+ gpldo3_reg: gpldo3 {
+ };
+
+ gpldo4_reg: gpldo4 {
+ };
+
+ gpldo5_reg: gpldo5 {
+ };
+
+ gpldo6_reg: gpldo6 {
+ };
+
+ vbus_reg: vbus {
+ };
};
};
--
1.8.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
@ 2014-04-23 23:21 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-23 23:21 UTC (permalink / raw)
To: linux-arm-kernel
Adds additional nodes to support GPLDO1-6 and VBUS regulators which
are now supported in the bcm590xx regulator driver.
Signed-off-by: Matt Porter <mporter@linaro.org>
---
arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
index dfadaaa..066adfb 100644
--- a/arch/arm/boot/dts/bcm59056.dtsi
+++ b/arch/arm/boot/dts/bcm59056.dtsi
@@ -70,5 +70,26 @@
vsr_reg: vsr {
};
+
+ gpldo1_reg: gpldo1 {
+ };
+
+ gpldo2_reg: gpldo2 {
+ };
+
+ gpldo3_reg: gpldo3 {
+ };
+
+ gpldo4_reg: gpldo4 {
+ };
+
+ gpldo5_reg: gpldo5 {
+ };
+
+ gpldo6_reg: gpldo6 {
+ };
+
+ vbus_reg: vbus {
+ };
};
};
--
1.8.4
^ permalink raw reply related [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-04-28 11:56 ` Lee Jones
0 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-04-28 11:56 UTC (permalink / raw)
To: Matt Porter
Cc: Devicetree List, Samuel Ortiz, Liam Girdwood, Mark Brown,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
On Wed, 23 Apr 2014, Matt Porter wrote:
> BCM590xx utilizes a secondary I2C slave address to access additional
> register space. Add support for the secondary address space by
> instantiating a dummy I2C device with the appropriate secondary
> I2C slave address. Also expose a secondary regmap register space so
> that MFD drivers can access this secondary i2c slave address space.
>
> Signed-off-by: Matt Porter <mporter@linaro.org>
> ---
> drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> include/linux/mfd/bcm590xx.h | 9 ++++---
> 2 files changed, 52 insertions(+), 17 deletions(-)
Nice, flows much better now.
Can I just apply the two MFD patches, or are there cross-deps?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-04-28 11:56 ` Lee Jones
0 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-04-28 11:56 UTC (permalink / raw)
To: Matt Porter
Cc: Devicetree List, Samuel Ortiz, Liam Girdwood, Mark Brown,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
On Wed, 23 Apr 2014, Matt Porter wrote:
> BCM590xx utilizes a secondary I2C slave address to access additional
> register space. Add support for the secondary address space by
> instantiating a dummy I2C device with the appropriate secondary
> I2C slave address. Also expose a secondary regmap register space so
> that MFD drivers can access this secondary i2c slave address space.
>
> Signed-off-by: Matt Porter <mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> include/linux/mfd/bcm590xx.h | 9 ++++---
> 2 files changed, 52 insertions(+), 17 deletions(-)
Nice, flows much better now.
Can I just apply the two MFD patches, or are there cross-deps?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-04-28 11:56 ` Lee Jones
0 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-04-28 11:56 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 23 Apr 2014, Matt Porter wrote:
> BCM590xx utilizes a secondary I2C slave address to access additional
> register space. Add support for the secondary address space by
> instantiating a dummy I2C device with the appropriate secondary
> I2C slave address. Also expose a secondary regmap register space so
> that MFD drivers can access this secondary i2c slave address space.
>
> Signed-off-by: Matt Porter <mporter@linaro.org>
> ---
> drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> include/linux/mfd/bcm590xx.h | 9 ++++---
> 2 files changed, 52 insertions(+), 17 deletions(-)
Nice, flows much better now.
Can I just apply the two MFD patches, or are there cross-deps?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
2014-04-28 11:56 ` Lee Jones
@ 2014-04-28 14:09 ` Matt Porter
-1 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-28 14:09 UTC (permalink / raw)
To: Lee Jones
Cc: Devicetree List, Samuel Ortiz, Liam Girdwood, Mark Brown,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
On Mon, Apr 28, 2014 at 12:56:27PM +0100, Lee Jones wrote:
> On Wed, 23 Apr 2014, Matt Porter wrote:
>
> > BCM590xx utilizes a secondary I2C slave address to access additional
> > register space. Add support for the secondary address space by
> > instantiating a dummy I2C device with the appropriate secondary
> > I2C slave address. Also expose a secondary regmap register space so
> > that MFD drivers can access this secondary i2c slave address space.
> >
> > Signed-off-by: Matt Porter <mporter@linaro.org>
> > ---
> > drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> > include/linux/mfd/bcm590xx.h | 9 ++++---
> > 2 files changed, 52 insertions(+), 17 deletions(-)
>
> Nice, flows much better now.
>
> Can I just apply the two MFD patches, or are there cross-deps?
There's cross-deps so the regulator driver will need to go with it.
Mark mentioned earlier in the thread that he wanted to merge through
the regulator tree though.
-Matt
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-04-28 14:09 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-04-28 14:09 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Apr 28, 2014 at 12:56:27PM +0100, Lee Jones wrote:
> On Wed, 23 Apr 2014, Matt Porter wrote:
>
> > BCM590xx utilizes a secondary I2C slave address to access additional
> > register space. Add support for the secondary address space by
> > instantiating a dummy I2C device with the appropriate secondary
> > I2C slave address. Also expose a secondary regmap register space so
> > that MFD drivers can access this secondary i2c slave address space.
> >
> > Signed-off-by: Matt Porter <mporter@linaro.org>
> > ---
> > drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> > include/linux/mfd/bcm590xx.h | 9 ++++---
> > 2 files changed, 52 insertions(+), 17 deletions(-)
>
> Nice, flows much better now.
>
> Can I just apply the two MFD patches, or are there cross-deps?
There's cross-deps so the regulator driver will need to go with it.
Mark mentioned earlier in the thread that he wanted to merge through
the regulator tree though.
-Matt
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
2014-04-28 14:09 ` Matt Porter
(?)
@ 2014-05-20 16:11 ` Lee Jones
-1 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-05-20 16:11 UTC (permalink / raw)
To: Matt Porter
Cc: Devicetree List, Samuel Ortiz, Liam Girdwood, Mark Brown,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
> > > BCM590xx utilizes a secondary I2C slave address to access additional
> > > register space. Add support for the secondary address space by
> > > instantiating a dummy I2C device with the appropriate secondary
> > > I2C slave address. Also expose a secondary regmap register space so
> > > that MFD drivers can access this secondary i2c slave address space.
> > >
> > > Signed-off-by: Matt Porter <mporter@linaro.org>
> > > ---
> > > drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> > > include/linux/mfd/bcm590xx.h | 9 ++++---
> > > 2 files changed, 52 insertions(+), 17 deletions(-)
> >
> > Nice, flows much better now.
> >
> > Can I just apply the two MFD patches, or are there cross-deps?
>
> There's cross-deps so the regulator driver will need to go with it.
> Mark mentioned earlier in the thread that he wanted to merge through
> the regulator tree though.
Still nothing.
Mark,
Can I apply this set and supply you with a pull-request?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-20 16:11 ` Lee Jones
0 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-05-20 16:11 UTC (permalink / raw)
To: Matt Porter
Cc: Devicetree List, Samuel Ortiz, Liam Girdwood, Mark Brown,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
> > > BCM590xx utilizes a secondary I2C slave address to access additional
> > > register space. Add support for the secondary address space by
> > > instantiating a dummy I2C device with the appropriate secondary
> > > I2C slave address. Also expose a secondary regmap register space so
> > > that MFD drivers can access this secondary i2c slave address space.
> > >
> > > Signed-off-by: Matt Porter <mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > > ---
> > > drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> > > include/linux/mfd/bcm590xx.h | 9 ++++---
> > > 2 files changed, 52 insertions(+), 17 deletions(-)
> >
> > Nice, flows much better now.
> >
> > Can I just apply the two MFD patches, or are there cross-deps?
>
> There's cross-deps so the regulator driver will need to go with it.
> Mark mentioned earlier in the thread that he wanted to merge through
> the regulator tree though.
Still nothing.
Mark,
Can I apply this set and supply you with a pull-request?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-20 16:11 ` Lee Jones
0 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-05-20 16:11 UTC (permalink / raw)
To: linux-arm-kernel
> > > BCM590xx utilizes a secondary I2C slave address to access additional
> > > register space. Add support for the secondary address space by
> > > instantiating a dummy I2C device with the appropriate secondary
> > > I2C slave address. Also expose a secondary regmap register space so
> > > that MFD drivers can access this secondary i2c slave address space.
> > >
> > > Signed-off-by: Matt Porter <mporter@linaro.org>
> > > ---
> > > drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> > > include/linux/mfd/bcm590xx.h | 9 ++++---
> > > 2 files changed, 52 insertions(+), 17 deletions(-)
> >
> > Nice, flows much better now.
> >
> > Can I just apply the two MFD patches, or are there cross-deps?
>
> There's cross-deps so the regulator driver will need to go with it.
> Mark mentioned earlier in the thread that he wanted to merge through
> the regulator tree though.
Still nothing.
Mark,
Can I apply this set and supply you with a pull-request?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
2014-05-20 16:11 ` Lee Jones
(?)
@ 2014-05-20 19:00 ` Mark Brown
-1 siblings, 0 replies; 53+ messages in thread
From: Mark Brown @ 2014-05-20 19:00 UTC (permalink / raw)
To: Lee Jones
Cc: Matt Porter, Devicetree List, Samuel Ortiz, Liam Girdwood,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
On Tue, May 20, 2014 at 05:11:31PM +0100, Lee Jones wrote:
> > > > drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> > > > include/linux/mfd/bcm590xx.h | 9 ++++---
> > > > 2 files changed, 52 insertions(+), 17 deletions(-)
> > There's cross-deps so the regulator driver will need to go with it.
> > Mark mentioned earlier in the thread that he wanted to merge through
> > the regulator tree though.
> Still nothing.
> Mark,
> Can I apply this set and supply you with a pull-request?
Can someone please send me whatever it is you want me to look at, the
above diffstat doesn't look relevant. Given the frequency of respins
I'm not always paying a huge amount of attention to MFD serieses which
look like they're going to be resent.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-20 19:00 ` Mark Brown
0 siblings, 0 replies; 53+ messages in thread
From: Mark Brown @ 2014-05-20 19:00 UTC (permalink / raw)
To: Lee Jones
Cc: Matt Porter, Devicetree List, Samuel Ortiz, Liam Girdwood,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
On Tue, May 20, 2014 at 05:11:31PM +0100, Lee Jones wrote:
> > > > drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> > > > include/linux/mfd/bcm590xx.h | 9 ++++---
> > > > 2 files changed, 52 insertions(+), 17 deletions(-)
> > There's cross-deps so the regulator driver will need to go with it.
> > Mark mentioned earlier in the thread that he wanted to merge through
> > the regulator tree though.
> Still nothing.
> Mark,
> Can I apply this set and supply you with a pull-request?
Can someone please send me whatever it is you want me to look at, the
above diffstat doesn't look relevant. Given the frequency of respins
I'm not always paying a huge amount of attention to MFD serieses which
look like they're going to be resent.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-20 19:00 ` Mark Brown
0 siblings, 0 replies; 53+ messages in thread
From: Mark Brown @ 2014-05-20 19:00 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 20, 2014 at 05:11:31PM +0100, Lee Jones wrote:
> > > > drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> > > > include/linux/mfd/bcm590xx.h | 9 ++++---
> > > > 2 files changed, 52 insertions(+), 17 deletions(-)
> > There's cross-deps so the regulator driver will need to go with it.
> > Mark mentioned earlier in the thread that he wanted to merge through
> > the regulator tree though.
> Still nothing.
> Mark,
> Can I apply this set and supply you with a pull-request?
Can someone please send me whatever it is you want me to look at, the
above diffstat doesn't look relevant. Given the frequency of respins
I'm not always paying a huge amount of attention to MFD serieses which
look like they're going to be resent.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140520/4133fe63/attachment.sig>
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-20 20:29 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-05-20 20:29 UTC (permalink / raw)
To: Mark Brown
Cc: Lee Jones, Devicetree List, Samuel Ortiz, Liam Girdwood,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On Tue, May 20, 2014 at 08:00:55PM +0100, Mark Brown wrote:
> On Tue, May 20, 2014 at 05:11:31PM +0100, Lee Jones wrote:
>
> > > > > drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> > > > > include/linux/mfd/bcm590xx.h | 9 ++++---
> > > > > 2 files changed, 52 insertions(+), 17 deletions(-)
>
> > > There's cross-deps so the regulator driver will need to go with it.
> > > Mark mentioned earlier in the thread that he wanted to merge through
> > > the regulator tree though.
>
> > Still nothing.
>
> > Mark,
> > Can I apply this set and supply you with a pull-request?
>
> Can someone please send me whatever it is you want me to look at, the
> above diffstat doesn't look relevant. Given the frequency of respins
> I'm not always paying a huge amount of attention to MFD serieses which
> look like they're going to be resent.
Just resent the v2 series.
-Matt
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-20 20:29 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-05-20 20:29 UTC (permalink / raw)
To: Mark Brown
Cc: Lee Jones, Devicetree List, Samuel Ortiz, Liam Girdwood,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On Tue, May 20, 2014 at 08:00:55PM +0100, Mark Brown wrote:
> On Tue, May 20, 2014 at 05:11:31PM +0100, Lee Jones wrote:
>
> > > > > drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> > > > > include/linux/mfd/bcm590xx.h | 9 ++++---
> > > > > 2 files changed, 52 insertions(+), 17 deletions(-)
>
> > > There's cross-deps so the regulator driver will need to go with it.
> > > Mark mentioned earlier in the thread that he wanted to merge through
> > > the regulator tree though.
>
> > Still nothing.
>
> > Mark,
> > Can I apply this set and supply you with a pull-request?
>
> Can someone please send me whatever it is you want me to look at, the
> above diffstat doesn't look relevant. Given the frequency of respins
> I'm not always paying a huge amount of attention to MFD serieses which
> look like they're going to be resent.
Just resent the v2 series.
-Matt
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-20 20:29 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-05-20 20:29 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 20, 2014 at 08:00:55PM +0100, Mark Brown wrote:
> On Tue, May 20, 2014 at 05:11:31PM +0100, Lee Jones wrote:
>
> > > > > drivers/mfd/bcm590xx.c | 60 +++++++++++++++++++++++++++++++++-----------
> > > > > include/linux/mfd/bcm590xx.h | 9 ++++---
> > > > > 2 files changed, 52 insertions(+), 17 deletions(-)
>
> > > There's cross-deps so the regulator driver will need to go with it.
> > > Mark mentioned earlier in the thread that he wanted to merge through
> > > the regulator tree though.
>
> > Still nothing.
>
> > Mark,
> > Can I apply this set and supply you with a pull-request?
>
> Can someone please send me whatever it is you want me to look at, the
> above diffstat doesn't look relevant. Given the frequency of respins
> I'm not always paying a huge amount of attention to MFD serieses which
> look like they're going to be resent.
Just resent the v2 series.
-Matt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140520/77789b23/attachment.sig>
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
2014-05-20 20:29 ` Matt Porter
(?)
@ 2014-05-20 21:44 ` Mark Brown
-1 siblings, 0 replies; 53+ messages in thread
From: Mark Brown @ 2014-05-20 21:44 UTC (permalink / raw)
To: Matt Porter
Cc: Lee Jones, Devicetree List, Samuel Ortiz, Liam Girdwood,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
On Tue, May 20, 2014 at 04:29:23PM -0400, Matt Porter wrote:
> Just resent the v2 series.
I looked at that but it seems I already acked the regulator part of the
series and nothing else looked immediately relevant?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-20 21:44 ` Mark Brown
0 siblings, 0 replies; 53+ messages in thread
From: Mark Brown @ 2014-05-20 21:44 UTC (permalink / raw)
To: Matt Porter
Cc: Lee Jones, Devicetree List, Samuel Ortiz, Liam Girdwood,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
On Tue, May 20, 2014 at 04:29:23PM -0400, Matt Porter wrote:
> Just resent the v2 series.
I looked at that but it seems I already acked the regulator part of the
series and nothing else looked immediately relevant?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-20 21:44 ` Mark Brown
0 siblings, 0 replies; 53+ messages in thread
From: Mark Brown @ 2014-05-20 21:44 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 20, 2014 at 04:29:23PM -0400, Matt Porter wrote:
> Just resent the v2 series.
I looked at that but it seems I already acked the regulator part of the
series and nothing else looked immediately relevant?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140520/2a96885c/attachment.sig>
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-20 21:57 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-05-20 21:57 UTC (permalink / raw)
To: Mark Brown
Cc: Lee Jones, Devicetree List, Samuel Ortiz, Liam Girdwood,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
On Tue, May 20, 2014 at 10:44:39PM +0100, Mark Brown wrote:
> On Tue, May 20, 2014 at 04:29:23PM -0400, Matt Porter wrote:
>
> > Just resent the v2 series.
>
> I looked at that but it seems I already acked the regulator part of the
> series and nothing else looked immediately relevant?
The series has cross dependencies (shared header include) and thus needs
to have both the mfd and regulator portions merged together. You had
mentioned in the v1 version that you'd like to take it through the
regulator tree and so Lee's comments earlier were with regard to you
taking the mfd portions.
-Matt
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-20 21:57 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-05-20 21:57 UTC (permalink / raw)
To: Mark Brown
Cc: Lee Jones, Devicetree List, Samuel Ortiz, Liam Girdwood,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
On Tue, May 20, 2014 at 10:44:39PM +0100, Mark Brown wrote:
> On Tue, May 20, 2014 at 04:29:23PM -0400, Matt Porter wrote:
>
> > Just resent the v2 series.
>
> I looked at that but it seems I already acked the regulator part of the
> series and nothing else looked immediately relevant?
The series has cross dependencies (shared header include) and thus needs
to have both the mfd and regulator portions merged together. You had
mentioned in the v1 version that you'd like to take it through the
regulator tree and so Lee's comments earlier were with regard to you
taking the mfd portions.
-Matt
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-20 21:57 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-05-20 21:57 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 20, 2014 at 10:44:39PM +0100, Mark Brown wrote:
> On Tue, May 20, 2014 at 04:29:23PM -0400, Matt Porter wrote:
>
> > Just resent the v2 series.
>
> I looked at that but it seems I already acked the regulator part of the
> series and nothing else looked immediately relevant?
The series has cross dependencies (shared header include) and thus needs
to have both the mfd and regulator portions merged together. You had
mentioned in the v1 version that you'd like to take it through the
regulator tree and so Lee's comments earlier were with regard to you
taking the mfd portions.
-Matt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140520/7981cc23/attachment.sig>
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
2014-05-20 21:57 ` Matt Porter
@ 2014-05-20 22:17 ` Mark Brown
-1 siblings, 0 replies; 53+ messages in thread
From: Mark Brown @ 2014-05-20 22:17 UTC (permalink / raw)
To: Matt Porter
Cc: Lee Jones, Devicetree List, Samuel Ortiz, Liam Girdwood,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
On Tue, May 20, 2014 at 05:57:26PM -0400, Matt Porter wrote:
> On Tue, May 20, 2014 at 10:44:39PM +0100, Mark Brown wrote:
> > I looked at that but it seems I already acked the regulator part of the
> > series and nothing else looked immediately relevant?
> The series has cross dependencies (shared header include) and thus needs
> to have both the mfd and regulator portions merged together. You had
> mentioned in the v1 version that you'd like to take it through the
> regulator tree and so Lee's comments earlier were with regard to you
> taking the mfd portions.
Right, OK - because it depends on the earlier MFD patches (I think?) I
was expecting it to be applied in MFD and merged over to regulator.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-20 22:17 ` Mark Brown
0 siblings, 0 replies; 53+ messages in thread
From: Mark Brown @ 2014-05-20 22:17 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 20, 2014 at 05:57:26PM -0400, Matt Porter wrote:
> On Tue, May 20, 2014 at 10:44:39PM +0100, Mark Brown wrote:
> > I looked at that but it seems I already acked the regulator part of the
> > series and nothing else looked immediately relevant?
> The series has cross dependencies (shared header include) and thus needs
> to have both the mfd and regulator portions merged together. You had
> mentioned in the v1 version that you'd like to take it through the
> regulator tree and so Lee's comments earlier were with regard to you
> taking the mfd portions.
Right, OK - because it depends on the earlier MFD patches (I think?) I
was expecting it to be applied in MFD and merged over to regulator.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140520/5b0d1394/attachment.sig>
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-21 9:26 ` Lee Jones
0 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-05-21 9:26 UTC (permalink / raw)
To: Mark Brown
Cc: Matt Porter, Devicetree List, Samuel Ortiz, Liam Girdwood,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
On Tue, 20 May 2014, Mark Brown wrote:
> On Tue, May 20, 2014 at 05:57:26PM -0400, Matt Porter wrote:
> > On Tue, May 20, 2014 at 10:44:39PM +0100, Mark Brown wrote:
>
> > > I looked at that but it seems I already acked the regulator part of the
> > > series and nothing else looked immediately relevant?
>
> > The series has cross dependencies (shared header include) and thus needs
> > to have both the mfd and regulator portions merged together. You had
> > mentioned in the v1 version that you'd like to take it through the
> > regulator tree and so Lee's comments earlier were with regard to you
> > taking the mfd portions.
>
> Right, OK - because it depends on the earlier MFD patches (I think?) I
> was expecting it to be applied in MFD and merged over to regulator.
Great, that's all I needed to know. I'm on it.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-21 9:26 ` Lee Jones
0 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-05-21 9:26 UTC (permalink / raw)
To: Mark Brown
Cc: Matt Porter, Devicetree List, Samuel Ortiz, Liam Girdwood,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
On Tue, 20 May 2014, Mark Brown wrote:
> On Tue, May 20, 2014 at 05:57:26PM -0400, Matt Porter wrote:
> > On Tue, May 20, 2014 at 10:44:39PM +0100, Mark Brown wrote:
>
> > > I looked at that but it seems I already acked the regulator part of the
> > > series and nothing else looked immediately relevant?
>
> > The series has cross dependencies (shared header include) and thus needs
> > to have both the mfd and regulator portions merged together. You had
> > mentioned in the v1 version that you'd like to take it through the
> > regulator tree and so Lee's comments earlier were with regard to you
> > taking the mfd portions.
>
> Right, OK - because it depends on the earlier MFD patches (I think?) I
> was expecting it to be applied in MFD and merged over to regulator.
Great, that's all I needed to know. I'm on it.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address
@ 2014-05-21 9:26 ` Lee Jones
0 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-05-21 9:26 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 20 May 2014, Mark Brown wrote:
> On Tue, May 20, 2014 at 05:57:26PM -0400, Matt Porter wrote:
> > On Tue, May 20, 2014 at 10:44:39PM +0100, Mark Brown wrote:
>
> > > I looked at that but it seems I already acked the regulator part of the
> > > series and nothing else looked immediately relevant?
>
> > The series has cross dependencies (shared header include) and thus needs
> > to have both the mfd and regulator portions merged together. You had
> > mentioned in the v1 version that you'd like to take it through the
> > regulator tree and so Lee's comments earlier were with regard to you
> > taking the mfd portions.
>
> Right, OK - because it depends on the earlier MFD patches (I think?) I
> was expecting it to be applied in MFD and merged over to regulator.
Great, that's all I needed to know. I'm on it.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
@ 2014-05-21 9:29 ` Lee Jones
0 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-05-21 9:29 UTC (permalink / raw)
To: Matt Porter
Cc: Devicetree List, Samuel Ortiz, Liam Girdwood, Mark Brown,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
> Adds additional nodes to support GPLDO1-6 and VBUS regulators which
> are now supported in the bcm590xx regulator driver.
>
> Signed-off-by: Matt Porter <mporter@linaro.org>
> ---
> arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
I'm not going to apply this with the rest of the set. It will have to
go in via your normal arch/arm route.
> diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> index dfadaaa..066adfb 100644
> --- a/arch/arm/boot/dts/bcm59056.dtsi
> +++ b/arch/arm/boot/dts/bcm59056.dtsi
> @@ -70,5 +70,26 @@
>
> vsr_reg: vsr {
> };
> +
> + gpldo1_reg: gpldo1 {
> + };
What do these empty nodes do in any case?
Don't you at least need a status property in there or something?
> + gpldo2_reg: gpldo2 {
> + };
> +
> + gpldo3_reg: gpldo3 {
> + };
> +
> + gpldo4_reg: gpldo4 {
> + };
> +
> + gpldo5_reg: gpldo5 {
> + };
> +
> + gpldo6_reg: gpldo6 {
> + };
> +
> + vbus_reg: vbus {
> + };
> };
> };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
@ 2014-05-21 9:29 ` Lee Jones
0 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-05-21 9:29 UTC (permalink / raw)
To: Matt Porter
Cc: Devicetree List, Samuel Ortiz, Liam Girdwood, Mark Brown,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
> Adds additional nodes to support GPLDO1-6 and VBUS regulators which
> are now supported in the bcm590xx regulator driver.
>
> Signed-off-by: Matt Porter <mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
I'm not going to apply this with the rest of the set. It will have to
go in via your normal arch/arm route.
> diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> index dfadaaa..066adfb 100644
> --- a/arch/arm/boot/dts/bcm59056.dtsi
> +++ b/arch/arm/boot/dts/bcm59056.dtsi
> @@ -70,5 +70,26 @@
>
> vsr_reg: vsr {
> };
> +
> + gpldo1_reg: gpldo1 {
> + };
What do these empty nodes do in any case?
Don't you at least need a status property in there or something?
> + gpldo2_reg: gpldo2 {
> + };
> +
> + gpldo3_reg: gpldo3 {
> + };
> +
> + gpldo4_reg: gpldo4 {
> + };
> +
> + gpldo5_reg: gpldo5 {
> + };
> +
> + gpldo6_reg: gpldo6 {
> + };
> +
> + vbus_reg: vbus {
> + };
> };
> };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
@ 2014-05-21 9:29 ` Lee Jones
0 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-05-21 9:29 UTC (permalink / raw)
To: linux-arm-kernel
> Adds additional nodes to support GPLDO1-6 and VBUS regulators which
> are now supported in the bcm590xx regulator driver.
>
> Signed-off-by: Matt Porter <mporter@linaro.org>
> ---
> arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
I'm not going to apply this with the rest of the set. It will have to
go in via your normal arch/arm route.
> diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> index dfadaaa..066adfb 100644
> --- a/arch/arm/boot/dts/bcm59056.dtsi
> +++ b/arch/arm/boot/dts/bcm59056.dtsi
> @@ -70,5 +70,26 @@
>
> vsr_reg: vsr {
> };
> +
> + gpldo1_reg: gpldo1 {
> + };
What do these empty nodes do in any case?
Don't you at least need a status property in there or something?
> + gpldo2_reg: gpldo2 {
> + };
> +
> + gpldo3_reg: gpldo3 {
> + };
> +
> + gpldo4_reg: gpldo4 {
> + };
> +
> + gpldo5_reg: gpldo5 {
> + };
> +
> + gpldo6_reg: gpldo6 {
> + };
> +
> + vbus_reg: vbus {
> + };
> };
> };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL] mfd: Second IB for Mark (regulator)
2014-04-23 23:21 ` Matt Porter
@ 2014-05-21 9:48 ` Lee Jones
-1 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-05-21 9:48 UTC (permalink / raw)
To: Matt Porter
Cc: Devicetree List, Samuel Ortiz, Liam Girdwood, Mark Brown,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
The following changes since commit a798c10faf62a505d24e5f6213fbaf904a39623f:
Linux 3.15-rc2 (2014-04-20 11:08:50 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/mfd-regulator-v3.16-1
for you to fetch changes up to c6466950e917890be3050171f6745ccb9d91d35f:
regulator: bcm590xx: Add support for regulators on secondary I2C slave (2014-05-21 10:40:16 +0100)
----------------------------------------------------------------
Immutable branch between MFD and Regulator due for v3.16 merge-window.
----------------------------------------------------------------
Doug Anderson (2):
mfd: tps65090: Don't tell child devices we have an IRQ if we don't
mfd: tps65090: Stop caching most registers
Matt Porter (3):
mfd: bcm590xx: Update binding with additional BCM59056 regulators
mfd: bcm590xx: Add support for secondary I2C slave address
regulator: bcm590xx: Add support for regulators on secondary I2C slave
Documentation/devicetree/bindings/mfd/bcm590xx.txt | 4 +-
drivers/mfd/bcm590xx.c | 60 ++++++++++----
drivers/mfd/tps65090.c | 41 ++++++----
drivers/power/tps65090-charger.c | 11 ---
drivers/regulator/bcm590xx-regulator.c | 92 +++++++++++++++++++---
include/linux/mfd/bcm590xx.h | 9 ++-
include/linux/mfd/tps65090.h | 14 ++++
7 files changed, 176 insertions(+), 55 deletions(-)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL] mfd: Second IB for Mark (regulator)
@ 2014-05-21 9:48 ` Lee Jones
0 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-05-21 9:48 UTC (permalink / raw)
To: linux-arm-kernel
The following changes since commit a798c10faf62a505d24e5f6213fbaf904a39623f:
Linux 3.15-rc2 (2014-04-20 11:08:50 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/mfd-regulator-v3.16-1
for you to fetch changes up to c6466950e917890be3050171f6745ccb9d91d35f:
regulator: bcm590xx: Add support for regulators on secondary I2C slave (2014-05-21 10:40:16 +0100)
----------------------------------------------------------------
Immutable branch between MFD and Regulator due for v3.16 merge-window.
----------------------------------------------------------------
Doug Anderson (2):
mfd: tps65090: Don't tell child devices we have an IRQ if we don't
mfd: tps65090: Stop caching most registers
Matt Porter (3):
mfd: bcm590xx: Update binding with additional BCM59056 regulators
mfd: bcm590xx: Add support for secondary I2C slave address
regulator: bcm590xx: Add support for regulators on secondary I2C slave
Documentation/devicetree/bindings/mfd/bcm590xx.txt | 4 +-
drivers/mfd/bcm590xx.c | 60 ++++++++++----
drivers/mfd/tps65090.c | 41 ++++++----
drivers/power/tps65090-charger.c | 11 ---
drivers/regulator/bcm590xx-regulator.c | 92 +++++++++++++++++++---
include/linux/mfd/bcm590xx.h | 9 ++-
include/linux/mfd/tps65090.h | 14 ++++
7 files changed, 176 insertions(+), 55 deletions(-)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
2014-05-21 9:29 ` Lee Jones
(?)
@ 2014-05-21 12:02 ` Matt Porter
-1 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-05-21 12:02 UTC (permalink / raw)
To: Lee Jones
Cc: Devicetree List, Samuel Ortiz, Liam Girdwood, Mark Brown,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
On Wed, May 21, 2014 at 10:29:13AM +0100, Lee Jones wrote:
> > Adds additional nodes to support GPLDO1-6 and VBUS regulators which
> > are now supported in the bcm590xx regulator driver.
> >
> > Signed-off-by: Matt Porter <mporter@linaro.org>
> > ---
> > arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
>
> I'm not going to apply this with the rest of the set. It will have to
> go in via your normal arch/arm route.
Ok
> > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> > index dfadaaa..066adfb 100644
> > --- a/arch/arm/boot/dts/bcm59056.dtsi
> > +++ b/arch/arm/boot/dts/bcm59056.dtsi
> > @@ -70,5 +70,26 @@
> >
> > vsr_reg: vsr {
> > };
> > +
> > + gpldo1_reg: gpldo1 {
> > + };
>
> What do these empty nodes do in any case?
They instantiate regulators. The bcm590xx binding specifies the
allowable subnode names permitted here. This replaces the old method
of specifying an index or the deprecated regulator-compatible property.
The board-specific dts includes this dtsi and applies any board
constraints to a subset of regulators that need them. Unused regulators
are all disabled which is what we want.
> Don't you at least need a status property in there or something?
Not necessary for these subnodes.
-Matt
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
@ 2014-05-21 12:02 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-05-21 12:02 UTC (permalink / raw)
To: Lee Jones
Cc: Devicetree List, Samuel Ortiz, Liam Girdwood, Mark Brown,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
On Wed, May 21, 2014 at 10:29:13AM +0100, Lee Jones wrote:
> > Adds additional nodes to support GPLDO1-6 and VBUS regulators which
> > are now supported in the bcm590xx regulator driver.
> >
> > Signed-off-by: Matt Porter <mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > ---
> > arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
>
> I'm not going to apply this with the rest of the set. It will have to
> go in via your normal arch/arm route.
Ok
> > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> > index dfadaaa..066adfb 100644
> > --- a/arch/arm/boot/dts/bcm59056.dtsi
> > +++ b/arch/arm/boot/dts/bcm59056.dtsi
> > @@ -70,5 +70,26 @@
> >
> > vsr_reg: vsr {
> > };
> > +
> > + gpldo1_reg: gpldo1 {
> > + };
>
> What do these empty nodes do in any case?
They instantiate regulators. The bcm590xx binding specifies the
allowable subnode names permitted here. This replaces the old method
of specifying an index or the deprecated regulator-compatible property.
The board-specific dts includes this dtsi and applies any board
constraints to a subset of regulators that need them. Unused regulators
are all disabled which is what we want.
> Don't you at least need a status property in there or something?
Not necessary for these subnodes.
-Matt
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
@ 2014-05-21 12:02 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-05-21 12:02 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 21, 2014 at 10:29:13AM +0100, Lee Jones wrote:
> > Adds additional nodes to support GPLDO1-6 and VBUS regulators which
> > are now supported in the bcm590xx regulator driver.
> >
> > Signed-off-by: Matt Porter <mporter@linaro.org>
> > ---
> > arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
>
> I'm not going to apply this with the rest of the set. It will have to
> go in via your normal arch/arm route.
Ok
> > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> > index dfadaaa..066adfb 100644
> > --- a/arch/arm/boot/dts/bcm59056.dtsi
> > +++ b/arch/arm/boot/dts/bcm59056.dtsi
> > @@ -70,5 +70,26 @@
> >
> > vsr_reg: vsr {
> > };
> > +
> > + gpldo1_reg: gpldo1 {
> > + };
>
> What do these empty nodes do in any case?
They instantiate regulators. The bcm590xx binding specifies the
allowable subnode names permitted here. This replaces the old method
of specifying an index or the deprecated regulator-compatible property.
The board-specific dts includes this dtsi and applies any board
constraints to a subset of regulators that need them. Unused regulators
are all disabled which is what we want.
> Don't you at least need a status property in there or something?
Not necessary for these subnodes.
-Matt
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
2014-05-21 12:02 ` Matt Porter
@ 2014-05-21 13:30 ` Lee Jones
-1 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-05-21 13:30 UTC (permalink / raw)
To: Matt Porter
Cc: Devicetree List, Samuel Ortiz, Liam Girdwood, Mark Brown,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
> > > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> > > index dfadaaa..066adfb 100644
> > > --- a/arch/arm/boot/dts/bcm59056.dtsi
> > > +++ b/arch/arm/boot/dts/bcm59056.dtsi
> > > @@ -70,5 +70,26 @@
> > >
> > > vsr_reg: vsr {
> > > };
> > > +
> > > + gpldo1_reg: gpldo1 {
> > > + };
> >
> > What do these empty nodes do in any case?
>
> They instantiate regulators. The bcm590xx binding specifies the
> allowable subnode names permitted here. This replaces the old method
> of specifying an index or the deprecated regulator-compatible property.
> The board-specific dts includes this dtsi and applies any board
> constraints to a subset of regulators that need them. Unused regulators
> are all disabled which is what we want.
>
> > Don't you at least need a status property in there or something?
>
> Not necessary for these subnodes.
Very well, thanks for the clarification.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
@ 2014-05-21 13:30 ` Lee Jones
0 siblings, 0 replies; 53+ messages in thread
From: Lee Jones @ 2014-05-21 13:30 UTC (permalink / raw)
To: linux-arm-kernel
> > > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> > > index dfadaaa..066adfb 100644
> > > --- a/arch/arm/boot/dts/bcm59056.dtsi
> > > +++ b/arch/arm/boot/dts/bcm59056.dtsi
> > > @@ -70,5 +70,26 @@
> > >
> > > vsr_reg: vsr {
> > > };
> > > +
> > > + gpldo1_reg: gpldo1 {
> > > + };
> >
> > What do these empty nodes do in any case?
>
> They instantiate regulators. The bcm590xx binding specifies the
> allowable subnode names permitted here. This replaces the old method
> of specifying an index or the deprecated regulator-compatible property.
> The board-specific dts includes this dtsi and applies any board
> constraints to a subset of regulators that need them. Unused regulators
> are all disabled which is what we want.
>
> > Don't you at least need a status property in there or something?
>
> Not necessary for these subnodes.
Very well, thanks for the clarification.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL] mfd: Second IB for Mark (regulator)
2014-05-21 9:48 ` Lee Jones
(?)
@ 2014-05-21 23:18 ` Mark Brown
-1 siblings, 0 replies; 53+ messages in thread
From: Mark Brown @ 2014-05-21 23:18 UTC (permalink / raw)
To: Lee Jones
Cc: Matt Porter, Devicetree List, Samuel Ortiz, Liam Girdwood,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
[-- Attachment #1: Type: text/plain, Size: 150 bytes --]
On Wed, May 21, 2014 at 10:48:52AM +0100, Lee Jones wrote:
> Immutable branch between MFD and Regulator due for v3.16 merge-window.
Pulled, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [GIT PULL] mfd: Second IB for Mark (regulator)
@ 2014-05-21 23:18 ` Mark Brown
0 siblings, 0 replies; 53+ messages in thread
From: Mark Brown @ 2014-05-21 23:18 UTC (permalink / raw)
To: Lee Jones
Cc: Matt Porter, Devicetree List, Samuel Ortiz, Liam Girdwood,
Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
[-- Attachment #1: Type: text/plain, Size: 150 bytes --]
On Wed, May 21, 2014 at 10:48:52AM +0100, Lee Jones wrote:
> Immutable branch between MFD and Regulator due for v3.16 merge-window.
Pulled, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 53+ messages in thread
* [GIT PULL] mfd: Second IB for Mark (regulator)
@ 2014-05-21 23:18 ` Mark Brown
0 siblings, 0 replies; 53+ messages in thread
From: Mark Brown @ 2014-05-21 23:18 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 21, 2014 at 10:48:52AM +0100, Lee Jones wrote:
> Immutable branch between MFD and Regulator due for v3.16 merge-window.
Pulled, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140522/4c2b3244/attachment.sig>
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
@ 2014-05-23 12:09 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-05-23 12:09 UTC (permalink / raw)
To: Devicetree List, Lee Jones, Samuel Ortiz, Liam Girdwood, Mark Brown
Cc: Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
On Wed, Apr 23, 2014 at 07:21:33PM -0400, Matt Porter wrote:
> Adds additional nodes to support GPLDO1-6 and VBUS regulators which
> are now supported in the bcm590xx regulator driver.
Applied to mach-bcm for-3.16/dt
> arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> index dfadaaa..066adfb 100644
> --- a/arch/arm/boot/dts/bcm59056.dtsi
> +++ b/arch/arm/boot/dts/bcm59056.dtsi
> @@ -70,5 +70,26 @@
>
> vsr_reg: vsr {
> };
> +
> + gpldo1_reg: gpldo1 {
> + };
> +
> + gpldo2_reg: gpldo2 {
> + };
> +
> + gpldo3_reg: gpldo3 {
> + };
> +
> + gpldo4_reg: gpldo4 {
> + };
> +
> + gpldo5_reg: gpldo5 {
> + };
> +
> + gpldo6_reg: gpldo6 {
> + };
> +
> + vbus_reg: vbus {
> + };
> };
> };
> --
> 1.8.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
@ 2014-05-23 12:09 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-05-23 12:09 UTC (permalink / raw)
To: Devicetree List, Lee Jones, Samuel Ortiz, Liam Girdwood, Mark Brown
Cc: Tim Kryger, Markus Mayer, Linux Kernel Mailing List,
Linux ARM Kernel List
On Wed, Apr 23, 2014 at 07:21:33PM -0400, Matt Porter wrote:
> Adds additional nodes to support GPLDO1-6 and VBUS regulators which
> are now supported in the bcm590xx regulator driver.
Applied to mach-bcm for-3.16/dt
> arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> index dfadaaa..066adfb 100644
> --- a/arch/arm/boot/dts/bcm59056.dtsi
> +++ b/arch/arm/boot/dts/bcm59056.dtsi
> @@ -70,5 +70,26 @@
>
> vsr_reg: vsr {
> };
> +
> + gpldo1_reg: gpldo1 {
> + };
> +
> + gpldo2_reg: gpldo2 {
> + };
> +
> + gpldo3_reg: gpldo3 {
> + };
> +
> + gpldo4_reg: gpldo4 {
> + };
> +
> + gpldo5_reg: gpldo5 {
> + };
> +
> + gpldo6_reg: gpldo6 {
> + };
> +
> + vbus_reg: vbus {
> + };
> };
> };
> --
> 1.8.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
@ 2014-05-23 12:09 ` Matt Porter
0 siblings, 0 replies; 53+ messages in thread
From: Matt Porter @ 2014-05-23 12:09 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Apr 23, 2014 at 07:21:33PM -0400, Matt Porter wrote:
> Adds additional nodes to support GPLDO1-6 and VBUS regulators which
> are now supported in the bcm590xx regulator driver.
Applied to mach-bcm for-3.16/dt
> arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> index dfadaaa..066adfb 100644
> --- a/arch/arm/boot/dts/bcm59056.dtsi
> +++ b/arch/arm/boot/dts/bcm59056.dtsi
> @@ -70,5 +70,26 @@
>
> vsr_reg: vsr {
> };
> +
> + gpldo1_reg: gpldo1 {
> + };
> +
> + gpldo2_reg: gpldo2 {
> + };
> +
> + gpldo3_reg: gpldo3 {
> + };
> +
> + gpldo4_reg: gpldo4 {
> + };
> +
> + gpldo5_reg: gpldo5 {
> + };
> +
> + gpldo6_reg: gpldo6 {
> + };
> +
> + vbus_reg: vbus {
> + };
> };
> };
> --
> 1.8.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 53+ messages in thread
end of thread, other threads:[~2014-05-23 12:09 UTC | newest]
Thread overview: 53+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-23 23:21 [PATCH v2 0/4] Support additional regulators on BCM590xx Matt Porter
2014-04-23 23:21 ` Matt Porter
2014-04-23 23:21 ` Matt Porter
2014-04-23 23:21 ` [PATCH v2 1/4] mfd: bcm590xx: update binding with additional BCM59056 regulators Matt Porter
2014-04-23 23:21 ` Matt Porter
2014-04-23 23:21 ` [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address Matt Porter
2014-04-23 23:21 ` Matt Porter
2014-04-28 11:56 ` Lee Jones
2014-04-28 11:56 ` Lee Jones
2014-04-28 11:56 ` Lee Jones
2014-04-28 14:09 ` Matt Porter
2014-04-28 14:09 ` Matt Porter
2014-05-20 16:11 ` Lee Jones
2014-05-20 16:11 ` Lee Jones
2014-05-20 16:11 ` Lee Jones
2014-05-20 19:00 ` Mark Brown
2014-05-20 19:00 ` Mark Brown
2014-05-20 19:00 ` Mark Brown
2014-05-20 20:29 ` Matt Porter
2014-05-20 20:29 ` Matt Porter
2014-05-20 20:29 ` Matt Porter
2014-05-20 21:44 ` Mark Brown
2014-05-20 21:44 ` Mark Brown
2014-05-20 21:44 ` Mark Brown
2014-05-20 21:57 ` Matt Porter
2014-05-20 21:57 ` Matt Porter
2014-05-20 21:57 ` Matt Porter
2014-05-20 22:17 ` Mark Brown
2014-05-20 22:17 ` Mark Brown
2014-05-21 9:26 ` Lee Jones
2014-05-21 9:26 ` Lee Jones
2014-05-21 9:26 ` Lee Jones
2014-04-23 23:21 ` [PATCH v2 3/4] regulator: bcm590xx: add support for regulators on secondary I2C slave Matt Porter
2014-04-23 23:21 ` Matt Porter
2014-04-23 23:21 ` Matt Porter
2014-04-23 23:21 ` [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators Matt Porter
2014-04-23 23:21 ` Matt Porter
2014-05-21 9:29 ` Lee Jones
2014-05-21 9:29 ` Lee Jones
2014-05-21 9:29 ` Lee Jones
2014-05-21 12:02 ` Matt Porter
2014-05-21 12:02 ` Matt Porter
2014-05-21 12:02 ` Matt Porter
2014-05-21 13:30 ` Lee Jones
2014-05-21 13:30 ` Lee Jones
2014-05-23 12:09 ` Matt Porter
2014-05-23 12:09 ` Matt Porter
2014-05-23 12:09 ` Matt Porter
2014-05-21 9:48 ` [GIT PULL] mfd: Second IB for Mark (regulator) Lee Jones
2014-05-21 9:48 ` Lee Jones
2014-05-21 23:18 ` Mark Brown
2014-05-21 23:18 ` Mark Brown
2014-05-21 23:18 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.