From: Marek Vasut <marex@denx.de> To: Tomasz Figa <tomasz.figa@gmail.com> Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, herbert@gondor.apana.org.au, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, rdunlap@infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, LABBE Corentin <clabbe.montjoie@gmail.com>, linux-crypto@vger.kernel.org, galak@codeaurora.org, grant.likely@linaro.org, maxime.ripard@free-electrons.com, davem@davemloft.net Subject: Re: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System Date: Sat, 24 May 2014 21:59:30 +0200 [thread overview] Message-ID: <201405242159.30505.marex@denx.de> (raw) In-Reply-To: <5380F85F.7020601@gmail.com> On Saturday, May 24, 2014 at 09:51:59 PM, Tomasz Figa wrote: [...] > >>> Why sun7i-a20 ? Is the crypto unit different in other sunxi chips ? Can > >>> that not be described by DT props ? > >> > >> A widely used convention is to define compatible strings after first > >> SoCs on which particular IP blocks appear. It is quite common among IP > >> blocks for which there is no well defined versioning scheme. > > > > Well yeah, that's fine. But in this case, "sun7i" is the entire group of > > CPUs manufactured by AW. I find that information redundant, the > > "allwinner,a20- crypto" would suffice. But I wonder if that IP block > > might have appeared even earlier ? Or if it is CPU family specific, thus > > "allwinner,sun7i-crypto" would be a better string ? > > I'm not aware of Allwinner naming schemes too much, so please correct me > if I'm wrong, but if A20 implies sun7i, then "allwinner,a20-crypto" > would be better indeed. True. > Whether it was really the first SoC is another thing. Obviously this > needs to be checked, although it isn't really that important. For this > particular naming scheme you need to specify all the SoCs for which > given compatible string can be used for this IP anyway, because there is > usually no other source of information about this available (except > directly comparing two datasheets...). Better get the DT stuff correctly right from the start. That's why I'm asking what chips contains the IP block, so we can guess the right name. Best regards, Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System Date: Sat, 24 May 2014 21:59:30 +0200 [thread overview] Message-ID: <201405242159.30505.marex@denx.de> (raw) In-Reply-To: <5380F85F.7020601@gmail.com> On Saturday, May 24, 2014 at 09:51:59 PM, Tomasz Figa wrote: [...] > >>> Why sun7i-a20 ? Is the crypto unit different in other sunxi chips ? Can > >>> that not be described by DT props ? > >> > >> A widely used convention is to define compatible strings after first > >> SoCs on which particular IP blocks appear. It is quite common among IP > >> blocks for which there is no well defined versioning scheme. > > > > Well yeah, that's fine. But in this case, "sun7i" is the entire group of > > CPUs manufactured by AW. I find that information redundant, the > > "allwinner,a20- crypto" would suffice. But I wonder if that IP block > > might have appeared even earlier ? Or if it is CPU family specific, thus > > "allwinner,sun7i-crypto" would be a better string ? > > I'm not aware of Allwinner naming schemes too much, so please correct me > if I'm wrong, but if A20 implies sun7i, then "allwinner,a20-crypto" > would be better indeed. True. > Whether it was really the first SoC is another thing. Obviously this > needs to be checked, although it isn't really that important. For this > particular naming scheme you need to specify all the SoCs for which > given compatible string can be used for this IP anyway, because there is > usually no other source of information about this available (except > directly comparing two datasheets...). Better get the DT stuff correctly right from the start. That's why I'm asking what chips contains the IP block, so we can guess the right name. Best regards, Marek Vasut
next prev parent reply other threads:[~2014-05-24 19:59 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-05-22 15:09 crypto: Add Allwinner Security System crypto accelerator LABBE Corentin 2014-05-22 15:09 ` LABBE Corentin 2014-05-22 15:09 ` [PATCH 1/3] dt: Add DT bindings documentation for SUNXI Security System LABBE Corentin 2014-05-22 15:09 ` LABBE Corentin 2014-05-24 11:21 ` Marek Vasut 2014-05-24 11:21 ` Marek Vasut 2014-05-24 11:21 ` Marek Vasut 2014-05-24 19:20 ` Tomasz Figa 2014-05-24 19:20 ` Tomasz Figa 2014-05-24 19:43 ` Marek Vasut 2014-05-24 19:43 ` Marek Vasut 2014-05-24 19:51 ` Tomasz Figa 2014-05-24 19:51 ` Tomasz Figa 2014-05-24 19:59 ` Marek Vasut [this message] 2014-05-24 19:59 ` Marek Vasut 2014-05-25 13:09 ` Maxime Ripard 2014-05-25 13:09 ` Maxime Ripard 2014-05-25 13:07 ` Maxime Ripard 2014-05-25 13:07 ` Maxime Ripard 2014-05-22 15:09 ` [PATCH 2/3] ARM: sun7i: dt: Add Security System to A20 SoC DTS LABBE Corentin 2014-05-22 15:09 ` LABBE Corentin 2014-05-24 11:23 ` Marek Vasut 2014-05-24 11:23 ` Marek Vasut 2014-05-22 15:09 ` [PATCH 3/3] crypto: Add Allwinner Security System crypto accelerator LABBE Corentin 2014-05-22 15:09 ` LABBE Corentin 2014-05-22 15:28 ` Arnd Bergmann 2014-05-22 15:28 ` Arnd Bergmann 2014-05-22 18:13 ` Corentin LABBE 2014-05-22 18:13 ` Corentin LABBE 2014-05-23 10:46 ` Arnd Bergmann 2014-05-23 10:46 ` Arnd Bergmann 2014-05-24 11:26 ` Marek Vasut 2014-05-24 11:26 ` Marek Vasut 2014-05-24 11:26 ` Marek Vasut 2014-05-24 12:00 ` Marek Vasut 2014-05-24 12:00 ` Marek Vasut 2014-05-25 11:58 ` Corentin LABBE 2014-05-25 11:58 ` Corentin LABBE 2014-05-25 14:30 ` Marek Vasut 2014-05-25 14:30 ` Marek Vasut 2014-07-23 13:57 ` Herbert Xu 2014-07-23 13:57 ` Herbert Xu 2014-07-23 14:07 ` Marek Vasut 2014-07-23 14:07 ` Marek Vasut 2014-07-23 14:13 ` Herbert Xu 2014-07-23 14:13 ` Herbert Xu 2014-07-23 15:51 ` Marek Vasut 2014-07-23 15:51 ` Marek Vasut [not found] ` <201407231751.02050.marex-ynQEQJNshbs@public.gmane.org> 2014-07-23 18:52 ` Corentin LABBE 2014-07-23 18:52 ` Corentin LABBE 2014-07-23 18:52 ` Corentin LABBE 2014-07-23 19:38 ` Marek Vasut 2014-07-23 19:38 ` Marek Vasut 2014-07-24 1:40 ` Herbert Xu 2014-07-24 1:40 ` Herbert Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201405242159.30505.marex@denx.de \ --to=marex@denx.de \ --cc=clabbe.montjoie@gmail.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=grant.likely@linaro.org \ --cc=herbert@gondor.apana.org.au \ --cc=ijc+devicetree@hellion.org.uk \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@free-electrons.com \ --cc=pawel.moll@arm.com \ --cc=rdunlap@infradead.org \ --cc=robh+dt@kernel.org \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.