* [PATCH] CMA: use MIGRATE_SYNC in alloc_contig_range()
@ 2014-05-29 6:25 ` Joonsoo Kim
0 siblings, 0 replies; 8+ messages in thread
From: Joonsoo Kim @ 2014-05-29 6:25 UTC (permalink / raw)
To: Andrew Morton
Cc: David Rientjes, linux-mm, linux-kernel, Marek Szyprowski,
Michal Nazarewicz, Aneesh Kumar K.V, Joonsoo Kim
Before commit 'mm, compaction: embed migration mode in compact_control'
from David is merged, alloc_contig_range() used sync migration,
instead of sync_light migration. This doesn't break anything currently
because page isolation doesn't have any difference with sync and
sync_light, but it could in the future, so change back as it was.
And pass cc->mode to migrate_pages(), instead of passing MIGRATE_SYNC
to migrate_pages().
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 7f97767..97c4185 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6262,7 +6262,7 @@ static int __alloc_contig_migrate_range(struct compact_control *cc,
cc->nr_migratepages -= nr_reclaimed;
ret = migrate_pages(&cc->migratepages, alloc_migrate_target,
- NULL, 0, MIGRATE_SYNC, MR_CMA);
+ NULL, 0, cc->mode, MR_CMA);
}
if (ret < 0) {
putback_movable_pages(&cc->migratepages);
@@ -6301,7 +6301,7 @@ int alloc_contig_range(unsigned long start, unsigned long end,
.nr_migratepages = 0,
.order = -1,
.zone = page_zone(pfn_to_page(start)),
- .mode = MIGRATE_SYNC_LIGHT,
+ .mode = MIGRATE_SYNC,
.ignore_skip_hint = true,
};
INIT_LIST_HEAD(&cc.migratepages);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] CMA: use MIGRATE_SYNC in alloc_contig_range()
@ 2014-05-29 6:25 ` Joonsoo Kim
0 siblings, 0 replies; 8+ messages in thread
From: Joonsoo Kim @ 2014-05-29 6:25 UTC (permalink / raw)
To: Andrew Morton
Cc: David Rientjes, linux-mm, linux-kernel, Marek Szyprowski,
Michal Nazarewicz, Aneesh Kumar K.V, Joonsoo Kim
Before commit 'mm, compaction: embed migration mode in compact_control'
from David is merged, alloc_contig_range() used sync migration,
instead of sync_light migration. This doesn't break anything currently
because page isolation doesn't have any difference with sync and
sync_light, but it could in the future, so change back as it was.
And pass cc->mode to migrate_pages(), instead of passing MIGRATE_SYNC
to migrate_pages().
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 7f97767..97c4185 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6262,7 +6262,7 @@ static int __alloc_contig_migrate_range(struct compact_control *cc,
cc->nr_migratepages -= nr_reclaimed;
ret = migrate_pages(&cc->migratepages, alloc_migrate_target,
- NULL, 0, MIGRATE_SYNC, MR_CMA);
+ NULL, 0, cc->mode, MR_CMA);
}
if (ret < 0) {
putback_movable_pages(&cc->migratepages);
@@ -6301,7 +6301,7 @@ int alloc_contig_range(unsigned long start, unsigned long end,
.nr_migratepages = 0,
.order = -1,
.zone = page_zone(pfn_to_page(start)),
- .mode = MIGRATE_SYNC_LIGHT,
+ .mode = MIGRATE_SYNC,
.ignore_skip_hint = true,
};
INIT_LIST_HEAD(&cc.migratepages);
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] CMA: use MIGRATE_SYNC in alloc_contig_range()
2014-05-29 6:25 ` Joonsoo Kim
@ 2014-05-29 6:35 ` Minchan Kim
-1 siblings, 0 replies; 8+ messages in thread
From: Minchan Kim @ 2014-05-29 6:35 UTC (permalink / raw)
To: Joonsoo Kim
Cc: Andrew Morton, David Rientjes, linux-mm, linux-kernel,
Marek Szyprowski, Michal Nazarewicz, Aneesh Kumar K.V
On Thu, May 29, 2014 at 03:25:50PM +0900, Joonsoo Kim wrote:
> Before commit 'mm, compaction: embed migration mode in compact_control'
> from David is merged, alloc_contig_range() used sync migration,
> instead of sync_light migration. This doesn't break anything currently
> because page isolation doesn't have any difference with sync and
> sync_light, but it could in the future, so change back as it was.
>
> And pass cc->mode to migrate_pages(), instead of passing MIGRATE_SYNC
> to migrate_pages().
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Hello Joonsoo,
Please Ccing me if you send patch related to CMA mm part.
I have reviewed/fixed mm part of CMA for a long time so worth to Cced
although I always don't have a time to look at it. :)
Thanks.
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 7f97767..97c4185 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6262,7 +6262,7 @@ static int __alloc_contig_migrate_range(struct compact_control *cc,
> cc->nr_migratepages -= nr_reclaimed;
>
> ret = migrate_pages(&cc->migratepages, alloc_migrate_target,
> - NULL, 0, MIGRATE_SYNC, MR_CMA);
> + NULL, 0, cc->mode, MR_CMA);
> }
> if (ret < 0) {
> putback_movable_pages(&cc->migratepages);
> @@ -6301,7 +6301,7 @@ int alloc_contig_range(unsigned long start, unsigned long end,
> .nr_migratepages = 0,
> .order = -1,
> .zone = page_zone(pfn_to_page(start)),
> - .mode = MIGRATE_SYNC_LIGHT,
> + .mode = MIGRATE_SYNC,
> .ignore_skip_hint = true,
> };
> INIT_LIST_HEAD(&cc.migratepages);
> --
> 1.7.9.5
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kind regards,
Minchan Kim
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] CMA: use MIGRATE_SYNC in alloc_contig_range()
@ 2014-05-29 6:35 ` Minchan Kim
0 siblings, 0 replies; 8+ messages in thread
From: Minchan Kim @ 2014-05-29 6:35 UTC (permalink / raw)
To: Joonsoo Kim
Cc: Andrew Morton, David Rientjes, linux-mm, linux-kernel,
Marek Szyprowski, Michal Nazarewicz, Aneesh Kumar K.V
On Thu, May 29, 2014 at 03:25:50PM +0900, Joonsoo Kim wrote:
> Before commit 'mm, compaction: embed migration mode in compact_control'
> from David is merged, alloc_contig_range() used sync migration,
> instead of sync_light migration. This doesn't break anything currently
> because page isolation doesn't have any difference with sync and
> sync_light, but it could in the future, so change back as it was.
>
> And pass cc->mode to migrate_pages(), instead of passing MIGRATE_SYNC
> to migrate_pages().
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Hello Joonsoo,
Please Ccing me if you send patch related to CMA mm part.
I have reviewed/fixed mm part of CMA for a long time so worth to Cced
although I always don't have a time to look at it. :)
Thanks.
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 7f97767..97c4185 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6262,7 +6262,7 @@ static int __alloc_contig_migrate_range(struct compact_control *cc,
> cc->nr_migratepages -= nr_reclaimed;
>
> ret = migrate_pages(&cc->migratepages, alloc_migrate_target,
> - NULL, 0, MIGRATE_SYNC, MR_CMA);
> + NULL, 0, cc->mode, MR_CMA);
> }
> if (ret < 0) {
> putback_movable_pages(&cc->migratepages);
> @@ -6301,7 +6301,7 @@ int alloc_contig_range(unsigned long start, unsigned long end,
> .nr_migratepages = 0,
> .order = -1,
> .zone = page_zone(pfn_to_page(start)),
> - .mode = MIGRATE_SYNC_LIGHT,
> + .mode = MIGRATE_SYNC,
> .ignore_skip_hint = true,
> };
> INIT_LIST_HEAD(&cc.migratepages);
> --
> 1.7.9.5
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] CMA: use MIGRATE_SYNC in alloc_contig_range()
2014-05-29 6:35 ` Minchan Kim
@ 2014-05-29 6:48 ` Joonsoo Kim
-1 siblings, 0 replies; 8+ messages in thread
From: Joonsoo Kim @ 2014-05-29 6:48 UTC (permalink / raw)
To: Minchan Kim
Cc: Andrew Morton, David Rientjes, linux-mm, linux-kernel,
Marek Szyprowski, Michal Nazarewicz, Aneesh Kumar K.V
On Thu, May 29, 2014 at 03:35:05PM +0900, Minchan Kim wrote:
> On Thu, May 29, 2014 at 03:25:50PM +0900, Joonsoo Kim wrote:
> > Before commit 'mm, compaction: embed migration mode in compact_control'
> > from David is merged, alloc_contig_range() used sync migration,
> > instead of sync_light migration. This doesn't break anything currently
> > because page isolation doesn't have any difference with sync and
> > sync_light, but it could in the future, so change back as it was.
> >
> > And pass cc->mode to migrate_pages(), instead of passing MIGRATE_SYNC
> > to migrate_pages().
> >
> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Acked-by: Minchan Kim <minchan@kernel.org>
Thanks.
>
> Hello Joonsoo,
>
> Please Ccing me if you send patch related to CMA mm part.
> I have reviewed/fixed mm part of CMA for a long time so worth to Cced
> although I always don't have a time to look at it. :)
Okay! This is just small fix going back orignal, so I didn't cc many people
related to CMA mm part. Anyway, I'm sorry.
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] CMA: use MIGRATE_SYNC in alloc_contig_range()
@ 2014-05-29 6:48 ` Joonsoo Kim
0 siblings, 0 replies; 8+ messages in thread
From: Joonsoo Kim @ 2014-05-29 6:48 UTC (permalink / raw)
To: Minchan Kim
Cc: Andrew Morton, David Rientjes, linux-mm, linux-kernel,
Marek Szyprowski, Michal Nazarewicz, Aneesh Kumar K.V
On Thu, May 29, 2014 at 03:35:05PM +0900, Minchan Kim wrote:
> On Thu, May 29, 2014 at 03:25:50PM +0900, Joonsoo Kim wrote:
> > Before commit 'mm, compaction: embed migration mode in compact_control'
> > from David is merged, alloc_contig_range() used sync migration,
> > instead of sync_light migration. This doesn't break anything currently
> > because page isolation doesn't have any difference with sync and
> > sync_light, but it could in the future, so change back as it was.
> >
> > And pass cc->mode to migrate_pages(), instead of passing MIGRATE_SYNC
> > to migrate_pages().
> >
> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Acked-by: Minchan Kim <minchan@kernel.org>
Thanks.
>
> Hello Joonsoo,
>
> Please Ccing me if you send patch related to CMA mm part.
> I have reviewed/fixed mm part of CMA for a long time so worth to Cced
> although I always don't have a time to look at it. :)
Okay! This is just small fix going back orignal, so I didn't cc many people
related to CMA mm part. Anyway, I'm sorry.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] CMA: use MIGRATE_SYNC in alloc_contig_range()
2014-05-29 6:25 ` Joonsoo Kim
@ 2014-05-29 19:32 ` David Rientjes
-1 siblings, 0 replies; 8+ messages in thread
From: David Rientjes @ 2014-05-29 19:32 UTC (permalink / raw)
To: Joonsoo Kim
Cc: Andrew Morton, linux-mm, linux-kernel, Marek Szyprowski,
Michal Nazarewicz, Aneesh Kumar K.V
On Thu, 29 May 2014, Joonsoo Kim wrote:
> Before commit 'mm, compaction: embed migration mode in compact_control'
> from David is merged, alloc_contig_range() used sync migration,
> instead of sync_light migration. This doesn't break anything currently
> because page isolation doesn't have any difference with sync and
> sync_light, but it could in the future, so change back as it was.
>
> And pass cc->mode to migrate_pages(), instead of passing MIGRATE_SYNC
> to migrate_pages().
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: David Rientjes <rientjes@google.com>
Should probably be renamed
mm-compaction-embed-migration-mode-in-compact_control-fix-fix though since
it's based on another patch in -mm that properly does the s/sync/mode/
conversion for CMA.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] CMA: use MIGRATE_SYNC in alloc_contig_range()
@ 2014-05-29 19:32 ` David Rientjes
0 siblings, 0 replies; 8+ messages in thread
From: David Rientjes @ 2014-05-29 19:32 UTC (permalink / raw)
To: Joonsoo Kim
Cc: Andrew Morton, linux-mm, linux-kernel, Marek Szyprowski,
Michal Nazarewicz, Aneesh Kumar K.V
On Thu, 29 May 2014, Joonsoo Kim wrote:
> Before commit 'mm, compaction: embed migration mode in compact_control'
> from David is merged, alloc_contig_range() used sync migration,
> instead of sync_light migration. This doesn't break anything currently
> because page isolation doesn't have any difference with sync and
> sync_light, but it could in the future, so change back as it was.
>
> And pass cc->mode to migrate_pages(), instead of passing MIGRATE_SYNC
> to migrate_pages().
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: David Rientjes <rientjes@google.com>
Should probably be renamed
mm-compaction-embed-migration-mode-in-compact_control-fix-fix though since
it's based on another patch in -mm that properly does the s/sync/mode/
conversion for CMA.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-05-29 19:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-29 6:25 [PATCH] CMA: use MIGRATE_SYNC in alloc_contig_range() Joonsoo Kim
2014-05-29 6:25 ` Joonsoo Kim
2014-05-29 6:35 ` Minchan Kim
2014-05-29 6:35 ` Minchan Kim
2014-05-29 6:48 ` Joonsoo Kim
2014-05-29 6:48 ` Joonsoo Kim
2014-05-29 19:32 ` David Rientjes
2014-05-29 19:32 ` David Rientjes
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.