* [PATCH] irqchip: nvic: Use the generic noop function
@ 2014-06-04 12:37 ` Daniel Thompson
0 siblings, 0 replies; 10+ messages in thread
From: Daniel Thompson @ 2014-06-04 12:37 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper
Cc: Daniel Thompson, linux-arm-kernel, linux-kernel, patches, linaro-kernel
Using the generic function saves looking up this custom one in a source
navigator.
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
---
drivers/irqchip/irq-nvic.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
index 70bdf6e..c935c61 100644
--- a/drivers/irqchip/irq-nvic.c
+++ b/drivers/irqchip/irq-nvic.c
@@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs)
handle_IRQ(irq, regs);
}
-static void nvic_eoi(struct irq_data *d)
-{
- /*
- * This is a no-op as end of interrupt is signaled by the exception
- * return sequence.
- */
-}
-
static int __init nvic_of_init(struct device_node *node,
struct device_node *parent)
{
@@ -102,7 +94,7 @@ static int __init nvic_of_init(struct device_node *node,
gc->chip_types[0].regs.disable = NVIC_ICER;
gc->chip_types[0].chip.irq_mask = irq_gc_mask_disable_reg;
gc->chip_types[0].chip.irq_unmask = irq_gc_unmask_enable_reg;
- gc->chip_types[0].chip.irq_eoi = nvic_eoi;
+ gc->chip_types[0].chip.irq_eoi = irq_gc_noop;
/* disable interrupts */
writel_relaxed(~0, gc->reg_base + NVIC_ICER);
--
1.9.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] irqchip: nvic: Use the generic noop function
@ 2014-06-04 12:37 ` Daniel Thompson
0 siblings, 0 replies; 10+ messages in thread
From: Daniel Thompson @ 2014-06-04 12:37 UTC (permalink / raw)
To: linux-arm-kernel
Using the generic function saves looking up this custom one in a source
navigator.
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
---
drivers/irqchip/irq-nvic.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
index 70bdf6e..c935c61 100644
--- a/drivers/irqchip/irq-nvic.c
+++ b/drivers/irqchip/irq-nvic.c
@@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs)
handle_IRQ(irq, regs);
}
-static void nvic_eoi(struct irq_data *d)
-{
- /*
- * This is a no-op as end of interrupt is signaled by the exception
- * return sequence.
- */
-}
-
static int __init nvic_of_init(struct device_node *node,
struct device_node *parent)
{
@@ -102,7 +94,7 @@ static int __init nvic_of_init(struct device_node *node,
gc->chip_types[0].regs.disable = NVIC_ICER;
gc->chip_types[0].chip.irq_mask = irq_gc_mask_disable_reg;
gc->chip_types[0].chip.irq_unmask = irq_gc_unmask_enable_reg;
- gc->chip_types[0].chip.irq_eoi = nvic_eoi;
+ gc->chip_types[0].chip.irq_eoi = irq_gc_noop;
/* disable interrupts */
writel_relaxed(~0, gc->reg_base + NVIC_ICER);
--
1.9.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] irqchip: nvic: Use the generic noop function
2014-06-04 12:37 ` Daniel Thompson
@ 2014-06-04 13:00 ` Uwe Kleine-König
-1 siblings, 0 replies; 10+ messages in thread
From: Uwe Kleine-König @ 2014-06-04 13:00 UTC (permalink / raw)
To: Daniel Thompson
Cc: Thomas Gleixner, Jason Cooper, linaro-kernel, linux-kernel,
linux-arm-kernel, patches
On Wed, Jun 04, 2014 at 01:37:05PM +0100, Daniel Thompson wrote:
> Using the generic function saves looking up this custom one in a source
> navigator.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] irqchip: nvic: Use the generic noop function
@ 2014-06-04 13:00 ` Uwe Kleine-König
0 siblings, 0 replies; 10+ messages in thread
From: Uwe Kleine-König @ 2014-06-04 13:00 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 04, 2014 at 01:37:05PM +0100, Daniel Thompson wrote:
> Using the generic function saves looking up this custom one in a source
> navigator.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] irqchip: nvic: Use the generic noop function
2014-06-04 12:37 ` Daniel Thompson
@ 2014-06-04 13:42 ` Thomas Gleixner
-1 siblings, 0 replies; 10+ messages in thread
From: Thomas Gleixner @ 2014-06-04 13:42 UTC (permalink / raw)
To: Daniel Thompson
Cc: Jason Cooper, linux-arm-kernel, linux-kernel, patches, linaro-kernel
On Wed, 4 Jun 2014, Daniel Thompson wrote:
> Using the generic function saves looking up this custom one in a source
> navigator.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> ---
> drivers/irqchip/irq-nvic.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
> index 70bdf6e..c935c61 100644
> --- a/drivers/irqchip/irq-nvic.c
> +++ b/drivers/irqchip/irq-nvic.c
> @@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs)
> handle_IRQ(irq, regs);
> }
>
> -static void nvic_eoi(struct irq_data *d)
> -{
> - /*
> - * This is a no-op as end of interrupt is signaled by the exception
> - * return sequence.
> - */
You shred that information. Please move the comment above the
irq_gc_noop assignment.
Thanks,
tglx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] irqchip: nvic: Use the generic noop function
@ 2014-06-04 13:42 ` Thomas Gleixner
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Gleixner @ 2014-06-04 13:42 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 4 Jun 2014, Daniel Thompson wrote:
> Using the generic function saves looking up this custom one in a source
> navigator.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> ---
> drivers/irqchip/irq-nvic.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
> index 70bdf6e..c935c61 100644
> --- a/drivers/irqchip/irq-nvic.c
> +++ b/drivers/irqchip/irq-nvic.c
> @@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs)
> handle_IRQ(irq, regs);
> }
>
> -static void nvic_eoi(struct irq_data *d)
> -{
> - /*
> - * This is a no-op as end of interrupt is signaled by the exception
> - * return sequence.
> - */
You shred that information. Please move the comment above the
irq_gc_noop assignment.
Thanks,
tglx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] irqchip: nvic: Use the generic noop function
2014-06-04 12:37 ` Daniel Thompson
@ 2014-06-04 15:01 ` Daniel Thompson
-1 siblings, 0 replies; 10+ messages in thread
From: Daniel Thompson @ 2014-06-04 15:01 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper
Cc: Daniel Thompson, linux-arm-kernel, linux-kernel, patches, linaro-kernel
Using the generic function saves looking up this custom one in a source
navigator.
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
---
drivers/irqchip/irq-nvic.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
index 70bdf6e..4ff0805 100644
--- a/drivers/irqchip/irq-nvic.c
+++ b/drivers/irqchip/irq-nvic.c
@@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs)
handle_IRQ(irq, regs);
}
-static void nvic_eoi(struct irq_data *d)
-{
- /*
- * This is a no-op as end of interrupt is signaled by the exception
- * return sequence.
- */
-}
-
static int __init nvic_of_init(struct device_node *node,
struct device_node *parent)
{
@@ -102,7 +94,10 @@ static int __init nvic_of_init(struct device_node *node,
gc->chip_types[0].regs.disable = NVIC_ICER;
gc->chip_types[0].chip.irq_mask = irq_gc_mask_disable_reg;
gc->chip_types[0].chip.irq_unmask = irq_gc_unmask_enable_reg;
- gc->chip_types[0].chip.irq_eoi = nvic_eoi;
+ /* This is a no-op as end of interrupt is signaled by the
+ * exception return sequence.
+ */
+ gc->chip_types[0].chip.irq_eoi = irq_gc_noop;
/* disable interrupts */
writel_relaxed(~0, gc->reg_base + NVIC_ICER);
--
1.9.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] irqchip: nvic: Use the generic noop function
@ 2014-06-04 15:01 ` Daniel Thompson
0 siblings, 0 replies; 10+ messages in thread
From: Daniel Thompson @ 2014-06-04 15:01 UTC (permalink / raw)
To: linux-arm-kernel
Using the generic function saves looking up this custom one in a source
navigator.
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
---
drivers/irqchip/irq-nvic.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
index 70bdf6e..4ff0805 100644
--- a/drivers/irqchip/irq-nvic.c
+++ b/drivers/irqchip/irq-nvic.c
@@ -49,14 +49,6 @@ nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs)
handle_IRQ(irq, regs);
}
-static void nvic_eoi(struct irq_data *d)
-{
- /*
- * This is a no-op as end of interrupt is signaled by the exception
- * return sequence.
- */
-}
-
static int __init nvic_of_init(struct device_node *node,
struct device_node *parent)
{
@@ -102,7 +94,10 @@ static int __init nvic_of_init(struct device_node *node,
gc->chip_types[0].regs.disable = NVIC_ICER;
gc->chip_types[0].chip.irq_mask = irq_gc_mask_disable_reg;
gc->chip_types[0].chip.irq_unmask = irq_gc_unmask_enable_reg;
- gc->chip_types[0].chip.irq_eoi = nvic_eoi;
+ /* This is a no-op as end of interrupt is signaled by the
+ * exception return sequence.
+ */
+ gc->chip_types[0].chip.irq_eoi = irq_gc_noop;
/* disable interrupts */
writel_relaxed(~0, gc->reg_base + NVIC_ICER);
--
1.9.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] irqchip: nvic: Use the generic noop function
2014-06-04 15:01 ` Daniel Thompson
@ 2014-06-21 2:14 ` Jason Cooper
-1 siblings, 0 replies; 10+ messages in thread
From: Jason Cooper @ 2014-06-21 2:14 UTC (permalink / raw)
To: Daniel Thompson
Cc: Thomas Gleixner, linux-arm-kernel, linux-kernel, patches, linaro-kernel
On Wed, Jun 04, 2014 at 04:01:52PM +0100, Daniel Thompson wrote:
> Using the generic function saves looking up this custom one in a source
> navigator.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> ---
> drivers/irqchip/irq-nvic.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
Applied to irqchip/core with Uwe's Ack.
thx,
Jason.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] irqchip: nvic: Use the generic noop function
@ 2014-06-21 2:14 ` Jason Cooper
0 siblings, 0 replies; 10+ messages in thread
From: Jason Cooper @ 2014-06-21 2:14 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 04, 2014 at 04:01:52PM +0100, Daniel Thompson wrote:
> Using the generic function saves looking up this custom one in a source
> navigator.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> ---
> drivers/irqchip/irq-nvic.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
Applied to irqchip/core with Uwe's Ack.
thx,
Jason.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-06-21 2:14 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-04 12:37 [PATCH] irqchip: nvic: Use the generic noop function Daniel Thompson
2014-06-04 12:37 ` Daniel Thompson
2014-06-04 13:00 ` Uwe Kleine-König
2014-06-04 13:00 ` Uwe Kleine-König
2014-06-04 13:42 ` Thomas Gleixner
2014-06-04 13:42 ` Thomas Gleixner
2014-06-04 15:01 ` [PATCH v2] " Daniel Thompson
2014-06-04 15:01 ` Daniel Thompson
2014-06-21 2:14 ` Jason Cooper
2014-06-21 2:14 ` Jason Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.