From: Greg KH <gregkh@linuxfoundation.org> To: ritesh.harjani@gmail.com Cc: catalin.marinas@arm.com, Will.Deacon@arm.com, m.szyprowski@samsung.com, rmk@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] device.h: arm,dma-iommu: Move out dma_iommu_mapping struct Date: Wed, 4 Jun 2014 10:51:45 -0700 [thread overview] Message-ID: <20140604175145.GD20812@kroah.com> (raw) In-Reply-To: <1401869506-48129-2-git-send-email-ritesh.harjani@gmail.com> On Wed, Jun 04, 2014 at 01:41:46PM +0530, ritesh.harjani@gmail.com wrote: > From: Ritesh Harjani <ritesh.harjani@gmail.com> > > This patch moves out *mapping pointer of dma_iommu_mapping > from arch/arm/include/asm/device.h to include/liunux/device.h Why? Who else can use this becides arm devices? > > Also, it moves out complete structre definition of dma_iommu_mapping > to include/linux/iommu-helper.h > > This is done since arm iommu's dma-mapping arch independent code, > needs to be moved out to lib/iommu-helper.c, this means > dma_iommu_mapping will be arch independent and later other archs > can make use of it. Will that really happen? Do you have patches that do that? I'd prefer to not do stuff like this until you have a patch series that needs it, otherwise this is just unneeded churn. > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -705,6 +705,10 @@ struct device { > /* arch specific additions */ > struct dev_archdata archdata; > > +#ifdef CONFIG_DMA_USE_IOMMU_HELPER_MAPPING > + struct dma_iommu_mapping *mapping; > +#endif > + > struct device_node *of_node; /* associated device tree node */ > struct acpi_dev_node acpi_node; /* associated ACPI device node */ > Are you sure this will not break the build on systems that enable that option, yet do not include iommu-helper.h? thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/1] device.h: arm,dma-iommu: Move out dma_iommu_mapping struct Date: Wed, 4 Jun 2014 10:51:45 -0700 [thread overview] Message-ID: <20140604175145.GD20812@kroah.com> (raw) In-Reply-To: <1401869506-48129-2-git-send-email-ritesh.harjani@gmail.com> On Wed, Jun 04, 2014 at 01:41:46PM +0530, ritesh.harjani at gmail.com wrote: > From: Ritesh Harjani <ritesh.harjani@gmail.com> > > This patch moves out *mapping pointer of dma_iommu_mapping > from arch/arm/include/asm/device.h to include/liunux/device.h Why? Who else can use this becides arm devices? > > Also, it moves out complete structre definition of dma_iommu_mapping > to include/linux/iommu-helper.h > > This is done since arm iommu's dma-mapping arch independent code, > needs to be moved out to lib/iommu-helper.c, this means > dma_iommu_mapping will be arch independent and later other archs > can make use of it. Will that really happen? Do you have patches that do that? I'd prefer to not do stuff like this until you have a patch series that needs it, otherwise this is just unneeded churn. > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -705,6 +705,10 @@ struct device { > /* arch specific additions */ > struct dev_archdata archdata; > > +#ifdef CONFIG_DMA_USE_IOMMU_HELPER_MAPPING > + struct dma_iommu_mapping *mapping; > +#endif > + > struct device_node *of_node; /* associated device tree node */ > struct acpi_dev_node acpi_node; /* associated ACPI device node */ > Are you sure this will not break the build on systems that enable that option, yet do not include iommu-helper.h? thanks, greg k-h
next prev parent reply other threads:[~2014-06-04 17:48 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-04 8:11 [PATCH 0/1] device.h: Move out arch independent dma_iommu_mapping struct ritesh.harjani 2014-06-04 8:11 ` ritesh.harjani at gmail.com 2014-06-04 8:11 ` [PATCH 1/1] device.h: arm,dma-iommu: Move out " ritesh.harjani 2014-06-04 8:11 ` [PATCH 1/1] device.h: arm, dma-iommu: " ritesh.harjani at gmail.com 2014-06-04 17:51 ` Greg KH [this message] 2014-06-04 17:51 ` [PATCH 1/1] device.h: arm,dma-iommu: " Greg KH 2014-06-04 18:46 ` Ritesh Harjani 2014-06-04 18:46 ` [PATCH 1/1] device.h: arm, dma-iommu: " Ritesh Harjani 2014-06-04 18:59 ` [PATCH 1/1] device.h: arm,dma-iommu: " Greg KH 2014-06-04 18:59 ` Greg KH 2014-06-05 9:18 ` Ritesh Harjani 2014-06-05 9:18 ` [PATCH 1/1] device.h: arm, dma-iommu: " Ritesh Harjani 2014-06-04 19:01 ` [PATCH 1/1] device.h: arm,dma-iommu: " Greg KH 2014-06-04 19:01 ` Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140604175145.GD20812@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=Will.Deacon@arm.com \ --cc=catalin.marinas@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=ritesh.harjani@gmail.com \ --cc=rmk@arm.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.