* re: wil6210: improve debug for WMI receive
@ 2014-06-09 9:35 Dan Carpenter
2014-06-09 12:05 ` Vladimir Kondratiev
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-06-09 9:35 UTC (permalink / raw)
To: qca_vkondrat; +Cc: linux-wireless, wil6210
Hello Vladimir Kondratiev,
The patch a715c7ddd65a: "wil6210: improve debug for WMI receive" from
May 29, 2014, leads to the following static checker warning:
drivers/net/wireless/ath/wil6210/wmi.c:746 wmi_recv_cmd()
info: ignoring unreachable code.
drivers/net/wireless/ath/wil6210/wmi.c
739 spin_unlock_irqrestore(&wil->wmi_ev_lock, flags);
740 {
741 int q = queue_work(wil->wmi_wq,
742 &wil->wmi_event_worker);
743 wil_dbg_wmi(wil, "queue_work -> %d\n", q);
744 }
745 }
746 if (n > 1)
^^^^^^^^^^
We never reach this if statemtent.
747 wil_dbg_wmi(wil, "%s -> %d events processed\n", __func__, n);
748 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: wil6210: improve debug for WMI receive
2014-06-09 9:35 wil6210: improve debug for WMI receive Dan Carpenter
@ 2014-06-09 12:05 ` Vladimir Kondratiev
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Kondratiev @ 2014-06-09 12:05 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-wireless, wil6210
On Monday, June 09, 2014 12:35:18 PM Dan Carpenter wrote:
> 746 if (n > 1)
> ^^^^^^^^^^
> We never reach this if statemtent.
Dan,
Thanks for this. I'll upload fix shortly.
Caused by the missed chunk in rebase.
Thanks, Vladimir
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-09 12:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-09 9:35 wil6210: improve debug for WMI receive Dan Carpenter
2014-06-09 12:05 ` Vladimir Kondratiev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.