* [PATCH] ipvsadm: Fix list daemon to show backup daemon
@ 2014-05-21 3:14 Ryan O'Hara
2014-06-06 7:24 ` Julian Anastasov
0 siblings, 1 reply; 5+ messages in thread
From: Ryan O'Hara @ 2014-05-21 3:14 UTC (permalink / raw)
To: lvs-devel; +Cc: Ryan O'Hara
The list_daemon function in ipvsadm.c will show the master daemon
twice, but never the backup daemon. This patch replaces the redundant
check for IP_VS_STATE_MASTER with a check for IP_VS_STATE_BACKUP, then
prints the appropriate message.
Signed-off-by: Ryan O'Hara <rohara@redhat.com>
---
ipvsadm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ipvsadm.c b/ipvsadm.c
index 4c83a8b..755827f 100644
--- a/ipvsadm.c
+++ b/ipvsadm.c
@@ -1732,8 +1732,8 @@ static void list_daemon(void)
if (u[i].state & IP_VS_STATE_MASTER)
printf("master sync daemon (mcast=%s, syncid=%d)\n",
u[i].mcast_ifn, u[i].syncid);
- if (u[i].state & IP_VS_STATE_MASTER)
- printf("master sync daemon (mcast=%s, syncid=%d)\n",
+ if (u[i].state & IP_VS_STATE_BACKUP)
+ printf("backup sync daemon (mcast=%s, syncid=%d)\n",
u[i].mcast_ifn, u[i].syncid);
}
free(u);
--
1.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ipvsadm: Fix list daemon to show backup daemon
2014-05-21 3:14 [PATCH] ipvsadm: Fix list daemon to show backup daemon Ryan O'Hara
@ 2014-06-06 7:24 ` Julian Anastasov
2014-06-10 7:43 ` Jesper Dangaard Brouer
0 siblings, 1 reply; 5+ messages in thread
From: Julian Anastasov @ 2014-06-06 7:24 UTC (permalink / raw)
To: Ryan O'Hara; +Cc: lvs-devel
Hello,
On Tue, 20 May 2014, Ryan O'Hara wrote:
> The list_daemon function in ipvsadm.c will show the master daemon
> twice, but never the backup daemon. This patch replaces the redundant
> check for IP_VS_STATE_MASTER with a check for IP_VS_STATE_BACKUP, then
> prints the appropriate message.
>
> Signed-off-by: Ryan O'Hara <rohara@redhat.com>
In case you still wait for ack:
Acked-by: Julian Anastasov <ja@ssi.bg>
> ---
> ipvsadm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ipvsadm.c b/ipvsadm.c
> index 4c83a8b..755827f 100644
> --- a/ipvsadm.c
> +++ b/ipvsadm.c
> @@ -1732,8 +1732,8 @@ static void list_daemon(void)
> if (u[i].state & IP_VS_STATE_MASTER)
> printf("master sync daemon (mcast=%s, syncid=%d)\n",
> u[i].mcast_ifn, u[i].syncid);
> - if (u[i].state & IP_VS_STATE_MASTER)
> - printf("master sync daemon (mcast=%s, syncid=%d)\n",
> + if (u[i].state & IP_VS_STATE_BACKUP)
> + printf("backup sync daemon (mcast=%s, syncid=%d)\n",
> u[i].mcast_ifn, u[i].syncid);
> }
> free(u);
> --
> 1.9.0
Regards
--
Julian Anastasov <ja@ssi.bg>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ipvsadm: Fix list daemon to show backup daemon
2014-06-06 7:24 ` Julian Anastasov
@ 2014-06-10 7:43 ` Jesper Dangaard Brouer
2014-06-10 23:48 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Jesper Dangaard Brouer @ 2014-06-10 7:43 UTC (permalink / raw)
To: Julian Anastasov; +Cc: Ryan O'Hara, lvs-devel, Simon Horman
On Fri, 6 Jun 2014 10:24:09 +0300 (EEST) Julian Anastasov <ja@ssi.bg> wrote:
> On Tue, 20 May 2014, Ryan O'Hara wrote:
>
> > The list_daemon function in ipvsadm.c will show the master daemon
> > twice, but never the backup daemon. This patch replaces the redundant
> > check for IP_VS_STATE_MASTER with a check for IP_VS_STATE_BACKUP, then
> > prints the appropriate message.
> >
> > Signed-off-by: Ryan O'Hara <rohara@redhat.com>
>
> In case you still wait for ack:
>
> Acked-by: Julian Anastasov <ja@ssi.bg>
Applied and pushed:
https://git.kernel.org/cgit/utils/kernel/ipvsadm/ipvsadm.git/commit/?id=4cebeb8ea66
Thank you!
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ipvsadm: Fix list daemon to show backup daemon
2014-06-10 7:43 ` Jesper Dangaard Brouer
@ 2014-06-10 23:48 ` Simon Horman
2014-06-11 7:10 ` Jesper Dangaard Brouer
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2014-06-10 23:48 UTC (permalink / raw)
To: Jesper Dangaard Brouer; +Cc: Julian Anastasov, Ryan O'Hara, lvs-devel
On Tue, Jun 10, 2014 at 09:43:50AM +0200, Jesper Dangaard Brouer wrote:
> On Fri, 6 Jun 2014 10:24:09 +0300 (EEST) Julian Anastasov <ja@ssi.bg> wrote:
>
> > On Tue, 20 May 2014, Ryan O'Hara wrote:
> >
> > > The list_daemon function in ipvsadm.c will show the master daemon
> > > twice, but never the backup daemon. This patch replaces the redundant
> > > check for IP_VS_STATE_MASTER with a check for IP_VS_STATE_BACKUP, then
> > > prints the appropriate message.
> > >
> > > Signed-off-by: Ryan O'Hara <rohara@redhat.com>
> >
> > In case you still wait for ack:
> >
> > Acked-by: Julian Anastasov <ja@ssi.bg>
>
> Applied and pushed:
> https://git.kernel.org/cgit/utils/kernel/ipvsadm/ipvsadm.git/commit/?id=4cebeb8ea66
Thanks Jesper,
I wonder if we should consider making a bugfix release in the
not to distant future.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ipvsadm: Fix list daemon to show backup daemon
2014-06-10 23:48 ` Simon Horman
@ 2014-06-11 7:10 ` Jesper Dangaard Brouer
0 siblings, 0 replies; 5+ messages in thread
From: Jesper Dangaard Brouer @ 2014-06-11 7:10 UTC (permalink / raw)
To: Simon Horman; +Cc: Julian Anastasov, Ryan O'Hara, lvs-devel
On Wed, 11 Jun 2014 08:48:42 +0900
Simon Horman <horms@verge.net.au> wrote:
> On Tue, Jun 10, 2014 at 09:43:50AM +0200, Jesper Dangaard Brouer wrote:
> > On Fri, 6 Jun 2014 10:24:09 +0300 (EEST) Julian Anastasov <ja@ssi.bg> wrote:
> >
> > > On Tue, 20 May 2014, Ryan O'Hara wrote:
> > >
> > > > The list_daemon function in ipvsadm.c will show the master daemon
> > > > twice, but never the backup daemon. This patch replaces the redundant
> > > > check for IP_VS_STATE_MASTER with a check for IP_VS_STATE_BACKUP, then
> > > > prints the appropriate message.
> > > >
> > > > Signed-off-by: Ryan O'Hara <rohara@redhat.com>
> > >
> > > In case you still wait for ack:
> > >
> > > Acked-by: Julian Anastasov <ja@ssi.bg>
> >
> > Applied and pushed:
> > https://git.kernel.org/cgit/utils/kernel/ipvsadm/ipvsadm.git/commit/?id=4cebeb8ea66
>
> Thanks Jesper,
>
> I wonder if we should consider making a bugfix release in the
> not to distant future.
We only have two commits/fixes since the last release, both by Ryan
(thanks Ryan)
https://git.kernel.org/cgit/utils/kernel/ipvsadm/ipvsadm.git/commit/?id=cd824937ad6
https://git.kernel.org/cgit/utils/kernel/ipvsadm/ipvsadm.git/commit/?id=4cebeb8ea66
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-06-11 7:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-21 3:14 [PATCH] ipvsadm: Fix list daemon to show backup daemon Ryan O'Hara
2014-06-06 7:24 ` Julian Anastasov
2014-06-10 7:43 ` Jesper Dangaard Brouer
2014-06-10 23:48 ` Simon Horman
2014-06-11 7:10 ` Jesper Dangaard Brouer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.