From: Michal Marek <mmarek@suse.cz> To: Mike Qiu <qiudayu@linux.vnet.ibm.com> Cc: linuxppc <linuxppc-dev@lists.ozlabs.org>, Sam Ravnborg <sam@ravnborg.org>, linux-kbuild <linux-kbuild@vger.kernel.org> Subject: Re: Kernel build fail with "Circular xxxx <- xxxx dependency dropped" Date: Wed, 11 Jun 2014 14:21:04 +0200 [thread overview] Message-ID: <20140611122104.GA24569@pobox.suse.cz> (raw) In-Reply-To: <53981238.8010007@suse.cz> On Wed, Jun 11, 2014 at 10:24:24AM +0200, Michal Marek wrote: > Dne 11.6.2014 08:02, Mike Qiu napsal(a): > > make[1]: Circular arch/powerpc/boot/zImage.lds.S <- > > arch/powerpc/boot/zImage.lds dependency dropped. > > make[1]: Circular arch/powerpc/boot/zImage.coff.lds.S <- > > arch/powerpc/boot/zImage.lds dependency dropped. > > make[1]: Circular arch/powerpc/boot/zImage.coff.lds.S <- > > arch/powerpc/boot/zImage.coff.lds dependency dropped. > > make[1]: Circular arch/powerpc/boot/zImage.ps3.lds.S <- > > arch/powerpc/boot/zImage.lds dependency dropped. > > make[1]: Circular arch/powerpc/boot/zImage.ps3.lds.S <- > > arch/powerpc/boot/zImage.coff.lds dependency dropped. > > make[1]: Circular arch/powerpc/boot/zImage.ps3.lds.S <- > > arch/powerpc/boot/zImage.ps3.lds dependency dropped. > > WRAP arch/powerpc/boot/zImage.ps3.lds.S > > INFO: Uncompressed kernel (size 0x14d0db8) overlaps the address of the > > wrapper(0x400000) > > INFO: Fixing the link_address of wrapper to (0x1500000) > > ld: cannot open linker script file arch/powerpc/boot/zImage.lds: No such > > file or directory > > make[1]: *** [arch/powerpc/boot/zImage.ps3.lds.S] Error 1 > > make: *** [zImage] Error 2 > > make: *** Waiting for unfinished jobs.... > > MODPOST 1853 modules > > > > I use git bisect to find out the possible commits to lead this problem: > > 7e1c04779efd51154baf652e653ceb24ce68939b kbuild: Use relative path for > > $(objtree) > > 890676c65d699db3ad82e7dddd0cf8fb449031af kbuild: Use relative path when > > building in the source tree > > 9da0763bdd82572be243fcf5161734f11568960f kbuild: Use relative path when > > building in a subdir of the source tree > > Thanks for the report, I'll have a look. If I do not come up with a > solution soon, I'll revert the series. I have yet to test this, but can you try the patch below? Thanks! Michal From 7f8336f4c7f2131efbe82543580dda3ec1988609 Mon Sep 17 00:00:00 2001 From: Michal Marek <mmarek@suse.cz> Date: Wed, 11 Jun 2014 13:53:48 +0200 Subject: [PATCH] powerpc: Avoid circular dependency with zImage.% The rule to create the final images uses a zImage.% pattern. Unfortunately, this also matches the names of the zImage.*.lds linker scripts, which appear as a dependency of the final images. This somehow worked when $(srctree) used to be an absolute path, but now the pattern matches too much. List only the images from $(image-y) as the target of the rule, to avoid the circular dependency. Signed-off-by: Michal Marek <mmarek@suse.cz> --- arch/powerpc/boot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile index 426dce7..c60992c 100644 --- a/arch/powerpc/boot/Makefile +++ b/arch/powerpc/boot/Makefile @@ -333,7 +333,7 @@ $(addprefix $(obj)/, $(initrd-y)): $(obj)/ramdisk.image.gz $(obj)/zImage.initrd.%: vmlinux $(wrapperbits) $(call if_changed,wrap,$*,,,$(obj)/ramdisk.image.gz) -$(obj)/zImage.%: vmlinux $(wrapperbits) +$(addprefix $(obj)/, $(filter zImage.%, $(image-y))): vmlinux $(wrapperbits) $(call if_changed,wrap,$*) # dtbImage% - a dtbImage is a zImage with an embedded device tree blob -- 1.9.2
WARNING: multiple messages have this Message-ID (diff)
From: Michal Marek <mmarek@suse.cz> To: Mike Qiu <qiudayu@linux.vnet.ibm.com> Cc: Sam Ravnborg <sam@ravnborg.org>, linuxppc <linuxppc-dev@lists.ozlabs.org>, linux-kbuild <linux-kbuild@vger.kernel.org> Subject: Re: Kernel build fail with "Circular xxxx <- xxxx dependency dropped" Date: Wed, 11 Jun 2014 14:21:04 +0200 [thread overview] Message-ID: <20140611122104.GA24569@pobox.suse.cz> (raw) In-Reply-To: <53981238.8010007@suse.cz> On Wed, Jun 11, 2014 at 10:24:24AM +0200, Michal Marek wrote: > Dne 11.6.2014 08:02, Mike Qiu napsal(a): > > make[1]: Circular arch/powerpc/boot/zImage.lds.S <- > > arch/powerpc/boot/zImage.lds dependency dropped. > > make[1]: Circular arch/powerpc/boot/zImage.coff.lds.S <- > > arch/powerpc/boot/zImage.lds dependency dropped. > > make[1]: Circular arch/powerpc/boot/zImage.coff.lds.S <- > > arch/powerpc/boot/zImage.coff.lds dependency dropped. > > make[1]: Circular arch/powerpc/boot/zImage.ps3.lds.S <- > > arch/powerpc/boot/zImage.lds dependency dropped. > > make[1]: Circular arch/powerpc/boot/zImage.ps3.lds.S <- > > arch/powerpc/boot/zImage.coff.lds dependency dropped. > > make[1]: Circular arch/powerpc/boot/zImage.ps3.lds.S <- > > arch/powerpc/boot/zImage.ps3.lds dependency dropped. > > WRAP arch/powerpc/boot/zImage.ps3.lds.S > > INFO: Uncompressed kernel (size 0x14d0db8) overlaps the address of the > > wrapper(0x400000) > > INFO: Fixing the link_address of wrapper to (0x1500000) > > ld: cannot open linker script file arch/powerpc/boot/zImage.lds: No such > > file or directory > > make[1]: *** [arch/powerpc/boot/zImage.ps3.lds.S] Error 1 > > make: *** [zImage] Error 2 > > make: *** Waiting for unfinished jobs.... > > MODPOST 1853 modules > > > > I use git bisect to find out the possible commits to lead this problem: > > 7e1c04779efd51154baf652e653ceb24ce68939b kbuild: Use relative path for > > $(objtree) > > 890676c65d699db3ad82e7dddd0cf8fb449031af kbuild: Use relative path when > > building in the source tree > > 9da0763bdd82572be243fcf5161734f11568960f kbuild: Use relative path when > > building in a subdir of the source tree > > Thanks for the report, I'll have a look. If I do not come up with a > solution soon, I'll revert the series. I have yet to test this, but can you try the patch below? Thanks! Michal >From 7f8336f4c7f2131efbe82543580dda3ec1988609 Mon Sep 17 00:00:00 2001 From: Michal Marek <mmarek@suse.cz> Date: Wed, 11 Jun 2014 13:53:48 +0200 Subject: [PATCH] powerpc: Avoid circular dependency with zImage.% The rule to create the final images uses a zImage.% pattern. Unfortunately, this also matches the names of the zImage.*.lds linker scripts, which appear as a dependency of the final images. This somehow worked when $(srctree) used to be an absolute path, but now the pattern matches too much. List only the images from $(image-y) as the target of the rule, to avoid the circular dependency. Signed-off-by: Michal Marek <mmarek@suse.cz> --- arch/powerpc/boot/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile index 426dce7..c60992c 100644 --- a/arch/powerpc/boot/Makefile +++ b/arch/powerpc/boot/Makefile @@ -333,7 +333,7 @@ $(addprefix $(obj)/, $(initrd-y)): $(obj)/ramdisk.image.gz $(obj)/zImage.initrd.%: vmlinux $(wrapperbits) $(call if_changed,wrap,$*,,,$(obj)/ramdisk.image.gz) -$(obj)/zImage.%: vmlinux $(wrapperbits) +$(addprefix $(obj)/, $(filter zImage.%, $(image-y))): vmlinux $(wrapperbits) $(call if_changed,wrap,$*) # dtbImage% - a dtbImage is a zImage with an embedded device tree blob -- 1.9.2
next prev parent reply other threads:[~2014-06-11 12:21 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-11 6:02 Kernel build fail with "Circular xxxx <- xxxx dependency dropped" Mike Qiu 2014-06-11 8:24 ` Michal Marek 2014-06-11 8:24 ` Michal Marek 2014-06-11 12:21 ` Michal Marek [this message] 2014-06-11 12:21 ` Michal Marek 2014-06-11 12:22 ` Michal Marek 2014-06-11 12:22 ` Michal Marek 2014-06-11 12:36 ` Mike Qiu 2014-06-11 12:36 ` Mike Qiu 2014-06-11 15:40 ` [PATCH v2] powerpc: Avoid circular dependency with zImage.% Michal Marek 2014-06-11 15:40 ` Michal Marek 2014-06-12 2:07 ` Mike Qiu 2014-06-12 2:07 ` Mike Qiu 2014-06-12 8:09 ` Michal Marek 2014-06-12 8:09 ` Michal Marek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140611122104.GA24569@pobox.suse.cz \ --to=mmarek@suse.cz \ --cc=linux-kbuild@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=qiudayu@linux.vnet.ibm.com \ --cc=sam@ravnborg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.