[U-Boot] [PATCH] common/xyzModem.c: move empty statements to newline

[U-Boot] [PATCH] common/xyzModem.c: move empty statements to newline

[Jeroen Hofstee]

To prevent a warning for clang the loop without a body
is made more clear by moving it to a line of its own.
This prevents a clang warning.

cc: sbabic at denx.de
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>

---
This ignores checkpatch warnings since somone forgot to burn
the GNU code style manual.

jeroen at yellow:~/software/u-boot$ ./scripts/checkpatch.pl 0001-common-xyzModem.c-move-empty-statements-to-newline.patch
WARNING: please, no spaces at the start of a line
+      while ((c = (*getc) ()) > -1)$

ERROR: code indent should use tabs where possible
+        ;$

WARNING: please, no spaces at the start of a line
+        ;$
---
 common/xyzModem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/common/xyzModem.c b/common/xyzModem.c
index 39f7d17..56f4bca 100644
--- a/common/xyzModem.c
+++ b/common/xyzModem.c
@@ -759,7 +759,8 @@ xyzModem_stream_terminate (bool abort, int (*getc) (void))
        * If we don't eat it now, RedBoot will think the user typed it.
        */
       ZM_DEBUG (zm_dprintf ("Trailing gunk:\n"));
-      while ((c = (*getc) ()) > -1);
+      while ((c = (*getc) ()) > -1)
+        ;
       ZM_DEBUG (zm_dprintf ("\n"));
       /*
        * Make a small delay to give terminal programs like minicom
-- 
1.8.3.2

[U-Boot] common/xyzModem.c: move empty statements to newline

[Tom Rini]

On Wed, Jun 11, 2014 at 01:04:42AM +0200, Jeroen Hofstee wrote:

> To prevent a warning for clang the loop without a body
> is made more clear by moving it to a line of its own.
> This prevents a clang warning.
> 
> cc: sbabic at denx.de
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140611/8ff080ad/attachment.pgp>