From: Thomas Gleixner <tglx@linutronix.de> To: LKML <linux-kernel@vger.kernel.org> Cc: John Stultz <john.stultz@linaro.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Kentaro Takeda <takedakn@nttdata.co.jp>, linux-security-module@vger.kernel.org Subject: [patch 13/13] tomoyo: Use sensible time interface Date: Wed, 11 Jun 2014 23:59:19 -0000 [thread overview] Message-ID: <20140611234607.775273584@linutronix.de> (raw) In-Reply-To: <20140611234024.103571777@linutronix.de> [-- Attachment #1: tomoyo-use-sensible-time-interface.patch --] [-- Type: text/plain, Size: 1603 bytes --] There is no point in calling gettimeofday if only the seconds part of the timespec is used. Use get_seconds() instead. It's not only the proper interface it's also faster. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Kentaro Takeda <takedakn@nttdata.co.jp> Cc: linux-security-module@vger.kernel.org --- security/tomoyo/audit.c | 8 +++----- security/tomoyo/common.c | 4 +--- 2 files changed, 4 insertions(+), 8 deletions(-) Index: linux/security/tomoyo/audit.c =================================================================== --- linux.orig/security/tomoyo/audit.c +++ linux/security/tomoyo/audit.c @@ -155,11 +155,9 @@ static char *tomoyo_print_header(struct u8 i; if (!buffer) return NULL; - { - struct timeval tv; - do_gettimeofday(&tv); - tomoyo_convert_time(tv.tv_sec, &stamp); - } + + tomoyo_convert_time(get_seconds(), &stamp); + pos = snprintf(buffer, tomoyo_buffer_len - 1, "#%04u/%02u/%02u %02u:%02u:%02u# profile=%u mode=%s " "granted=%s (global-pid=%u) task={ pid=%u ppid=%u " Index: linux/security/tomoyo/common.c =================================================================== --- linux.orig/security/tomoyo/common.c +++ linux/security/tomoyo/common.c @@ -2267,13 +2267,11 @@ static unsigned int tomoyo_stat_modified */ void tomoyo_update_stat(const u8 index) { - struct timeval tv; - do_gettimeofday(&tv); /* * I don't use atomic operations because race condition is not fatal. */ tomoyo_stat_updated[index]++; - tomoyo_stat_modified[index] = tv.tv_sec; + tomoyo_stat_modified[index] = get_seconds(); } /**
next prev parent reply other threads:[~2014-06-11 23:59 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-11 23:59 [patch 00/13] time: Tree wide cleanup of interfaces and crap Thomas Gleixner 2014-06-11 23:59 ` [patch 01/13] acct: Use ktime_get_ts() Thomas Gleixner 2014-06-21 20:36 ` [tip:timers/core] " tip-bot for Thomas Gleixner 2014-06-11 23:59 ` [patch 02/13] tsacct: " Thomas Gleixner 2014-06-21 20:37 ` [tip:timers/core] " tip-bot for Thomas Gleixner 2014-06-11 23:59 ` [patch 03/13] delayacct: " Thomas Gleixner 2014-06-21 20:36 ` [tip:timers/core] " tip-bot for Thomas Gleixner 2014-06-11 23:59 ` [patch 05/13] sound: " Thomas Gleixner 2014-06-12 10:42 ` Takashi Iwai 2014-06-12 10:51 ` Thomas Gleixner 2014-06-12 10:59 ` Takashi Iwai 2014-06-11 23:59 ` [patch 04/13] net: mac80211: " Thomas Gleixner 2014-06-11 23:59 ` Thomas Gleixner 2014-06-12 6:53 ` Johannes Berg 2014-06-12 9:03 ` Luis R. Rodriguez 2014-06-12 9:03 ` [Cocci] " Luis R. Rodriguez 2014-06-12 9:51 ` Julia.Lawall 2014-06-12 9:51 ` Julia.Lawall at lip6.fr 2014-06-12 10:49 ` Thomas Gleixner 2014-06-12 10:49 ` Thomas Gleixner 2014-06-11 23:59 ` [patch 06/13] sound: intel8x0: Use ktime and ktime_get() Thomas Gleixner 2014-06-11 23:59 ` [patch 08/13] firewire: Use ktime_get_ts() Thomas Gleixner 2014-06-12 12:35 ` Stefan Richter 2014-06-12 14:12 ` Thomas Gleixner 2014-06-21 20:37 ` [tip:timers/core] " tip-bot for Thomas Gleixner 2014-06-11 23:59 ` [patch 07/13] kdb: " Thomas Gleixner 2014-06-21 20:37 ` [tip:timers/core] " tip-bot for Thomas Gleixner 2014-06-11 23:59 ` [patch 10/13] time: Remove do_posix_clock_monotonic_gettime() Thomas Gleixner 2014-06-11 23:59 ` [patch 09/13] fork: Use ktime_get_ts() Thomas Gleixner 2014-06-21 20:37 ` [tip:timers/core] " tip-bot for Thomas Gleixner 2014-06-11 23:59 ` [patch 11/13] wireless: mwifiex: Use the proper interfaces Thomas Gleixner 2014-06-11 23:59 ` Thomas Gleixner 2014-06-12 3:22 ` Bing Zhao 2014-06-12 8:31 ` [patch V2] " Thomas Gleixner 2014-06-12 8:38 ` Johannes Berg 2014-06-13 18:28 ` Bing Zhao 2014-06-13 18:28 ` Bing Zhao 2014-06-11 23:59 ` [patch 12/13] net: mac80211: Remove silly timespec dance Thomas Gleixner 2014-06-11 23:59 ` Thomas Gleixner 2014-06-12 6:49 ` Johannes Berg 2014-06-12 8:19 ` Thomas Gleixner 2014-06-12 8:35 ` net_timedelta() affected by settimeofday() (was: [patch 12/13] net: mac80211: Remove silly timespec dance) Johannes Berg 2014-06-12 8:39 ` Johannes Berg 2014-06-12 8:57 ` Thomas Gleixner 2014-06-12 9:21 ` Johannes Berg 2014-06-12 14:09 ` Thomas Gleixner 2014-06-12 14:09 ` Thomas Gleixner 2014-06-13 17:58 ` Johannes Berg 2014-06-11 23:59 ` Thomas Gleixner [this message] 2014-06-12 0:08 ` [patch 13/13] tomoyo: Use sensible time interface John Stultz 2014-06-12 0:22 ` Thomas Gleixner 2014-06-12 0:28 ` John Stultz 2014-06-12 0:36 ` Thomas Gleixner 2014-06-12 11:53 ` Tetsuo Handa 2014-06-21 20:37 ` [tip:timers/core] " tip-bot for Thomas Gleixner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140611234607.775273584@linutronix.de \ --to=tglx@linutronix.de \ --cc=john.stultz@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=takedakn@nttdata.co.jp \ --subject='Re: [patch 13/13] tomoyo: Use sensible time interface' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.