Re: [PATCH lttng-tools] Add dependency to libcommon for python binding

Re: [PATCH lttng-tools] Add dependency to libcommon for python binding

[David Goulet]

[-- Attachment #1.1: Type: text/plain, Size: 2187 bytes --]

Merged!

On 05 Jun (12:39:48), Paul Woegerer wrote:
> Using the python binding library currently results in in the following error message:
> 
> ImportError: No module named '_lttng'
> 
> During handling of the above exception, another exception occurred:
> 
> Traceback (most recent call last):
>   File "./test_daemon.py", line 31, in <module>
>     from test_utils import *
>   File "/home/pwoegere/MGC/lttng2_stack_latest/lttng-tools/tests/utils/test_utils.py", line 33, in <module>
>     from lttng import *
>   File "/home/pwoegere/MGC/lttng2_stack_latest/lttng-tools/extras/bindings/swig/python/lttng.py", line 34, in <module>
>     _lttng = swig_import_helper()
>   File "/home/pwoegere/MGC/lttng2_stack_latest/lttng-tools/extras/bindings/swig/python/lttng.py", line 26, in swig_import_helper
>     import _lttng
> ImportError: /home/pwoegere/MGC/lttng2_stack_latest/lttng-tools/extras/bindings/swig/python/.libs/_lttng.so: undefined symbol: log_add_time
> 
> This patch adds the missing dependency to libcommon that contains the definition of log_add_time.
> 
> Signed-off-by: Paul Woegerer <paul_woegerer@mentor.com>
> ---
>  extras/bindings/swig/python/Makefile.am | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/extras/bindings/swig/python/Makefile.am b/extras/bindings/swig/python/Makefile.am
> index caf1934..ec35930 100644
> --- a/extras/bindings/swig/python/Makefile.am
> +++ b/extras/bindings/swig/python/Makefile.am
> @@ -13,7 +13,8 @@ MAINTAINERCLEANFILES = lttng_wrap.c lttng.py
>  nodist__lttng_la_SOURCES = lttng_wrap.c
>  _lttng_la_LDFLAGS = -module
>  _lttng_la_LIBADD = 	$(top_srcdir)/src/lib/lttng-ctl/liblttng-ctl.la 		\
> -			$(top_srcdir)/src/common/sessiond-comm/libsessiond-comm.la
> +			$(top_srcdir)/src/common/sessiond-comm/libsessiond-comm.la		\
> +			$(top_srcdir)/src/common/libcommon.la
>  
>  lttng_wrap.c: lttng.i
>  	$(SWIG) -python -I. -I$(top_srcdir)/src/common/sessiond-comm lttng.i
> -- 
> 1.9.3
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 603 bytes --]

[-- Attachment #2: Type: text/plain, Size: 155 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[PATCH lttng-tools] Add dependency to libcommon for python binding

[Paul Woegerer]

Using the python binding library currently results in in the following error message:

ImportError: No module named '_lttng'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./test_daemon.py", line 31, in <module>
    from test_utils import *
  File "/home/pwoegere/MGC/lttng2_stack_latest/lttng-tools/tests/utils/test_utils.py", line 33, in <module>
    from lttng import *
  File "/home/pwoegere/MGC/lttng2_stack_latest/lttng-tools/extras/bindings/swig/python/lttng.py", line 34, in <module>
    _lttng = swig_import_helper()
  File "/home/pwoegere/MGC/lttng2_stack_latest/lttng-tools/extras/bindings/swig/python/lttng.py", line 26, in swig_import_helper
    import _lttng
ImportError: /home/pwoegere/MGC/lttng2_stack_latest/lttng-tools/extras/bindings/swig/python/.libs/_lttng.so: undefined symbol: log_add_time

This patch adds the missing dependency to libcommon that contains the definition of log_add_time.

Signed-off-by: Paul Woegerer <paul_woegerer@mentor.com>
---
 extras/bindings/swig/python/Makefile.am | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/extras/bindings/swig/python/Makefile.am b/extras/bindings/swig/python/Makefile.am
index caf1934..ec35930 100644
--- a/extras/bindings/swig/python/Makefile.am
+++ b/extras/bindings/swig/python/Makefile.am
@@ -13,7 +13,8 @@ MAINTAINERCLEANFILES = lttng_wrap.c lttng.py
 nodist__lttng_la_SOURCES = lttng_wrap.c
 _lttng_la_LDFLAGS = -module
 _lttng_la_LIBADD = 	$(top_srcdir)/src/lib/lttng-ctl/liblttng-ctl.la 		\
-			$(top_srcdir)/src/common/sessiond-comm/libsessiond-comm.la
+			$(top_srcdir)/src/common/sessiond-comm/libsessiond-comm.la		\
+			$(top_srcdir)/src/common/libcommon.la
 
 lttng_wrap.c: lttng.i
 	$(SWIG) -python -I. -I$(top_srcdir)/src/common/sessiond-comm lttng.i
-- 
1.9.3