Re: [lttng-tool] Fix: wrong casting of return value

Re: [lttng-tool] Fix: wrong casting of return value

[David Goulet]

[-- Attachment #1.1: Type: text/plain, Size: 1078 bytes --]

Merged!

On 09 Jun (11:40:36), Jonathan Rajotte Julien wrote:
> The function uri_parse_str_urls return a ssize_t and the return was
> casted to a size_t. This caused the following error checking to fail as
> -1 was interpreted as 18446744073709551615.
> 
> Fixes #803
> 
> Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
> ---
>  src/lib/lttng-ctl/save.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/lib/lttng-ctl/save.c b/src/lib/lttng-ctl/save.c
> index d136b2d..d414a9d 100644
> --- a/src/lib/lttng-ctl/save.c
> +++ b/src/lib/lttng-ctl/save.c
> @@ -99,7 +99,8 @@ int lttng_save_session_attr_set_output_url(
>  	struct lttng_save_session_attr *attr, const char *url)
>  {
>  	int ret = 0;
> -	size_t len, size;
> +	size_t len;
> +	ssize_t size;
>  	struct lttng_uri *uris = NULL;
>  
>  	if (!attr) {
> -- 
> 2.0.0
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 603 bytes --]

[-- Attachment #2: Type: text/plain, Size: 155 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[lttng-tool] Fix: wrong casting of return value

[Jonathan Rajotte Julien]

The function uri_parse_str_urls return a ssize_t and the return was
casted to a size_t. This caused the following error checking to fail as
-1 was interpreted as 18446744073709551615.

Fixes #803

Signed-off-by: Jonathan Rajotte Julien <jonathan.r.julien@gmail.com>
---
 src/lib/lttng-ctl/save.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/lib/lttng-ctl/save.c b/src/lib/lttng-ctl/save.c
index d136b2d..d414a9d 100644
--- a/src/lib/lttng-ctl/save.c
+++ b/src/lib/lttng-ctl/save.c
@@ -99,7 +99,8 @@ int lttng_save_session_attr_set_output_url(
 	struct lttng_save_session_attr *attr, const char *url)
 {
 	int ret = 0;
-	size_t len, size;
+	size_t len;
+	ssize_t size;
 	struct lttng_uri *uris = NULL;
 
 	if (!attr) {
-- 
2.0.0