All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Cooper <jason@lakedaemon.net>
To: Sricharan R <r.sricharan@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	tony@atomide.com, santosh.shilimkar@ti.com, nm@ti.com,
	rnayak@ti.com, linux@arm.linux.org.uk, tglx@linutronix.de
Subject: Re: [PATCH V2 00/19] irqchip: crossbar: driver fixes
Date: Fri, 13 Jun 2014 11:01:22 -0400	[thread overview]
Message-ID: <20140613150122.GP8664@titan.lakedaemon.net> (raw)
In-Reply-To: <1402574007-13987-1-git-send-email-r.sricharan@ti.com>

On Thu, Jun 12, 2014 at 05:23:08PM +0530, Sricharan R wrote:
> This series does some cleanups, fixes for handling two interrupts
> getting mapped twice to same crossbar and provides support for
> hardwired IRQ and crossbar definitions.
> 
> On certain platforms such as DRA7, SPIs 0, 1, 2, 3, 5, 6, 10,
> 131, 132, 133 are direct wired to hardware blocks bypassing
> crossbar. This quirky implementation is *NOT* supposed to be the
> expectation of crossbar hardware usage. This series adds support
> to represent such hard-wired irqs through DT and avoid generic
> allocation/programming of crossbar in the driver.
> 
> This way of supporting hard-wired irqs was a result of
> the below discussions.
> http://www.spinics.net/lists/arm-kernel/msg329946.html
> 
> Based on 3.15 mainline.
> 
> All the patches are available here
>  git@github.com:Sricharanti/sricharan.git crossbar_updates
> 
> The fixes series[1] earlier posted is merged in to this.
> [1] http://www.spinics.net/lists/arm-kernel/msg328273.html
> 
> [V2] Merged the above series and rebased on 3.15 mainline
> 
> Nishanth Menon (16):
>   irqchip: crossbar: dont use '0' to mark reserved interrupts
>   irqchip: crossbar: check for premapped crossbar before allocating
>   irqchip: crossbar: Skip some irqs from getting mapped to crossbar
>   irqchip: crossbar: Initialise the crossbar with a safe value
>   irqchip: crossbar: Change allocation logic by reversing search for
>     free irqs
>   irqchip: crossbar: remove IS_ERR_VALUE check
>   irqchip: crossbar: fix sparse warnings
>   irqchip: crossbar: fix checkpatch warning
>   irqchip: crossbar: fix kerneldoc warning
>   irqchip: crossbar: fix memory leak incase of invalid entry
>   irqchip: crossbar: return proper error value
>   irqchip: crossbar: change the goto naming
>   irqchip: crossbar: introduce ti,max-crossbar-sources to identify
>     valid crossbar mapping
>   irqchip: crossbar: introduce centralized check for crossbar write
>   Documentation: dt: OMAP: crossbar: add description for interrupt
>     consumer
>   irqchip: crossbar allow for quirky hardware with direct hardwiring of
>     GIC
> 
> Rajendra Nayak (1):
>   irqchip: crossbar: DRA7: Fix unused crossbar list
> 
> Sricharan R (2):
>   irqchip: crossbar: set cb pointer to null in case of error
>   irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback

Also, I just noticed this when I decided to look at the history of this
driver: Please format the subject lines like so:

  irqchip: crossbar: Set cb pointer ...
                     ^
                     |
                     \-- note the capitalization

thx,

Jason.

WARNING: multiple messages have this Message-ID (diff)
From: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
To: Sricharan R <r.sricharan-l0cyMroinI0@public.gmane.org>
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
	santosh.shilimkar-l0cyMroinI0@public.gmane.org,
	nm-l0cyMroinI0@public.gmane.org,
	rnayak-l0cyMroinI0@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org
Subject: Re: [PATCH V2 00/19] irqchip: crossbar: driver fixes
Date: Fri, 13 Jun 2014 11:01:22 -0400	[thread overview]
Message-ID: <20140613150122.GP8664@titan.lakedaemon.net> (raw)
In-Reply-To: <1402574007-13987-1-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>

On Thu, Jun 12, 2014 at 05:23:08PM +0530, Sricharan R wrote:
> This series does some cleanups, fixes for handling two interrupts
> getting mapped twice to same crossbar and provides support for
> hardwired IRQ and crossbar definitions.
> 
> On certain platforms such as DRA7, SPIs 0, 1, 2, 3, 5, 6, 10,
> 131, 132, 133 are direct wired to hardware blocks bypassing
> crossbar. This quirky implementation is *NOT* supposed to be the
> expectation of crossbar hardware usage. This series adds support
> to represent such hard-wired irqs through DT and avoid generic
> allocation/programming of crossbar in the driver.
> 
> This way of supporting hard-wired irqs was a result of
> the below discussions.
> http://www.spinics.net/lists/arm-kernel/msg329946.html
> 
> Based on 3.15 mainline.
> 
> All the patches are available here
>  git-9UaJU3cA/F/QT0dZR+AlfA@public.gmane.org:Sricharanti/sricharan.git crossbar_updates
> 
> The fixes series[1] earlier posted is merged in to this.
> [1] http://www.spinics.net/lists/arm-kernel/msg328273.html
> 
> [V2] Merged the above series and rebased on 3.15 mainline
> 
> Nishanth Menon (16):
>   irqchip: crossbar: dont use '0' to mark reserved interrupts
>   irqchip: crossbar: check for premapped crossbar before allocating
>   irqchip: crossbar: Skip some irqs from getting mapped to crossbar
>   irqchip: crossbar: Initialise the crossbar with a safe value
>   irqchip: crossbar: Change allocation logic by reversing search for
>     free irqs
>   irqchip: crossbar: remove IS_ERR_VALUE check
>   irqchip: crossbar: fix sparse warnings
>   irqchip: crossbar: fix checkpatch warning
>   irqchip: crossbar: fix kerneldoc warning
>   irqchip: crossbar: fix memory leak incase of invalid entry
>   irqchip: crossbar: return proper error value
>   irqchip: crossbar: change the goto naming
>   irqchip: crossbar: introduce ti,max-crossbar-sources to identify
>     valid crossbar mapping
>   irqchip: crossbar: introduce centralized check for crossbar write
>   Documentation: dt: OMAP: crossbar: add description for interrupt
>     consumer
>   irqchip: crossbar allow for quirky hardware with direct hardwiring of
>     GIC
> 
> Rajendra Nayak (1):
>   irqchip: crossbar: DRA7: Fix unused crossbar list
> 
> Sricharan R (2):
>   irqchip: crossbar: set cb pointer to null in case of error
>   irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback

Also, I just noticed this when I decided to look at the history of this
driver: Please format the subject lines like so:

  irqchip: crossbar: Set cb pointer ...
                     ^
                     |
                     \-- note the capitalization

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: jason@lakedaemon.net (Jason Cooper)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 00/19] irqchip: crossbar: driver fixes
Date: Fri, 13 Jun 2014 11:01:22 -0400	[thread overview]
Message-ID: <20140613150122.GP8664@titan.lakedaemon.net> (raw)
In-Reply-To: <1402574007-13987-1-git-send-email-r.sricharan@ti.com>

On Thu, Jun 12, 2014 at 05:23:08PM +0530, Sricharan R wrote:
> This series does some cleanups, fixes for handling two interrupts
> getting mapped twice to same crossbar and provides support for
> hardwired IRQ and crossbar definitions.
> 
> On certain platforms such as DRA7, SPIs 0, 1, 2, 3, 5, 6, 10,
> 131, 132, 133 are direct wired to hardware blocks bypassing
> crossbar. This quirky implementation is *NOT* supposed to be the
> expectation of crossbar hardware usage. This series adds support
> to represent such hard-wired irqs through DT and avoid generic
> allocation/programming of crossbar in the driver.
> 
> This way of supporting hard-wired irqs was a result of
> the below discussions.
> http://www.spinics.net/lists/arm-kernel/msg329946.html
> 
> Based on 3.15 mainline.
> 
> All the patches are available here
>  git at github.com:Sricharanti/sricharan.git crossbar_updates
> 
> The fixes series[1] earlier posted is merged in to this.
> [1] http://www.spinics.net/lists/arm-kernel/msg328273.html
> 
> [V2] Merged the above series and rebased on 3.15 mainline
> 
> Nishanth Menon (16):
>   irqchip: crossbar: dont use '0' to mark reserved interrupts
>   irqchip: crossbar: check for premapped crossbar before allocating
>   irqchip: crossbar: Skip some irqs from getting mapped to crossbar
>   irqchip: crossbar: Initialise the crossbar with a safe value
>   irqchip: crossbar: Change allocation logic by reversing search for
>     free irqs
>   irqchip: crossbar: remove IS_ERR_VALUE check
>   irqchip: crossbar: fix sparse warnings
>   irqchip: crossbar: fix checkpatch warning
>   irqchip: crossbar: fix kerneldoc warning
>   irqchip: crossbar: fix memory leak incase of invalid entry
>   irqchip: crossbar: return proper error value
>   irqchip: crossbar: change the goto naming
>   irqchip: crossbar: introduce ti,max-crossbar-sources to identify
>     valid crossbar mapping
>   irqchip: crossbar: introduce centralized check for crossbar write
>   Documentation: dt: OMAP: crossbar: add description for interrupt
>     consumer
>   irqchip: crossbar allow for quirky hardware with direct hardwiring of
>     GIC
> 
> Rajendra Nayak (1):
>   irqchip: crossbar: DRA7: Fix unused crossbar list
> 
> Sricharan R (2):
>   irqchip: crossbar: set cb pointer to null in case of error
>   irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback

Also, I just noticed this when I decided to look at the history of this
driver: Please format the subject lines like so:

  irqchip: crossbar: Set cb pointer ...
                     ^
                     |
                     \-- note the capitalization

thx,

Jason.

  parent reply	other threads:[~2014-06-13 15:01 UTC|newest]

Thread overview: 175+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12 11:53 [PATCH V2 00/19] irqchip: crossbar: driver fixes Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 01/19] irqchip: crossbar: dont use '0' to mark reserved interrupts Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 02/19] irqchip: crossbar: check for premapped crossbar before allocating Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 12:51   ` Jason Cooper
2014-06-12 12:51     ` Jason Cooper
2014-06-12 13:19     ` Sricharan R
2014-06-12 13:19       ` Sricharan R
2014-06-12 13:19       ` Sricharan R
2014-06-12 14:07       ` Jason Cooper
2014-06-12 14:07         ` Jason Cooper
2014-06-12 14:07         ` Jason Cooper
2014-06-13  6:37         ` Sricharan R
2014-06-13  6:37           ` Sricharan R
2014-06-13  6:37           ` Sricharan R
2014-06-13 13:34           ` Jason Cooper
2014-06-13 13:34             ` Jason Cooper
2014-06-12 13:57     ` Tony Lindgren
2014-06-12 13:57       ` Tony Lindgren
2014-06-12 14:05       ` Jason Cooper
2014-06-12 14:05         ` Jason Cooper
2014-06-13  6:56         ` Sricharan R
2014-06-13  6:56           ` Sricharan R
2014-06-13  6:56           ` Sricharan R
2014-06-13 11:04           ` Sricharan R
2014-06-13 11:04             ` Sricharan R
2014-06-13 11:04             ` Sricharan R
2014-06-13 13:10           ` Jason Cooper
2014-06-13 13:10             ` Jason Cooper
2014-06-13 13:35             ` Santosh Shilimkar
2014-06-13 13:35               ` Santosh Shilimkar
2014-06-13 13:35               ` Santosh Shilimkar
2014-06-13 13:41               ` Jason Cooper
2014-06-13 13:41                 ` Jason Cooper
2014-06-13  6:31       ` Sricharan R
2014-06-13  6:31         ` Sricharan R
2014-06-13  6:31         ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 04/19] irqchip: crossbar: Initialise the crossbar with a safe value Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 05/19] irqchip: crossbar: Change allocation logic by reversing search for free irqs Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 12:56   ` Jason Cooper
2014-06-12 12:56     ` Jason Cooper
2014-06-12 12:56     ` Jason Cooper
2014-06-13  6:09     ` Sricharan R
2014-06-13  6:09       ` Sricharan R
2014-06-13  6:09       ` Sricharan R
2014-06-13 13:13       ` Jason Cooper
2014-06-13 13:13         ` Jason Cooper
2014-06-13 13:13         ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 06/19] irqchip: crossbar: remove IS_ERR_VALUE check Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 07/19] irqchip: crossbar: fix sparse warnings Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:10   ` Jason Cooper
2014-06-12 13:10     ` Jason Cooper
2014-06-12 13:10     ` Jason Cooper
2014-06-12 13:35     ` Sricharan R
2014-06-12 13:35       ` Sricharan R
2014-06-12 13:35       ` Sricharan R
2014-06-12 14:18       ` Joe Perches
2014-06-12 14:18         ` Joe Perches
2014-06-12 14:18         ` Joe Perches
2014-06-12 15:32         ` Jason Cooper
2014-06-12 15:32           ` Jason Cooper
2014-06-12 16:05           ` Joe Perches
2014-06-12 16:05             ` Joe Perches
2014-06-12 16:05             ` Joe Perches
2014-06-13  6:30             ` Sricharan R
2014-06-13  6:30               ` Sricharan R
2014-06-13  6:30               ` Sricharan R
2014-06-13 13:15               ` Jason Cooper
2014-06-13 13:15                 ` Jason Cooper
2014-06-13 13:15                 ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 09/19] irqchip: crossbar: fix kerneldoc warning Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:14   ` Jason Cooper
2014-06-12 13:14     ` Jason Cooper
2014-06-12 13:14     ` Jason Cooper
2014-06-12 13:39     ` Sricharan R
2014-06-12 13:39       ` Sricharan R
2014-06-12 13:39       ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 10/19] irqchip: crossbar: DRA7: Fix unused crossbar list Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:16   ` Jason Cooper
2014-06-12 13:16     ` Jason Cooper
2014-06-12 13:16     ` Jason Cooper
2014-06-12 13:21     ` Sricharan R
2014-06-12 13:21       ` Sricharan R
2014-06-12 13:21       ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 11/19] irqchip: crossbar: fix memory leak incase of invalid entry Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:20   ` Jason Cooper
2014-06-12 13:20     ` Jason Cooper
2014-06-12 13:20     ` Jason Cooper
2014-06-12 13:37     ` Sricharan R
2014-06-12 13:37       ` Sricharan R
2014-06-12 13:37       ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 12/19] irqchip: crossbar: return proper error value Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:39   ` Jason Cooper
2014-06-12 13:39     ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 13/19] irqchip: crossbar: change the goto naming Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:41   ` Jason Cooper
2014-06-12 13:41     ` Jason Cooper
2014-06-12 13:41     ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 14/19] irqchip: crossbar: set cb pointer to null in case of error Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 15/19] irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 13:49   ` Jason Cooper
2014-06-12 13:49     ` Jason Cooper
2014-06-12 13:50     ` Sricharan R
2014-06-12 13:50       ` Sricharan R
2014-06-12 13:50       ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources to identify valid crossbar mapping Sricharan R
2014-06-12 11:53   ` [PATCH V2 16/19] irqchip: crossbar: introduce ti, max-crossbar-sources " Sricharan R
2014-06-12 11:53   ` [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources " Sricharan R
2014-06-12 13:54   ` Jason Cooper
2014-06-12 13:54     ` Jason Cooper
2014-06-12 13:54     ` Jason Cooper
2014-06-13 10:54     ` Sricharan R
2014-06-13 10:54       ` [PATCH V2 16/19] irqchip: crossbar: introduce ti, max-crossbar-sources " Sricharan R
2014-06-13 10:54       ` [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources " Sricharan R
2014-06-13 13:17       ` Jason Cooper
2014-06-13 13:17         ` Jason Cooper
2014-06-12 11:53 ` [PATCH V2 17/19] irqchip: crossbar: introduce centralized check for crossbar write Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 18/19] Documentation: dt: OMAP: crossbar: add description for interrupt consumer Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53 ` [PATCH V2 19/19] irqchip: crossbar allow for quirky hardware with direct hardwiring of GIC Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-12 11:53   ` Sricharan R
2014-06-13 15:01 ` Jason Cooper [this message]
2014-06-13 15:01   ` [PATCH V2 00/19] irqchip: crossbar: driver fixes Jason Cooper
2014-06-13 15:01   ` Jason Cooper
2014-06-13 16:14   ` Joe Perches
2014-06-13 16:14     ` Joe Perches
2014-06-13 16:37     ` Jason Cooper
2014-06-13 16:37       ` Jason Cooper
2014-06-13 16:37       ` Jason Cooper
2014-06-13 16:48       ` Joe Perches
2014-06-13 16:48         ` Joe Perches
2014-06-13 16:54         ` Jason Cooper
2014-06-13 16:54           ` Jason Cooper
2014-06-13 20:38           ` Thomas Gleixner
2014-06-13 20:38             ` Thomas Gleixner
2014-06-13 22:22             ` Joe Perches
2014-06-13 22:22               ` Joe Perches
2014-06-13 22:22               ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140613150122.GP8664@titan.lakedaemon.net \
    --to=jason@lakedaemon.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nm@ti.com \
    --cc=r.sricharan@ti.com \
    --cc=rnayak@ti.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.