From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Mikko Perttunen <mperttunen@nvidia.com>,
"tj@kernel.org" <tj@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 6/9] ARM: tegra: Export tegra_powergate_power_on
Date: Tue, 17 Jun 2014 17:01:46 +0300 [thread overview]
Message-ID: <20140617140146.GH3407@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <20140617121313.GE18816@ulmo>
On Tue, Jun 17, 2014 at 02:13:15PM +0200, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Mon, Jun 16, 2014 at 04:01:02PM -0600, Stephen Warren wrote:
> > On 06/04/2014 05:32 AM, Mikko Perttunen wrote:
> > > This symbol needs to be exported to power on rails without using
> > > tegra_powergate_sequence_power_up. tegra_powergate_sequence_power_up
> > > cannot be used in situations where the driver wants to handle clocking
> > > by itself.
> >
> > Thierry, are you OK with this change?
>
> I would've preferred tegra_powergate_sequence_power_up() to be used
I don't think the current tegra_powergate_sequence_power_up() API is very well
defined though. I don't think the clocks and resets required by the sequence
should be provided by the driver. For one, there can be several clocks and
resets that need to be controlled for a single domain.
Cheers,
Peter.
WARNING: multiple messages have this Message-ID (diff)
From: pdeschrijver@nvidia.com (Peter De Schrijver)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/9] ARM: tegra: Export tegra_powergate_power_on
Date: Tue, 17 Jun 2014 17:01:46 +0300 [thread overview]
Message-ID: <20140617140146.GH3407@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <20140617121313.GE18816@ulmo>
On Tue, Jun 17, 2014 at 02:13:15PM +0200, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Mon, Jun 16, 2014 at 04:01:02PM -0600, Stephen Warren wrote:
> > On 06/04/2014 05:32 AM, Mikko Perttunen wrote:
> > > This symbol needs to be exported to power on rails without using
> > > tegra_powergate_sequence_power_up. tegra_powergate_sequence_power_up
> > > cannot be used in situations where the driver wants to handle clocking
> > > by itself.
> >
> > Thierry, are you OK with this change?
>
> I would've preferred tegra_powergate_sequence_power_up() to be used
I don't think the current tegra_powergate_sequence_power_up() API is very well
defined though. I don't think the clocks and resets required by the sequence
should be provided by the driver. For one, there can be several clocks and
resets that need to be controlled for a single domain.
Cheers,
Peter.
next prev parent reply other threads:[~2014-06-17 14:01 UTC|newest]
Thread overview: 173+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 11:32 [PATCH 0/9] Serial ATA support for NVIDIA Tegra124 Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-04 11:32 ` [PATCH 1/9] of: Add NVIDIA Tegra SATA controller binding Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-16 21:55 ` Stephen Warren
2014-06-16 21:55 ` Stephen Warren
2014-06-04 11:32 ` [PATCH 2/9] ARM: tegra: Add SATA controller to Tegra124 device tree Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-04 11:32 ` [PATCH 3/9] ARM: tegra: Add SATA and SATA power to Jetson TK1 " Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
[not found] ` <1401881559-18469-4-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-16 21:58 ` Stephen Warren
2014-06-16 21:58 ` Stephen Warren
2014-06-16 21:58 ` Stephen Warren
2014-06-04 11:32 ` [PATCH 4/9] clk: tegra: Enable hardware control of SATA PLL Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-16 21:49 ` Stephen Warren
2014-06-16 21:49 ` Stephen Warren
2014-06-17 9:59 ` Peter De Schrijver
2014-06-17 9:59 ` Peter De Schrijver
2014-06-17 9:59 ` Peter De Schrijver
2014-06-04 11:32 ` [PATCH 5/9] clk: tegra: Add SATA clocks to Tegra124 initialization table Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-04 11:32 ` [PATCH 6/9] ARM: tegra: Export tegra_powergate_power_on Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
[not found] ` <1401881559-18469-7-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-16 22:01 ` Stephen Warren
2014-06-16 22:01 ` Stephen Warren
2014-06-16 22:01 ` Stephen Warren
2014-06-17 12:13 ` Thierry Reding
2014-06-17 12:13 ` Thierry Reding
2014-06-17 12:28 ` Mikko Perttunen
2014-06-17 12:28 ` Mikko Perttunen
2014-06-17 12:28 ` Mikko Perttunen
2014-06-17 14:01 ` Peter De Schrijver [this message]
2014-06-17 14:01 ` Peter De Schrijver
2014-06-17 14:01 ` Peter De Schrijver
2014-06-17 21:51 ` Thierry Reding
2014-06-17 21:51 ` Thierry Reding
2014-06-17 21:51 ` Thierry Reding
2014-06-18 12:18 ` Peter De Schrijver
2014-06-18 12:18 ` Peter De Schrijver
2014-06-18 12:18 ` Peter De Schrijver
2014-06-18 15:37 ` Stephen Warren
2014-06-18 15:37 ` Stephen Warren
2014-06-18 15:37 ` Stephen Warren
2014-06-19 8:02 ` Peter De Schrijver
2014-06-19 8:02 ` Peter De Schrijver
2014-06-19 8:02 ` Peter De Schrijver
2014-06-19 8:36 ` Peter De Schrijver
2014-06-19 8:36 ` Peter De Schrijver
2014-06-19 8:36 ` Peter De Schrijver
2014-06-19 16:01 ` Stephen Warren
2014-06-19 16:01 ` Stephen Warren
2014-06-19 16:01 ` Stephen Warren
2014-06-23 10:14 ` Peter De Schrijver
2014-06-23 10:14 ` Peter De Schrijver
2014-06-23 10:14 ` Peter De Schrijver
2014-07-08 13:05 ` Thierry Reding
2014-07-08 13:05 ` Thierry Reding
2014-07-08 13:05 ` Thierry Reding
2014-07-08 14:11 ` Peter De Schrijver
2014-07-08 14:11 ` Peter De Schrijver
2014-07-08 14:11 ` Peter De Schrijver
2014-07-09 6:31 ` Thierry Reding
2014-07-09 6:31 ` Thierry Reding
2014-07-09 6:31 ` Thierry Reding
2014-07-09 8:33 ` Peter De Schrijver
2014-07-09 8:33 ` Peter De Schrijver
2014-07-09 8:33 ` Peter De Schrijver
[not found] ` <20140709083311.GE23218-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-07-09 10:25 ` Thierry Reding
2014-07-09 10:25 ` Thierry Reding
2014-07-09 10:25 ` Thierry Reding
2014-07-09 10:31 ` Lucas Stach
2014-07-09 10:31 ` Lucas Stach
2014-07-09 10:31 ` Lucas Stach
2014-07-09 11:20 ` Peter De Schrijver
2014-07-09 11:20 ` Peter De Schrijver
2014-07-09 11:20 ` Peter De Schrijver
2014-07-09 11:08 ` Peter De Schrijver
2014-07-09 11:08 ` Peter De Schrijver
2014-07-09 11:08 ` Peter De Schrijver
[not found] ` <20140709110816.GF23218-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-07-09 12:04 ` Thierry Reding
2014-07-09 12:04 ` Thierry Reding
2014-07-09 12:04 ` Thierry Reding
2014-07-09 12:43 ` Peter De Schrijver
2014-07-09 12:43 ` Peter De Schrijver
2014-07-09 12:43 ` Peter De Schrijver
2014-07-09 12:56 ` Thierry Reding
2014-07-09 12:56 ` Thierry Reding
2014-07-09 12:56 ` Thierry Reding
2014-07-09 13:20 ` Peter De Schrijver
2014-07-09 13:20 ` Peter De Schrijver
2014-07-09 13:20 ` Peter De Schrijver
2014-07-09 14:42 ` Thierry Reding
2014-07-09 14:42 ` Thierry Reding
2014-07-09 14:42 ` Thierry Reding
2014-07-09 16:09 ` Peter De Schrijver
2014-07-09 16:09 ` Peter De Schrijver
2014-07-09 16:09 ` Peter De Schrijver
2014-06-04 11:32 ` [PATCH 7/9] ahci: Increase AHCI_MAX_CLKS to 4 Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
[not found] ` <1401881559-18469-8-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-16 22:04 ` Stephen Warren
2014-06-16 22:04 ` Stephen Warren
2014-06-16 22:04 ` Stephen Warren
2014-06-04 11:32 ` [PATCH 8/9] ata: Add support for the Tegra124 SATA controller Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
[not found] ` <1401881559-18469-9-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-05 12:18 ` Rob Herring
2014-06-05 12:18 ` Rob Herring
2014-06-05 12:18 ` Rob Herring
2014-06-05 12:59 ` Mikko Perttunen
2014-06-05 12:59 ` Mikko Perttunen
2014-06-05 12:59 ` Mikko Perttunen
2014-06-16 22:14 ` Stephen Warren
2014-06-16 22:14 ` Stephen Warren
2014-06-16 22:14 ` Stephen Warren
2014-06-17 12:14 ` Bartlomiej Zolnierkiewicz
2014-06-17 12:14 ` Bartlomiej Zolnierkiewicz
2014-06-17 12:14 ` Bartlomiej Zolnierkiewicz
2014-06-17 16:10 ` Stephen Warren
2014-06-17 16:10 ` Stephen Warren
2014-06-17 16:10 ` Stephen Warren
2014-06-17 16:13 ` Tejun Heo
2014-06-17 16:13 ` Tejun Heo
[not found] ` <20140617161320.GG31819-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-06-17 16:14 ` Tejun Heo
2014-06-17 16:14 ` Tejun Heo
2014-06-17 16:14 ` Tejun Heo
2014-06-17 16:23 ` Stephen Warren
2014-06-17 16:23 ` Stephen Warren
2014-06-17 16:23 ` Stephen Warren
2014-06-17 16:32 ` Tejun Heo
2014-06-17 16:32 ` Tejun Heo
2014-06-17 17:04 ` Bartlomiej Zolnierkiewicz
2014-06-17 17:04 ` Bartlomiej Zolnierkiewicz
2014-06-17 17:36 ` Mikko Perttunen
2014-06-17 17:36 ` Mikko Perttunen
[not found] ` <53A07CA4.7080206-/1wQRMveznE@public.gmane.org>
2014-06-17 17:37 ` Stephen Warren
2014-06-17 17:37 ` Stephen Warren
2014-06-17 17:37 ` Stephen Warren
2014-06-04 11:32 ` [PATCH 9/9] ARM: tegra: Add options for Tegra AHCI support to tegra_defconfig Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
2014-06-04 11:32 ` Mikko Perttunen
[not found] ` <1401881559-18469-1-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-05 17:29 ` [PATCH 0/9] Serial ATA support for NVIDIA Tegra124 Stephen Warren
2014-06-05 17:29 ` Stephen Warren
2014-06-05 17:29 ` Stephen Warren
[not found] ` <5390A8F9.2090408-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-06 6:27 ` Mikko Perttunen
2014-06-06 6:27 ` Mikko Perttunen
2014-06-06 6:27 ` Mikko Perttunen
2014-06-06 7:11 ` Thierry Reding
2014-06-06 7:11 ` Thierry Reding
2014-06-06 7:11 ` Thierry Reding
2014-06-06 7:18 ` Mikko Perttunen
2014-06-06 7:18 ` Mikko Perttunen
2014-06-06 7:18 ` Mikko Perttunen
[not found] ` <53915F3B.6050806-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-09 18:33 ` Stephen Warren
2014-06-09 18:33 ` Stephen Warren
2014-06-09 18:33 ` Stephen Warren
[not found] ` <5395FE0E.80105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-09 18:49 ` Mikko Perttunen
2014-06-09 18:49 ` Mikko Perttunen
2014-06-09 18:49 ` Mikko Perttunen
[not found] ` <539601B4.1010707-/1wQRMveznE@public.gmane.org>
2014-07-08 13:08 ` Thierry Reding
2014-07-08 13:08 ` Thierry Reding
2014-07-08 13:08 ` Thierry Reding
2014-07-08 13:34 ` Mikko Perttunen
2014-07-08 13:34 ` Mikko Perttunen
2014-07-08 13:34 ` Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617140146.GH3407@tbergstrom-lnx.Nvidia.com \
--to=pdeschrijver@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.