From: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: Anatoly Burakov
<anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2 0/2] Fix issues with VFIO
Date: Wed, 18 Jun 2014 09:44:18 -0400 [thread overview]
Message-ID: <20140618134417.GA3301@localhost.localdomain> (raw)
In-Reply-To: <cover.1403096022.git.anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Wed, Jun 18, 2014 at 02:07:17PM +0100, Anatoly Burakov wrote:
> This patchset fixes an issue with VFIO where DPDK initialization could
> fail even if the user didn't want to use VFIO in the first place. Also,
> more verbose and descriptive error messages were added to VFIO code, for
> example distinguishing between a failed ioctl() call and an unsupported
> VFIO API version.
>
> Anatoly Burakov (2):
> vfio: open VFIO container at startup rather than during init
> vfio: more verbose error messages
>
You still need a changelog entry with each patch (the cover letter doesn't get
included with the patches in git). You also probably want to mention that the
second patch also fixes a case in which syscall errors are erroneously treated
as a success case
Neil
> lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 63 ++++++++++++++++--------------
> 1 file changed, 34 insertions(+), 29 deletions(-)
>
> --
> 1.8.1.4
>
>
next prev parent reply other threads:[~2014-06-18 13:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 9:12 [PATCH] vfio: open VFIO container at startup rather than during init Anatoly Burakov
[not found] ` <4bf447650cc99e316e6427e3a1c134dd417af4ec.1402996488.git.anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-17 16:50 ` Richardson, Bruce
2014-06-17 16:55 ` Thomas Monjalon
2014-06-18 8:57 ` Burakov, Anatoly
[not found] ` <C6ECDF3AB251BE4894318F4E451236976CC9CB58-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-18 10:08 ` Dumitrescu, Cristian
[not found] ` <3EB4FA525960D640B5BDFFD6A3D891261B1C6009-kPTMFJFq+rFP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-18 10:26 ` Burakov, Anatoly
[not found] ` <C6ECDF3AB251BE4894318F4E451236976CC9CCAC-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-18 11:00 ` Neil Horman
[not found] ` <20140618110018.GA7587-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-06-18 11:02 ` Burakov, Anatoly
[not found] ` <C6ECDF3AB251BE4894318F4E451236976CC9CCF3-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-18 11:07 ` Neil Horman
2014-06-18 13:07 ` [PATCH v2 0/2] Fix issues with VFIO Anatoly Burakov
[not found] ` <cover.1403104031.git.anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-18 17:55 ` [PATCH v3 " Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B01AA37B5B-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-18 23:09 ` Thomas Monjalon
2014-06-18 18:51 ` Neil Horman
2014-06-18 13:07 ` [PATCH v2 1/2] vfio: open VFIO container at startup rather than during init Anatoly Burakov
2014-06-18 13:07 ` [PATCH v2 2/2] vfio: more verbose error messages Anatoly Burakov
[not found] ` <cover.1403096022.git.anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-18 13:44 ` Neil Horman [this message]
2014-06-18 15:07 ` [PATCH v3 0/2] Fix issues with VFIO Anatoly Burakov
2014-06-18 15:07 ` [PATCH v3 1/2] vfio: open VFIO container at startup rather than during init Anatoly Burakov
2014-06-18 15:07 ` [PATCH v3 2/2] vfio: more verbose error messages Anatoly Burakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618134417.GA3301@localhost.localdomain \
--to=nhorman-2xusbdqka4r54taoqtywwq@public.gmane.org \
--cc=anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.