* [PATCH] drm/fb-helper: Return correct type to match drm_fb_helper_debug_enter() prototype
@ 2014-06-19 2:50 Liu Ying
2014-06-19 7:01 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Liu Ying @ 2014-06-19 2:50 UTC (permalink / raw)
To: dri-devel
The return type of drm_fb_helper_debug_enter() is int, so we should return '0'
instead of 'false'.
Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
---
drivers/gpu/drm/drm_fb_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index d5d8cea..8daa4ad 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -200,7 +200,7 @@ int drm_fb_helper_debug_enter(struct fb_info *info)
int i;
if (list_empty(&kernel_fb_helper_list))
- return false;
+ return 0;
list_for_each_entry(helper, &kernel_fb_helper_list, kernel_fb_list) {
for (i = 0; i < helper->crtc_count; i++) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/fb-helper: Return correct type to match drm_fb_helper_debug_enter() prototype
2014-06-19 2:50 [PATCH] drm/fb-helper: Return correct type to match drm_fb_helper_debug_enter() prototype Liu Ying
@ 2014-06-19 7:01 ` Daniel Vetter
2014-06-19 7:24 ` Liu Ying
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2014-06-19 7:01 UTC (permalink / raw)
To: Liu Ying; +Cc: dri-devel
On Thu, Jun 19, 2014 at 10:50:31AM +0800, Liu Ying wrote:
> The return type of drm_fb_helper_debug_enter() is int, so we should return '0'
> instead of 'false'.
>
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
> ---
> drivers/gpu/drm/drm_fb_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index d5d8cea..8daa4ad 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -200,7 +200,7 @@ int drm_fb_helper_debug_enter(struct fb_info *info)
> int i;
>
> if (list_empty(&kernel_fb_helper_list))
> - return false;
> + return 0;
Actually we can remove the entire if check since list_for_each_entry is a
no-op on an empty list, and then we'll fall right through to the return 0;
at the end of the function. Care to respin your patch?
-Daniel
>
> list_for_each_entry(helper, &kernel_fb_helper_list, kernel_fb_list) {
> for (i = 0; i < helper->crtc_count; i++) {
> --
> 1.7.9.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/fb-helper: Return correct type to match drm_fb_helper_debug_enter() prototype
2014-06-19 7:01 ` Daniel Vetter
@ 2014-06-19 7:24 ` Liu Ying
0 siblings, 0 replies; 3+ messages in thread
From: Liu Ying @ 2014-06-19 7:24 UTC (permalink / raw)
To: Daniel Vetter, Liu Ying; +Cc: dri-devel
On 06/19/2014 03:01 PM, Daniel Vetter wrote:
> On Thu, Jun 19, 2014 at 10:50:31AM +0800, Liu Ying wrote:
>> The return type of drm_fb_helper_debug_enter() is int, so we should return '0'
>> instead of 'false'.
>>
>> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
>> ---
>> drivers/gpu/drm/drm_fb_helper.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
>> index d5d8cea..8daa4ad 100644
>> --- a/drivers/gpu/drm/drm_fb_helper.c
>> +++ b/drivers/gpu/drm/drm_fb_helper.c
>> @@ -200,7 +200,7 @@ int drm_fb_helper_debug_enter(struct fb_info *info)
>> int i;
>>
>> if (list_empty(&kernel_fb_helper_list))
>> - return false;
>> + return 0;
>
> Actually we can remove the entire if check since list_for_each_entry is a
> no-op on an empty list, and then we'll fall right through to the return 0;
> at the end of the function. Care to respin your patch?
> -Daniel
Ok, I will respin my patch. Thanks.
Liu Ying
>
>>
>> list_for_each_entry(helper, &kernel_fb_helper_list, kernel_fb_list) {
>> for (i = 0; i < helper->crtc_count; i++) {
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-19 7:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-19 2:50 [PATCH] drm/fb-helper: Return correct type to match drm_fb_helper_debug_enter() prototype Liu Ying
2014-06-19 7:01 ` Daniel Vetter
2014-06-19 7:24 ` Liu Ying
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.