From: Thierry Reding <thierry.reding@gmail.com> To: Alban Bedel <alban.bedel@avionic-design.de> Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panel: add support for Innolux N156BGE-L21 panel Date: Fri, 20 Jun 2014 22:14:57 +0200 [thread overview] Message-ID: <20140620201456.GA28814@mithrandir> (raw) In-Reply-To: <1402585745-28127-1-git-send-email-alban.bedel@avionic-design.de> [-- Attachment #1: Type: text/plain, Size: 1968 bytes --] On Thu, Jun 12, 2014 at 05:09:05PM +0200, Alban Bedel wrote: > This panel is used by the Medcom Wide and supported by the > simple-panel driver. > > Signed-off-by: Alban Bedel <alban.bedel@avionic-design.de> > --- > drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 309f29e..6a361bb 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -372,6 +372,28 @@ static const struct panel_desc samsung_ltn101nt05 = { > }, > }; > > +static const struct drm_display_mode innolux_n156bge_l21_mode = { > + .clock = 69300, > + .hdisplay = 1366, > + .hsync_start = 1366, > + .hsync_end = 1366, > + .htotal = 1366 + 100, > + .vdisplay = 768, > + .vsync_start = 768, > + .vsync_end = 768, > + .vtotal = 768 + 20, The timings here look slightly strange. Typically .{h,v}display < .{h,v}sync_start < .{h,v}hsync_end < .{h,v}total Given your timings above essentially means that the vsync pulse starts immediately after the last active pixel or line and is of length zero. > + .vrefresh = 60, > +}; > + > +static const struct panel_desc innolux_n156bge_l21 = { > + .modes = &innolux_n156bge_l21_mode, > + .num_modes = 1, > + .size = { > + .width = 1366, > + .height = 768, This size is the physical size (in mm) of the active area of the panel. > + }, > +}; > + > static const struct of_device_id platform_of_match[] = { > { > .compatible = "auo,b101aw03", > @@ -389,6 +411,9 @@ static const struct of_device_id platform_of_match[] = { > .compatible = "samsung,ltn101nt05", > .data = &samsung_ltn101nt05, > }, { > + .compatible = "innolux,n156bge-l21", > + .data = &innolux_n156bge_l21, > + }, { This patch should also be adding a device tree binding document for this panel. Thierry [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com> To: Alban Bedel <alban.bedel@avionic-design.de> Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/panel: add support for Innolux N156BGE-L21 panel Date: Fri, 20 Jun 2014 22:14:57 +0200 [thread overview] Message-ID: <20140620201456.GA28814@mithrandir> (raw) In-Reply-To: <1402585745-28127-1-git-send-email-alban.bedel@avionic-design.de> [-- Attachment #1.1: Type: text/plain, Size: 1968 bytes --] On Thu, Jun 12, 2014 at 05:09:05PM +0200, Alban Bedel wrote: > This panel is used by the Medcom Wide and supported by the > simple-panel driver. > > Signed-off-by: Alban Bedel <alban.bedel@avionic-design.de> > --- > drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 309f29e..6a361bb 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -372,6 +372,28 @@ static const struct panel_desc samsung_ltn101nt05 = { > }, > }; > > +static const struct drm_display_mode innolux_n156bge_l21_mode = { > + .clock = 69300, > + .hdisplay = 1366, > + .hsync_start = 1366, > + .hsync_end = 1366, > + .htotal = 1366 + 100, > + .vdisplay = 768, > + .vsync_start = 768, > + .vsync_end = 768, > + .vtotal = 768 + 20, The timings here look slightly strange. Typically .{h,v}display < .{h,v}sync_start < .{h,v}hsync_end < .{h,v}total Given your timings above essentially means that the vsync pulse starts immediately after the last active pixel or line and is of length zero. > + .vrefresh = 60, > +}; > + > +static const struct panel_desc innolux_n156bge_l21 = { > + .modes = &innolux_n156bge_l21_mode, > + .num_modes = 1, > + .size = { > + .width = 1366, > + .height = 768, This size is the physical size (in mm) of the active area of the panel. > + }, > +}; > + > static const struct of_device_id platform_of_match[] = { > { > .compatible = "auo,b101aw03", > @@ -389,6 +411,9 @@ static const struct of_device_id platform_of_match[] = { > .compatible = "samsung,ltn101nt05", > .data = &samsung_ltn101nt05, > }, { > + .compatible = "innolux,n156bge-l21", > + .data = &innolux_n156bge_l21, > + }, { This patch should also be adding a device tree binding document for this panel. Thierry [-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-06-20 20:15 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-12 15:09 [PATCH] drm/panel: add support for Innolux N156BGE-L21 panel Alban Bedel 2014-06-20 20:14 ` Thierry Reding [this message] 2014-06-20 20:14 ` Thierry Reding 2014-07-22 6:38 ` [PATCH v2] drm/panel: add support for InnoLux " Alban Bedel 2014-07-22 8:15 ` Thierry Reding 2014-07-22 8:15 ` Thierry Reding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140620201456.GA28814@mithrandir \ --to=thierry.reding@gmail.com \ --cc=airlied@linux.ie \ --cc=alban.bedel@avionic-design.de \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.