[PATCH][net-next] bridge: use list_for_each_entry_continue_reverse

[PATCH][net-next] bridge: use list_for_each_entry_continue_reverse

[roy.qing.li]

From: Li RongQing <roy.qing.li@gmail.com>

use list_for_each_entry_continue_reverse to rollback in fdb_add_hw
when add address failed

Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
---
 net/bridge/br_fdb.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index b524c36..7be3366 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -93,7 +93,7 @@ static void fdb_rcu_free(struct rcu_head *head)
 static void fdb_add_hw(struct net_bridge *br, const unsigned char *addr)
 {
 	int err;
-	struct net_bridge_port *p, *tmp;
+	struct net_bridge_port *p;
 
 	ASSERT_RTNL();
 
@@ -107,11 +107,9 @@ static void fdb_add_hw(struct net_bridge *br, const unsigned char *addr)
 
 	return;
 undo:
-	list_for_each_entry(tmp, &br->port_list, list) {
-		if (tmp == p)
-			break;
-		if (!br_promisc_port(tmp))
-			dev_uc_del(tmp->dev, addr);
+	list_for_each_entry_continue_reverse(p, &br->port_list, list) {
+		if (!br_promisc_port(p))
+			dev_uc_del(p->dev, addr);
 	}
 }
 
-- 
1.7.10.4

Re: [PATCH][net-next] bridge: use list_for_each_entry_continue_reverse

[David Miller]

From: roy.qing.li@gmail.com
Date: Wed, 18 Jun 2014 16:07:16 +0800

> From: Li RongQing <roy.qing.li@gmail.com>
> 
> use list_for_each_entry_continue_reverse to rollback in fdb_add_hw
> when add address failed
> 
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>

Applied to net-next, thanks.