* [PATCH 1/2] SOUND: TLV320AIC32x4: Fixed Coding style Issues
@ 2014-06-13 5:48 Shahina Shaik
2014-06-13 5:48 ` [PATCH 2/2] SOUND: TLV320AIC32x4: Fixed Coding Style Issues Shahina Shaik
2014-06-22 11:04 ` [PATCH 1/2] SOUND: TLV320AIC32x4: Fixed Coding style Issues Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Shahina Shaik @ 2014-06-13 5:48 UTC (permalink / raw)
To: perex, tiwai, alsa-devel, linux-kernel, broonie, lgirdwood
Cc: sharab.shaik, shahina.s
From: Shahina Shaik <sharab.shaik@gmail.com>
Fixed a brace coding style issue in the tlv320aic32x4.c
Signed-off-by: Shahina Shaik <sharab.shaik@gmail.com>
---
sound/soc/codecs/tlv320aic32x4.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c
index 1d9b117..1e50f15 100644
--- a/sound/soc/codecs/tlv320aic32x4.c
+++ b/sound/soc/codecs/tlv320aic32x4.c
@@ -626,21 +626,18 @@ static int aic32x4_probe(struct snd_soc_codec *codec)
snd_soc_write(codec, AIC32X4_MICBIAS, AIC32X4_MICBIAS_LDOIN |
AIC32X4_MICBIAS_2075V);
}
- if (aic32x4->power_cfg & AIC32X4_PWR_AVDD_DVDD_WEAK_DISABLE) {
+ if (aic32x4->power_cfg & AIC32X4_PWR_AVDD_DVDD_WEAK_DISABLE)
snd_soc_write(codec, AIC32X4_PWRCFG, AIC32X4_AVDDWEAKDISABLE);
- }
tmp_reg = (aic32x4->power_cfg & AIC32X4_PWR_AIC32X4_LDO_ENABLE) ?
AIC32X4_LDOCTLEN : 0;
snd_soc_write(codec, AIC32X4_LDOCTL, tmp_reg);
tmp_reg = snd_soc_read(codec, AIC32X4_CMMODE);
- if (aic32x4->power_cfg & AIC32X4_PWR_CMMODE_LDOIN_RANGE_18_36) {
+ if (aic32x4->power_cfg & AIC32X4_PWR_CMMODE_LDOIN_RANGE_18_36)
tmp_reg |= AIC32X4_LDOIN_18_36;
- }
- if (aic32x4->power_cfg & AIC32X4_PWR_CMMODE_HP_LDOIN_POWERED) {
+ if (aic32x4->power_cfg & AIC32X4_PWR_CMMODE_HP_LDOIN_POWERED)
tmp_reg |= AIC32X4_LDOIN2HP;
- }
snd_soc_write(codec, AIC32X4_CMMODE, tmp_reg);
/* Mic PGA routing */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] SOUND: TLV320AIC32x4: Fixed Coding Style Issues
2014-06-13 5:48 [PATCH 1/2] SOUND: TLV320AIC32x4: Fixed Coding style Issues Shahina Shaik
@ 2014-06-13 5:48 ` Shahina Shaik
2014-06-22 11:04 ` Mark Brown
2014-06-22 11:04 ` [PATCH 1/2] SOUND: TLV320AIC32x4: Fixed Coding style Issues Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Shahina Shaik @ 2014-06-13 5:48 UTC (permalink / raw)
To: perex, tiwai, alsa-devel, linux-kernel, broonie, lgirdwood
Cc: sharab.shaik, shahina.s
From: Shahina Shaik <sharab.shaik@gmail.com>
Fixed Coding style issues of lines over 80 characters.
Signed-off-by: Shahina Shaik <sharab.shaik@gmail.com>
---
sound/soc/codecs/tlv320aic32x4.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c
index 1e50f15..89e41d2 100644
--- a/sound/soc/codecs/tlv320aic32x4.c
+++ b/sound/soc/codecs/tlv320aic32x4.c
@@ -642,13 +642,17 @@ static int aic32x4_probe(struct snd_soc_codec *codec)
/* Mic PGA routing */
if (aic32x4->micpga_routing & AIC32X4_MICPGA_ROUTE_LMIC_IN2R_10K)
- snd_soc_write(codec, AIC32X4_LMICPGANIN, AIC32X4_LMICPGANIN_IN2R_10K);
+ snd_soc_write(codec, AIC32X4_LMICPGANIN,
+ AIC32X4_LMICPGANIN_IN2R_10K);
else
- snd_soc_write(codec, AIC32X4_LMICPGANIN, AIC32X4_LMICPGANIN_CM1L_10K);
+ snd_soc_write(codec, AIC32X4_LMICPGANIN,
+ AIC32X4_LMICPGANIN_CM1L_10K);
if (aic32x4->micpga_routing & AIC32X4_MICPGA_ROUTE_RMIC_IN1L_10K)
- snd_soc_write(codec, AIC32X4_RMICPGANIN, AIC32X4_RMICPGANIN_IN1L_10K);
+ snd_soc_write(codec, AIC32X4_RMICPGANIN,
+ AIC32X4_RMICPGANIN_IN1L_10K);
else
- snd_soc_write(codec, AIC32X4_RMICPGANIN, AIC32X4_RMICPGANIN_CM1R_10K);
+ snd_soc_write(codec, AIC32X4_RMICPGANIN,
+ AIC32X4_RMICPGANIN_CM1R_10K);
aic32x4_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] SOUND: TLV320AIC32x4: Fixed Coding style Issues
2014-06-13 5:48 [PATCH 1/2] SOUND: TLV320AIC32x4: Fixed Coding style Issues Shahina Shaik
2014-06-13 5:48 ` [PATCH 2/2] SOUND: TLV320AIC32x4: Fixed Coding Style Issues Shahina Shaik
@ 2014-06-22 11:04 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-06-22 11:04 UTC (permalink / raw)
To: Shahina Shaik
Cc: perex, tiwai, alsa-devel, linux-kernel, lgirdwood, sharab.shaik,
shahina.s
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
On Fri, Jun 13, 2014 at 11:18:47AM +0530, Shahina Shaik wrote:
> From: Shahina Shaik <sharab.shaik@gmail.com>
>
> Fixed a brace coding style issue in the tlv320aic32x4.c
Applied, thanks. Please try to use changelogs matching the normal style
for the subsystem.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] SOUND: TLV320AIC32x4: Fixed Coding Style Issues
2014-06-13 5:48 ` [PATCH 2/2] SOUND: TLV320AIC32x4: Fixed Coding Style Issues Shahina Shaik
@ 2014-06-22 11:04 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-06-22 11:04 UTC (permalink / raw)
To: Shahina Shaik
Cc: perex, tiwai, alsa-devel, linux-kernel, lgirdwood, sharab.shaik,
shahina.s
[-- Attachment #1: Type: text/plain, Size: 194 bytes --]
On Fri, Jun 13, 2014 at 11:18:48AM +0530, Shahina Shaik wrote:
> From: Shahina Shaik <sharab.shaik@gmail.com>
>
> Fixed Coding style issues of lines over 80 characters.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-22 11:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-13 5:48 [PATCH 1/2] SOUND: TLV320AIC32x4: Fixed Coding style Issues Shahina Shaik
2014-06-13 5:48 ` [PATCH 2/2] SOUND: TLV320AIC32x4: Fixed Coding Style Issues Shahina Shaik
2014-06-22 11:04 ` Mark Brown
2014-06-22 11:04 ` [PATCH 1/2] SOUND: TLV320AIC32x4: Fixed Coding style Issues Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.