From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>, Tejun Heo <tj@kernel.org>,
Vladimir Davydov <vdavydov@parallels.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm] memcg: mem_cgroup_charge_statistics needs preempt_disable
Date: Mon, 23 Jun 2014 00:16:21 -0400 [thread overview]
Message-ID: <20140623041621.GM7331@cmpxchg.org> (raw)
In-Reply-To: <1403282171-25502-1-git-send-email-mhocko@suse.cz>
On Fri, Jun 20, 2014 at 06:36:11PM +0200, Michal Hocko wrote:
> preempt_disable was previously disabled by lock_page_cgroup which has
> been removed by "mm: memcontrol: rewrite uncharge API".
>
> This fixes the a flood of splats like this:
> [ 3.149371] BUG: using __this_cpu_add() in preemptible [00000000] code: udevd/1271
> [ 3.151458] caller is __this_cpu_preempt_check+0x13/0x15
> [ 3.152927] CPU: 0 PID: 1271 Comm: udevd Not tainted 3.15.0-test1 #366
> [ 3.154637] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
> [ 3.156788] 0000000000000000 ffff88000005fba8 ffffffff814efe3f 0000000000000000
> [ 3.158810] ffff88000005fbd8 ffffffff8125b969 ffff880007413448 0000000000000001
> [ 3.160836] ffffea00001e8c00 0000000000000001 ffff88000005fbe8 ffffffff8125b9a8
> [ 3.162950] Call Trace:
> [ 3.163598] [<ffffffff814efe3f>] dump_stack+0x4e/0x7a
> [ 3.164942] [<ffffffff8125b969>] check_preemption_disabled+0xd2/0xe5
> [ 3.166618] [<ffffffff8125b9a8>] __this_cpu_preempt_check+0x13/0x15
> [ 3.168267] [<ffffffff8112b630>] mem_cgroup_charge_statistics.isra.36+0xb5/0xc6
> [ 3.170169] [<ffffffff8112d2c5>] commit_charge+0x23c/0x256
> [ 3.171823] [<ffffffff8113101b>] mem_cgroup_commit_charge+0xb8/0xd7
> [ 3.173838] [<ffffffff810f5dab>] shmem_getpage_gfp+0x399/0x605
> [ 3.175363] [<ffffffff810f7456>] shmem_write_begin+0x3d/0x58
> [ 3.176854] [<ffffffff810e1361>] generic_perform_write+0xbc/0x192
> [ 3.178445] [<ffffffff8114a086>] ? file_update_time+0x34/0xac
> [ 3.179952] [<ffffffff810e2ae4>] __generic_file_aio_write+0x2c0/0x300
> [ 3.181655] [<ffffffff810e2b76>] generic_file_aio_write+0x52/0xbd
> [ 3.183234] [<ffffffff81133944>] do_sync_write+0x59/0x78
> [ 3.184630] [<ffffffff81133ea8>] vfs_write+0xc4/0x181
> [ 3.185957] [<ffffffff81134801>] SyS_write+0x4a/0x91
> [ 3.187258] [<ffffffff814fd30e>] tracesys+0xd0/0xd5
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
Thanks, Michal.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>, Tejun Heo <tj@kernel.org>,
Vladimir Davydov <vdavydov@parallels.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm] memcg: mem_cgroup_charge_statistics needs preempt_disable
Date: Mon, 23 Jun 2014 00:16:21 -0400 [thread overview]
Message-ID: <20140623041621.GM7331@cmpxchg.org> (raw)
In-Reply-To: <1403282171-25502-1-git-send-email-mhocko@suse.cz>
On Fri, Jun 20, 2014 at 06:36:11PM +0200, Michal Hocko wrote:
> preempt_disable was previously disabled by lock_page_cgroup which has
> been removed by "mm: memcontrol: rewrite uncharge API".
>
> This fixes the a flood of splats like this:
> [ 3.149371] BUG: using __this_cpu_add() in preemptible [00000000] code: udevd/1271
> [ 3.151458] caller is __this_cpu_preempt_check+0x13/0x15
> [ 3.152927] CPU: 0 PID: 1271 Comm: udevd Not tainted 3.15.0-test1 #366
> [ 3.154637] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
> [ 3.156788] 0000000000000000 ffff88000005fba8 ffffffff814efe3f 0000000000000000
> [ 3.158810] ffff88000005fbd8 ffffffff8125b969 ffff880007413448 0000000000000001
> [ 3.160836] ffffea00001e8c00 0000000000000001 ffff88000005fbe8 ffffffff8125b9a8
> [ 3.162950] Call Trace:
> [ 3.163598] [<ffffffff814efe3f>] dump_stack+0x4e/0x7a
> [ 3.164942] [<ffffffff8125b969>] check_preemption_disabled+0xd2/0xe5
> [ 3.166618] [<ffffffff8125b9a8>] __this_cpu_preempt_check+0x13/0x15
> [ 3.168267] [<ffffffff8112b630>] mem_cgroup_charge_statistics.isra.36+0xb5/0xc6
> [ 3.170169] [<ffffffff8112d2c5>] commit_charge+0x23c/0x256
> [ 3.171823] [<ffffffff8113101b>] mem_cgroup_commit_charge+0xb8/0xd7
> [ 3.173838] [<ffffffff810f5dab>] shmem_getpage_gfp+0x399/0x605
> [ 3.175363] [<ffffffff810f7456>] shmem_write_begin+0x3d/0x58
> [ 3.176854] [<ffffffff810e1361>] generic_perform_write+0xbc/0x192
> [ 3.178445] [<ffffffff8114a086>] ? file_update_time+0x34/0xac
> [ 3.179952] [<ffffffff810e2ae4>] __generic_file_aio_write+0x2c0/0x300
> [ 3.181655] [<ffffffff810e2b76>] generic_file_aio_write+0x52/0xbd
> [ 3.183234] [<ffffffff81133944>] do_sync_write+0x59/0x78
> [ 3.184630] [<ffffffff81133ea8>] vfs_write+0xc4/0x181
> [ 3.185957] [<ffffffff81134801>] SyS_write+0x4a/0x91
> [ 3.187258] [<ffffffff814fd30e>] tracesys+0xd0/0xd5
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
Thanks, Michal.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-06-23 4:16 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 20:40 [patch 00/13] mm: memcontrol: naturalize charge lifetime v4 Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-18 20:40 ` [patch 01/13] mm: memcontrol: fold mem_cgroup_do_charge() Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-18 20:40 ` [patch 02/13] mm: memcontrol: rearrange charging fast path Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-18 20:40 ` [patch 03/13] mm: memcontrol: reclaim at least once for __GFP_NORETRY Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-18 20:40 ` [patch 04/13] mm: huge_memory: use GFP_TRANSHUGE when charging huge pages Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-18 20:40 ` [patch 05/13] mm: memcontrol: retry reclaim for oom-disabled and __GFP_NOFAIL charges Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-18 20:40 ` [patch 06/13] mm: memcontrol: remove explicit OOM parameter in charge path Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-18 20:40 ` [patch 07/13] mm: memcontrol: simplify move precharge function Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-18 20:40 ` [patch 08/13] mm: memcontrol: catch root bypass in move precharge Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-18 20:40 ` [patch 09/13] mm: memcontrol: use root_mem_cgroup res_counter Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-18 20:40 ` [patch 10/13] mm: memcontrol: remove ordering between pc->mem_cgroup and PageCgroupUsed Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-18 20:40 ` [patch 11/13] mm: memcontrol: do not acquire page_cgroup lock for kmem pages Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-18 20:40 ` [patch 12/13] mm: memcontrol: rewrite charge API Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-23 6:15 ` Uwe Kleine-König
2014-06-23 6:15 ` Uwe Kleine-König
2014-06-23 6:15 ` Uwe Kleine-König
2014-06-23 9:30 ` Michal Hocko
2014-06-23 9:30 ` Michal Hocko
2014-06-23 9:30 ` Michal Hocko
2014-06-23 9:42 ` Uwe Kleine-König
2014-06-23 9:42 ` Uwe Kleine-König
2014-06-23 9:42 ` Uwe Kleine-König
2014-07-14 15:04 ` Michal Hocko
2014-07-14 15:04 ` Michal Hocko
2014-07-14 15:04 ` Michal Hocko
2014-07-14 17:13 ` Johannes Weiner
2014-07-14 17:13 ` Johannes Weiner
2014-07-14 18:43 ` Michal Hocko
2014-07-14 18:43 ` Michal Hocko
2014-06-18 20:40 ` [patch 13/13] mm: memcontrol: rewrite uncharge API Johannes Weiner
2014-06-18 20:40 ` Johannes Weiner
2014-06-20 16:36 ` [PATCH -mm] memcg: mem_cgroup_charge_statistics needs preempt_disable Michal Hocko
2014-06-20 16:36 ` Michal Hocko
2014-06-23 4:16 ` Johannes Weiner [this message]
2014-06-23 4:16 ` Johannes Weiner
2014-06-21 0:34 ` [patch 13/13] mm: memcontrol: rewrite uncharge API Sasha Levin
2014-06-21 0:34 ` Sasha Levin
2014-06-21 0:56 ` Andrew Morton
2014-06-21 0:56 ` Andrew Morton
2014-06-21 0:56 ` Andrew Morton
2014-06-21 1:03 ` Sasha Levin
2014-06-21 1:03 ` Sasha Levin
2014-07-15 8:25 ` Michal Hocko
2014-07-15 8:25 ` Michal Hocko
2014-07-15 8:25 ` Michal Hocko
2014-07-15 12:19 ` Michal Hocko
2014-07-15 12:19 ` Michal Hocko
2014-07-18 7:12 ` Michal Hocko
2014-07-18 7:12 ` Michal Hocko
2014-07-18 14:45 ` Johannes Weiner
2014-07-18 14:45 ` Johannes Weiner
2014-07-18 14:45 ` Johannes Weiner
2014-07-18 15:12 ` Miklos Szeredi
2014-07-18 15:12 ` Miklos Szeredi
2014-07-19 17:39 ` Johannes Weiner
2014-07-19 17:39 ` Johannes Weiner
2014-07-19 17:39 ` Johannes Weiner
2014-07-22 15:08 ` Michal Hocko
2014-07-22 15:08 ` Michal Hocko
2014-07-22 15:44 ` Miklos Szeredi
2014-07-22 15:44 ` Miklos Szeredi
2014-07-22 15:44 ` Miklos Szeredi
2014-07-23 14:38 ` Michal Hocko
2014-07-23 14:38 ` Michal Hocko
2014-07-23 14:38 ` Michal Hocko
2014-07-23 15:06 ` Johannes Weiner
2014-07-23 15:06 ` Johannes Weiner
2014-07-23 15:19 ` Michal Hocko
2014-07-23 15:19 ` Michal Hocko
2014-07-23 15:19 ` Michal Hocko
2014-07-23 15:36 ` Johannes Weiner
2014-07-23 15:36 ` Johannes Weiner
2014-07-23 18:08 ` Miklos Szeredi
2014-07-23 18:08 ` Miklos Szeredi
2014-07-23 21:02 ` Johannes Weiner
2014-07-23 21:02 ` Johannes Weiner
2014-07-23 21:02 ` Johannes Weiner
2014-07-24 8:46 ` Michal Hocko
2014-07-24 8:46 ` Michal Hocko
2014-07-24 9:02 ` Michal Hocko
2014-07-24 9:02 ` Michal Hocko
2014-07-24 9:02 ` Michal Hocko
2014-07-25 15:26 ` Johannes Weiner
2014-07-25 15:26 ` Johannes Weiner
2014-07-25 15:26 ` Johannes Weiner
2014-07-25 15:43 ` Michal Hocko
2014-07-25 15:43 ` Michal Hocko
2014-07-25 17:34 ` Johannes Weiner
2014-07-25 17:34 ` Johannes Weiner
2014-07-15 14:23 ` Michal Hocko
2014-07-15 14:23 ` Michal Hocko
2014-07-15 14:23 ` Michal Hocko
2014-07-15 15:09 ` Johannes Weiner
2014-07-15 15:09 ` Johannes Weiner
2014-07-15 15:18 ` Michal Hocko
2014-07-15 15:18 ` Michal Hocko
2014-07-15 15:46 ` Johannes Weiner
2014-07-15 15:46 ` Johannes Weiner
2014-07-15 15:56 ` Michal Hocko
2014-07-15 15:56 ` Michal Hocko
2014-07-15 15:55 ` Naoya Horiguchi
2014-07-15 15:55 ` Naoya Horiguchi
2014-07-15 16:07 ` Michal Hocko
2014-07-15 16:07 ` Michal Hocko
2014-07-15 17:34 ` Johannes Weiner
2014-07-15 17:34 ` Johannes Weiner
2014-07-15 17:34 ` Johannes Weiner
2014-07-15 18:21 ` Michal Hocko
2014-07-15 18:21 ` Michal Hocko
2014-07-15 18:21 ` Michal Hocko
2014-07-15 18:43 ` Naoya Horiguchi
2014-07-15 18:43 ` Naoya Horiguchi
2014-07-15 19:04 ` Johannes Weiner
2014-07-15 19:04 ` Johannes Weiner
2014-07-15 19:04 ` Johannes Weiner
2014-07-15 20:49 ` Naoya Horiguchi
2014-07-15 20:49 ` Naoya Horiguchi
2014-07-15 21:48 ` Johannes Weiner
2014-07-15 21:48 ` Johannes Weiner
2014-07-16 7:55 ` Michal Hocko
2014-07-16 7:55 ` Michal Hocko
2014-07-16 13:30 ` Naoya Horiguchi
2014-07-16 13:30 ` Naoya Horiguchi
2014-07-16 14:14 ` Johannes Weiner
2014-07-16 14:14 ` Johannes Weiner
2014-07-16 14:57 ` Naoya Horiguchi
2014-07-16 14:57 ` Naoya Horiguchi
2014-07-16 14:57 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623041621.GM7331@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.