From: Peter Zijlstra <peterz@infradead.org>
To: Rik van Riel <riel@redhat.com>
Cc: linux-kernel@vger.kernel.org, chegu_vinod@hp.com,
mgorman@suse.de, mingo@kernel.org
Subject: Re: [PATCH 9/7] sched,numa: remove task_h_load from task_numa_compare
Date: Wed, 25 Jun 2014 07:31:38 +0200 [thread overview]
Message-ID: <20140625053138.GF6758@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <53AA5D2C.9000401@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
On Wed, Jun 25, 2014 at 01:25:00AM -0400, Rik van Riel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 06/25/2014 01:21 AM, Peter Zijlstra wrote:
> > On Wed, Jun 25, 2014 at 07:07:35AM +0200, Peter Zijlstra wrote:
> >> Shall I merge this into patch 3?
> >
> > Which gets me the below; which is has a wrong changelog.
> >
> > task_h_load() already computes the load as seen from the root
> > group. effective_load() just does a better (and more expensive) job
> > of computing the task movement implications of a move.
> >
> > So the total effect of this patch shouldn't be very big; regular
> > load balancing also only uses task_h_load(), see move_tasks().
> >
> > Now, we don't run with preemption disabled, don't run as often,
> > etc.., so maybe we can indeed use the more expensive variant just
> > fine, but does it really matter?
>
> In my testing, it appears to make a difference between workloads
> converging, and workloads sitting with one last thread stuck on
> another node that never gets moved...
Fair enough; can you provide a new Changelog that I can paste in?
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-06-25 5:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 15:41 [PATCH 0/7] sched,numa: improve NUMA convergence times riel
2014-06-23 15:41 ` [PATCH 1/7] sched,numa: use group's max nid as task's preferred nid riel
2014-06-25 10:31 ` Mel Gorman
2014-07-05 10:44 ` [tip:sched/core] sched/numa: Use group's max nid as task' s " tip-bot for Rik van Riel
2014-06-23 15:41 ` [PATCH 3/7] sched,numa: use effective_load to balance NUMA loads riel
2014-06-23 15:41 ` [PATCH 4/7] sched,numa: simplify task_numa_compare riel
2014-06-25 10:39 ` Mel Gorman
2014-06-23 15:41 ` [PATCH 5/7] sched,numa: examine a task move when examining a task swap riel
2014-06-23 15:41 ` [PATCH 6/7] sched,numa: rework best node setting in task_numa_migrate riel
2014-07-05 10:45 ` [tip:sched/core] sched/numa: Rework best node setting in task_numa_migrate() tip-bot for Rik van Riel
2014-06-23 15:41 ` [PATCH 7/7] sched,numa: change scan period code to match intent riel
2014-06-25 10:19 ` Mel Gorman
2014-07-05 10:45 ` [tip:sched/core] sched/numa: Change " tip-bot for Rik van Riel
2014-06-23 22:30 ` [PATCH 8/7] sched,numa: do not let a move increase the imbalance Rik van Riel
2014-06-24 14:38 ` Peter Zijlstra
2014-06-24 15:30 ` Rik van Riel
2014-06-25 1:57 ` Rik van Riel
2014-06-24 19:14 ` [PATCH 9/7] sched,numa: remove task_h_load from task_numa_compare Rik van Riel
2014-06-25 5:07 ` Peter Zijlstra
2014-06-25 5:09 ` Rik van Riel
2014-06-25 5:21 ` Peter Zijlstra
2014-06-25 5:25 ` Rik van Riel
2014-06-25 5:31 ` Peter Zijlstra [this message]
2014-06-25 5:39 ` Rik van Riel
2014-06-25 5:57 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140625053138.GF6758@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=chegu_vinod@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.