All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [RFT][PATCH] hwmon: (w83l786ng) Convert to devm_hwmon_device_register_with_groups
Date: Wed, 25 Jun 2014 05:49:31 +0000	[thread overview]
Message-ID: <20140625074931.10342140@endymion.delvare> (raw)
In-Reply-To: <1403609228.348.1.camel@phoenix>

Hi Guenter,

On Tue, 24 Jun 2014 07:38:46 -0700, Guenter Roeck wrote:
> The driver could also benefit from some cleanup. It wastes code space by using
> function macros instead of SENSOR_ATTR_2, and functions should be reordered
> to get rid of forward declarations. Difficult to do without HW or at least
> simulation, though. Jean, do you have a register dump, by any chance ?

I have the following:

     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f
20: c0 c1 c2 XX XX 25 26 XX 88 89 XX ff 00 ff 00 ff
30: 00 XX XX XX XX 50 4b 50 4b XX XX ff ff f0 f0 XX
40: 01 00 00 de fe 00 00 00 XX 00 00 00 a3 5c 80 XX
50: XX 00 04 41 11 XX XX XX XX XX XX XX XX XX XX XX
80: 3c ff ff 00 00 00 00 ff ff 00 00 00 00 33 XX 22
90: 00 14 0a 00 00 00 19 19 XX XX XX XX XX XX XX XX

It was stored under the name w83l786ng-powerup.dump, so it is likely
that I generated it based on the default register values in the
datasheet and this isn't an real chip dump. Hope that helps anyway.

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2014-06-25  5:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 11:27 [lm-sensors] [RFT][PATCH] hwmon: (w83l786ng) Convert to devm_hwmon_device_register_with_groups Axel Lin
2014-06-24 14:38 ` Guenter Roeck
2014-06-25  1:06 ` Axel Lin
2014-06-25  1:48 ` Kevin Lo
2014-06-25  5:49 ` Jean Delvare [this message]
2014-06-25  6:26 ` Guenter Roeck
2014-06-25  6:44 ` Jean Delvare
2014-06-25  7:18 ` Guenter Roeck
2014-06-25 10:29 ` Jean Delvare
2014-06-25 14:17 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140625074931.10342140@endymion.delvare \
    --to=jdelvare@suse.de \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.