From: Axel Lin <axel.lin@ingics.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [RFT][PATCH] hwmon: (w83l786ng) Convert to devm_hwmon_device_register_with_groups
Date: Wed, 25 Jun 2014 01:06:17 +0000 [thread overview]
Message-ID: <CAFRkauDF1DNLayKYcLazJqw7HdXBpQbMK_2nLbQfU8Cv4iq6Wg@mail.gmail.com> (raw)
In-Reply-To: <1403609228.348.1.camel@phoenix>
2014-06-24 22:38 GMT+08:00 Guenter Roeck <linux@roeck-us.net>:
> On 06/24/2014 04:27 AM, Axel Lin wrote:
>>
>> Use ATTRIBUTE_GROUPS macro and devm_hwmon_device_register_with_groups() to
>> simplify the code a bit.
>>
>> The 'sensors' command never worked with this driver, fixed with this
>> conversion.
>>
> Hi Axel,
>
> You'd have to be a bit more specific here. Why ? It is not obvious to me.
> If you mean the 'name' attribute, that is created by the i2c subsystem.
I thought the 'name' attribute was missing, but since it's created by the i2c
subsystem, that would be fine.
>
> The driver is buggy, though. It shows the current fan speed as minimum fan
> speed.
I just sent a patch to fix this.
> Typical bug that can happen easily with function macros. But that is a
> different
> problem.
>
> The driver could also benefit from some cleanup. It wastes code space by
> using
> function macros instead of SENSOR_ATTR_2, and functions should be reordered
> to get rid of forward declarations.
ok. I'll address these issues.
Thanks for your review,
Axel
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2014-06-25 1:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 11:27 [lm-sensors] [RFT][PATCH] hwmon: (w83l786ng) Convert to devm_hwmon_device_register_with_groups Axel Lin
2014-06-24 14:38 ` Guenter Roeck
2014-06-25 1:06 ` Axel Lin [this message]
2014-06-25 1:48 ` Kevin Lo
2014-06-25 5:49 ` Jean Delvare
2014-06-25 6:26 ` Guenter Roeck
2014-06-25 6:44 ` Jean Delvare
2014-06-25 7:18 ` Guenter Roeck
2014-06-25 10:29 ` Jean Delvare
2014-06-25 14:17 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFRkauDF1DNLayKYcLazJqw7HdXBpQbMK_2nLbQfU8Cv4iq6Wg@mail.gmail.com \
--to=axel.lin@ingics.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.