Re: [Qemu-devel] [PATCH 3/4] machine: convert ram_size, maxram_size, ram_slots to properties

From: Igor Mammedov <imammedo@redhat.com>
To: Kirill Batuzov <batuzovk@ispras.ru>
Cc: marcel.a@redhat.com, mst@redhat.com, qemu-devel@nongnu.org,
	agraf@suse.de, pbonzini@redhat.com, afaerber@suse.de,
	stefano.stabellini@eu.citrix.com
Subject: Re: [Qemu-devel] [PATCH 3/4] machine: convert ram_size, maxram_size, ram_slots to properties
Date: Wed, 25 Jun 2014 16:45:15 +0200	[thread overview]
Message-ID: <20140625164515.2e435fc0@nial.usersys.redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1406251747550.4254@bulbul.intra.ispras.ru>

On Wed, 25 Jun 2014 18:09:52 +0400 (MSK)
Kirill Batuzov <batuzovk@ispras.ru> wrote:

> On Wed, 25 Jun 2014, Igor Mammedov wrote:
> 
> >  
> > +    if (ram_size) {
> > +        object_property_set_int(OBJECT(current_machine), ram_size,
> > +                                MACHINE_MEMORY_SIZE_OPT, &local_err);
> > +        if (local_err) {
> > +            error_report("%s", error_get_pretty(local_err));
> > +            error_free(local_err);
> > +            exit(EXIT_FAILURE);
> > +        }
> > +    }
> 
> You can use &error_abort (global variable) instead of &local_err and let
> error_set handle the rest. Like this:
> 
>    if (ram_size) {
>        object_property_set_int(OBJECT(current_machine), ram_size,
>                                MACHINE_MEMORY_SIZE_OPT, &error_abort);
>    }
> 

thanks, I'll use error_abort.