Re: [Qemu-devel] [PATCH 3/4] machine: convert ram_size, maxram_size, ram_slots to properties

From: Kirill Batuzov <batuzovk@ispras.ru>
To: Igor Mammedov <imammedo@redhat.com>
Cc: stefano.stabellini@eu.citrix.com, mst@redhat.com, agraf@suse.de,
	qemu-devel@nongnu.org, pbonzini@redhat.com, marcel.a@redhat.com,
	afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 3/4] machine: convert ram_size, maxram_size, ram_slots to properties
Date: Wed, 25 Jun 2014 18:09:52 +0400 (MSK)	[thread overview]
Message-ID: <alpine.DEB.2.02.1406251747550.4254@bulbul.intra.ispras.ru> (raw)
In-Reply-To: <1403696543-2458-4-git-send-email-imammedo@redhat.com>

On Wed, 25 Jun 2014, Igor Mammedov wrote:

>  
> +    if (ram_size) {
> +        object_property_set_int(OBJECT(current_machine), ram_size,
> +                                MACHINE_MEMORY_SIZE_OPT, &local_err);
> +        if (local_err) {
> +            error_report("%s", error_get_pretty(local_err));
> +            error_free(local_err);
> +            exit(EXIT_FAILURE);
> +        }
> +    }

You can use &error_abort (global variable) instead of &local_err and let
error_set handle the rest. Like this:

   if (ram_size) {
       object_property_set_int(OBJECT(current_machine), ram_size,
                               MACHINE_MEMORY_SIZE_OPT, &error_abort);
   }

-- 
Kirill